1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2022-11-09 12:17:21 -05:00
ruby--ruby/lib/rubygems
David Rodríguez 8c8364c84e Fix ruby setup.rb warnings
Currently we get the following warnings on `ruby setup.rb`:

```
/home/deivid/.rbenv/versions/2.7.1/lib/ruby/site_ruby/2.7.0/rubygems/exceptions.rb:281: warning: already initialized constant Gem::UnsatisfiableDepedencyError
/home/deivid/Code/rubygems/lib/rubygems/exceptions.rb:281: warning: previous definition of UnsatisfiableDepedencyError was here
/home/deivid/.rbenv/versions/2.7.1/lib/ruby/site_ruby/2.7.0/rubygems/user_interaction.rb:557: warning: already initialized constant Gem::StreamUI::ThreadedDownloadReporter::MUTEX
/home/deivid/Code/rubygems/lib/rubygems/user_interaction.rb:557: warning: previous definition of MUTEX was here
/home/deivid/.rbenv/versions/2.7.1/lib/ruby/site_ruby/2.7.0/rubygems/ext/builder.rb:20: warning: already initialized constant Gem::Ext::Builder::CHDIR_MUTEX
/home/deivid/Code/rubygems/lib/rubygems/ext/builder.rb:20: warning: previous definition of CHDIR_MUTEX was here
/home/deivid/.rbenv/versions/2.7.1/lib/ruby/site_ruby/2.7.0/rubygems/ext/ext_conf_builder.rb:14: warning: already initialized constant Gem::Ext::ExtConfBuilder::FileEntry
/home/deivid/Code/rubygems/lib/rubygems/ext/ext_conf_builder.rb:14: warning: previous definition of FileEntry was here
/home/deivid/.rbenv/versions/2.7.1/lib/ruby/site_ruby/2.7.0/rubygems/version.rb:158: warning: already initialized constant Gem::Version::VERSION_PATTERN
/home/deivid/Code/rubygems/lib/rubygems/version.rb:158: warning: previous definition of VERSION_PATTERN was here
/home/deivid/.rbenv/versions/2.7.1/lib/ruby/site_ruby/2.7.0/rubygems/version.rb:159: warning: already initialized constant Gem::Version::ANCHORED_VERSION_PATTERN
/home/deivid/Code/rubygems/lib/rubygems/version.rb:159: warning: previous definition of ANCHORED_VERSION_PATTERN was here
/home/deivid/.rbenv/versions/2.7.1/lib/ruby/site_ruby/2.7.0/rubygems/requirement.rb:14: warning: already initialized constant Gem::Requirement::OPS
/home/deivid/Code/rubygems/lib/rubygems/requirement.rb:14: warning: previous definition of OPS was here
/home/deivid/.rbenv/versions/2.7.1/lib/ruby/site_ruby/2.7.0/rubygems/requirement.rb:24: warning: already initialized constant Gem::Requirement::SOURCE_SET_REQUIREMENT
/home/deivid/Code/rubygems/lib/rubygems/requirement.rb:24: warning: previous definition of SOURCE_SET_REQUIREMENT was here
/home/deivid/.rbenv/versions/2.7.1/lib/ruby/site_ruby/2.7.0/rubygems/requirement.rb:27: warning: already initialized constant Gem::Requirement::PATTERN_RAW
/home/deivid/Code/rubygems/lib/rubygems/requirement.rb:27: warning: previous definition of PATTERN_RAW was here
/home/deivid/.rbenv/versions/2.7.1/lib/ruby/site_ruby/2.7.0/rubygems/requirement.rb:32: warning: already initialized constant Gem::Requirement::PATTERN
/home/deivid/Code/rubygems/lib/rubygems/requirement.rb:32: warning: previous definition of PATTERN was here
/home/deivid/.rbenv/versions/2.7.1/lib/ruby/site_ruby/2.7.0/rubygems/requirement.rb:37: warning: already initialized constant Gem::Requirement::DefaultRequirement
/home/deivid/Code/rubygems/lib/rubygems/requirement.rb:37: warning: previous definition of DefaultRequirement was here
/home/deivid/.rbenv/versions/2.7.1/lib/ruby/site_ruby/2.7.0/rubygems/requirement.rb:42: warning: already initialized constant Gem::Requirement::DefaultPrereleaseRequirement
/home/deivid/Code/rubygems/lib/rubygems/requirement.rb:42: warning: previous definition of DefaultPrereleaseRequirement was here
/home/deivid/.rbenv/versions/2.7.1/lib/ruby/site_ruby/2.7.0/rubygems/requirement.rb:311: warning: already initialized constant Gem::Version::Requirement
/home/deivid/Code/rubygems/lib/rubygems/requirement.rb:311: warning: previous definition of Requirement was here
/home/deivid/.rbenv/versions/2.7.1/lib/ruby/site_ruby/2.7.0/rubygems/command.rb:626: warning: already initialized constant Gem::Command::HELP
/home/deivid/Code/rubygems/lib/rubygems/command.rb:626: warning: previous definition of HELP was here
  Successfully built RubyGem
  Name: bundler
  Version: 2.2.0.dev
  File: bundler-2.2.0.dev.gem
Bundler 2.2.0.dev installed
RubyGems 3.2.0.pre1 installed
Regenerating binstubs
Regenerating plugins

------------------------------------------------------------------------------

RubyGems installed the following executables:
	/home/deivid/.rbenv/versions/2.7.1/bin/gem
	/home/deivid/.rbenv/versions/2.7.1/bin/bundle

```

This is because the `$LOAD_PATH` entry added by `setup.rb` is relatively
and when the offending require happens, we're installing `bundler` and
have switched folders to `bundler/`. So the require fallsback to the
system rubygems.

To avoid that, add an absolute path to the `$LOAD_PATH`.

On jruby, somehow the $LOAD_PATH is manipulated so that we end up
requiring stuff inside the built package even if we have specified the
`-I` flag, so we get redefinition warnings anyways.

I'm not sure about the root cause, but relative requiring fixes it, and
it's faster anyways.
2020-06-05 07:32:42 +09:00
..
commands [rubygems/rubygems] Fix template cleanup as well 2020-06-05 07:32:42 +09:00
core_ext [rubygems/rubygems] Simplify nested require exceptions 2020-05-08 14:13:29 +09:00
ext Fix ruby setup.rb warnings 2020-06-05 07:32:42 +09:00
package [rubygems/rubygems] Allow spaces in file headers during octal check 2020-05-08 14:13:29 +09:00
request
request_set Merge the current master branch of rubygems/rubygems. 2020-02-01 11:14:57 +09:00
resolver [rubygems/rubygems] Remove misleading comment 2020-03-30 12:49:34 +09:00
security [rubygems/rubygems] Remove ruby 1.8 leftovers 2020-03-30 12:49:24 +09:00
source [rubygems/rubygems] Enable Style/PercentLiteralDelimiters cop in rubygems 2020-03-30 12:42:10 +09:00
ssl_certs
util [rubygems/rubygems] Enable Style/PercentLiteralDelimiters cop in rubygems 2020-03-30 12:42:10 +09:00
available_set.rb
basic_specification.rb [rubygems/rubygems] Fix platform comparison bug in #contains_requirable_file? 2020-05-08 07:38:50 +09:00
bundler_version_finder.rb Sync rubygems with current master (#2889) 2020-03-24 15:39:24 +09:00
command.rb Fix ruby setup.rb warnings 2020-06-05 07:32:42 +09:00
command_manager.rb Merge the current master branch of rubygems/rubygems. 2020-02-01 11:14:57 +09:00
compatibility.rb
config_file.rb Support XDG_* (#2174) 2020-04-23 19:16:06 +09:00
defaults.rb Support XDG_* (#2174) 2020-04-23 19:16:06 +09:00
dependency.rb
dependency_installer.rb [rubygems/rubygems] Rename version horizon deprecation methods 2020-05-08 07:38:50 +09:00
dependency_list.rb
deprecate.rb [rubygems/rubygems] Revert deprecation of deprecate method for now. 2020-05-08 07:38:50 +09:00
doctor.rb Merge the current master branch of rubygems/rubygems. 2020-02-01 11:14:57 +09:00
errors.rb [rubygems/rubygems] Make MissingSpecError accept an extra error message 2020-05-08 14:13:29 +09:00
exceptions.rb Merge the current master branch of rubygems/rubygems. 2020-02-01 11:14:57 +09:00
ext.rb Fix ruby setup.rb warnings 2020-06-05 07:32:42 +09:00
gem_runner.rb Merge the current master branch of rubygems/rubygems. 2020-02-01 11:14:57 +09:00
gemcutter_utilities.rb Support XDG_* (#2174) 2020-04-23 19:16:06 +09:00
indexer.rb [rubygems/rubygems] Remove unnecessary code 2020-05-08 14:13:29 +09:00
install_default_message.rb
install_message.rb
install_update_options.rb [rubygems/rubygems] Enable Style/ExtraSpacing and auto-correct 2020-03-30 12:48:23 +09:00
installer.rb Revert a commit miss in "Fixed potential memory leak" 2020-05-22 21:24:51 +09:00
installer_test_case.rb [rubygems/rubygems] Fix symlink RubyGems test problems for non-admin user. 2020-05-08 14:13:29 +09:00
installer_uninstaller_utils.rb Sync rubygems with current master (#2889) 2020-03-24 15:39:24 +09:00
local_remote_options.rb
mock_gem_ui.rb
name_tuple.rb Merge RubyGems 3.1.0.pre3 2019-11-11 16:59:49 +09:00
package.rb [rubygems/rubygems] Make sure rubygems/package can be directly required reliably 2020-06-05 07:32:42 +09:00
package_task.rb [rubygems/rubygems] Make rake package log messages to stdout by default 2020-06-05 07:32:42 +09:00
path_support.rb Merge RubyGems 3.1.0.pre3 2019-11-11 16:59:49 +09:00
platform.rb [rubygems/rubygems] Enable Style/ExtraSpacing and auto-correct 2020-03-30 12:48:23 +09:00
psych_additions.rb
psych_tree.rb
query_utils.rb Merge the current master branch of rubygems/rubygems. 2020-02-01 11:14:57 +09:00
rdoc.rb
remote_fetcher.rb [rubygems/rubygems] Prefer start_with? and end_with? over regex. 2020-06-05 07:32:42 +09:00
request.rb Prepare to release RubyGems 3.1.0 final version. 2019-12-13 20:19:33 +09:00
request_set.rb Merge RubyGems 3.1.0.pre3 2019-11-11 16:59:49 +09:00
requirement.rb
resolver.rb
s3_uri_signer.rb
safe_yaml.rb [rubygems/rubygems] Enable Style/PercentLiteralDelimiters cop in rubygems 2020-03-30 12:42:10 +09:00
security.rb Merge the current master branch of rubygems/rubygems. 2020-02-01 11:14:57 +09:00
security_option.rb
server.rb [rubygems/rubygems] Enable Style/PercentLiteralDelimiters cop in rubygems 2020-03-30 12:42:10 +09:00
source.rb [rubygems/rubygems] Move require uri to source_list 2019-12-17 22:33:44 +09:00
source_list.rb [rubygems/rubygems] Move require uri to source_list 2019-12-17 22:33:44 +09:00
spec_fetcher.rb Sync rubygems with current master (#2889) 2020-03-24 15:39:24 +09:00
specification.rb [rubygems/rubygems] Prefer start_with? and end_with? over regex. 2020-06-05 07:32:42 +09:00
specification_policy.rb Fix ruby setup.rb warnings 2020-06-05 07:32:42 +09:00
stub_specification.rb Merge RubyGems 3.1.0.pre3 2019-11-11 16:59:49 +09:00
syck_hack.rb
test_case.rb Revert "[rubygems/rubygems] Remove unneeded global teardown" 2020-05-08 14:13:29 +09:00
test_utilities.rb [rubygems/rubygems] Prefer start_with? and end_with? over regex. 2020-06-05 07:32:42 +09:00
text.rb
uninstaller.rb Sync rubygems with current master (#2889) 2020-03-24 15:39:24 +09:00
uri_formatter.rb Prepare to release RubyGems 3.1.0 final version. 2019-12-13 20:19:33 +09:00
uri_parser.rb Prepare to release RubyGems 3.1.0 final version. 2019-12-13 20:19:33 +09:00
uri_parsing.rb Prepare to release RubyGems 3.1.0 final version. 2019-12-13 20:19:33 +09:00
user_interaction.rb Merge the current master branch of rubygems/rubygems. 2020-02-01 11:14:57 +09:00
util.rb [rubygems/rubygems] Improve gzip errors logging 2020-05-08 14:13:29 +09:00
validator.rb
version.rb [rubygems/rubygems] Enable Style/ExtraSpacing and auto-correct 2020-03-30 12:48:23 +09:00
version_option.rb