1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2022-11-09 12:17:21 -05:00
ruby--ruby/spec/ruby/core/string/delete_spec.rb
Jeremy Evans 58325daae3 Make String methods return String instances when called on a subclass instance
This modifies the following String methods to return String instances
instead of subclass instances:

* String#*
* String#capitalize
* String#center
* String#chomp
* String#chop
* String#delete
* String#delete_prefix
* String#delete_suffix
* String#downcase
* String#dump
* String#each/#each_line
* String#gsub
* String#ljust
* String#lstrip
* String#partition
* String#reverse
* String#rjust
* String#rpartition
* String#rstrip
* String#scrub
* String#slice!
* String#slice/#[]
* String#split
* String#squeeze
* String#strip
* String#sub
* String#succ/#next
* String#swapcase
* String#tr
* String#tr_s
* String#upcase

This also fixes a bug in String#swapcase where it would return the
receiver instead of a copy of the receiver if the receiver was the
empty string.

Some string methods were left to return subclass instances:

* String#+@
* String#-@

Both of these methods will return the receiver (subclass instance)
in some cases, so it is best to keep the returned class consistent.

Fixes [#10845]
2020-11-20 16:30:23 -08:00

129 lines
4 KiB
Ruby

# -*- encoding: utf-8 -*-
require_relative '../../spec_helper'
require_relative 'fixtures/classes'
describe "String#delete" do
it "returns a new string with the chars from the intersection of sets removed" do
s = "hello"
s.delete("lo").should == "he"
s.should == "hello"
"hello".delete("l", "lo").should == "heo"
"hell yeah".delete("").should == "hell yeah"
end
it "raises an ArgumentError when given no arguments" do
-> { "hell yeah".delete }.should raise_error(ArgumentError)
end
it "negates sets starting with ^" do
"hello".delete("aeiou", "^e").should == "hell"
"hello".delete("^leh").should == "hell"
"hello".delete("^o").should == "o"
"hello".delete("^").should == "hello"
"^_^".delete("^^").should == "^^"
"oa^_^o".delete("a^").should == "o_o"
end
it "deletes all chars in a sequence" do
"hello".delete("ej-m").should == "ho"
"hello".delete("e-h").should == "llo"
"hel-lo".delete("e-").should == "hllo"
"hel-lo".delete("-h").should == "ello"
"hel-lo".delete("---").should == "hello"
"hel-012".delete("--2").should == "hel"
"hel-()".delete("(--").should == "hel"
"hello".delete("^e-h").should == "he"
"hello^".delete("^^-^").should == "^"
"hel--lo".delete("^---").should == "--"
"abcdefgh".delete("a-ce-fh").should == "dg"
"abcdefgh".delete("he-fa-c").should == "dg"
"abcdefgh".delete("e-fha-c").should == "dg"
"abcde".delete("ac-e").should == "b"
"abcde".delete("^ac-e").should == "acde"
"ABCabc[]".delete("A-a").should == "bc"
end
it "deletes multibyte characters" do
"四月".delete("").should == ""
'哥哥我倒'.delete('哥').should == "我倒"
end
it "respects backslash for escaping a -" do
'Non-Authoritative Information'.delete(' \-\'').should ==
'NonAuthoritativeInformation'
end
it "raises if the given ranges are invalid" do
not_supported_on :opal do
xFF = [0xFF].pack('C')
range = "\x00 - #{xFF}".force_encoding('utf-8')
-> { "hello".delete(range).should == "" }.should raise_error(ArgumentError)
end
-> { "hello".delete("h-e") }.should raise_error(ArgumentError)
-> { "hello".delete("^h-e") }.should raise_error(ArgumentError)
end
ruby_version_is ''...'2.7' do
it "taints result when self is tainted" do
"hello".taint.delete("e").should.tainted?
"hello".taint.delete("a-z").should.tainted?
"hello".delete("e".taint).should_not.tainted?
end
end
it "tries to convert each set arg to a string using to_str" do
other_string = mock('lo')
other_string.should_receive(:to_str).and_return("lo")
other_string2 = mock('o')
other_string2.should_receive(:to_str).and_return("o")
"hello world".delete(other_string, other_string2).should == "hell wrld"
end
it "raises a TypeError when one set arg can't be converted to a string" do
-> { "hello world".delete(100) }.should raise_error(TypeError)
-> { "hello world".delete([]) }.should raise_error(TypeError)
-> { "hello world".delete(mock('x')) }.should raise_error(TypeError)
end
ruby_version_is ''...'3.0' do
it "returns subclass instances when called on a subclass" do
StringSpecs::MyString.new("oh no!!!").delete("!").should be_an_instance_of(StringSpecs::MyString)
end
end
ruby_version_is '3.0' do
it "returns String instances when called on a subclass" do
StringSpecs::MyString.new("oh no!!!").delete("!").should be_an_instance_of(String)
end
end
end
describe "String#delete!" do
it "modifies self in place and returns self" do
a = "hello"
a.delete!("aeiou", "^e").should equal(a)
a.should == "hell"
end
it "returns nil if no modifications were made" do
a = "hello"
a.delete!("z").should == nil
a.should == "hello"
end
it "raises a FrozenError when self is frozen" do
a = "hello"
a.freeze
-> { a.delete!("") }.should raise_error(FrozenError)
-> { a.delete!("aeiou", "^e") }.should raise_error(FrozenError)
end
end