1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2022-11-09 12:17:21 -05:00
ruby--ruby/spec/ruby/language/safe_spec.rb
Jeremy Evans c5c05460ac Warn on access/modify of $SAFE, and remove effects of modifying $SAFE
This removes the security features added by $SAFE = 1, and warns for access
or modification of $SAFE from Ruby-level, as well as warning when calling
all public C functions related to $SAFE.

This modifies some internal functions that took a safe level argument
to no longer take the argument.

rb_require_safe now warns, rb_require_string has been added as a
version that takes a VALUE and does not warn.

One public C function that still takes a safe level argument and that
this doesn't warn for is rb_eval_cmd.  We may want to consider
adding an alternative method that does not take a safe level argument,
and warn for rb_eval_cmd.
2019-11-18 01:00:25 +02:00

138 lines
2.9 KiB
Ruby

require_relative '../spec_helper'
describe "The $SAFE variable" do
ruby_version_is ""..."2.7" do
ruby_version_is "2.6" do
after :each do
$SAFE = 0
end
end
it "is 0 by default" do
$SAFE.should == 0
proc {
$SAFE.should == 0
}.call
end
it "can be set to 0" do
proc {
$SAFE = 0
$SAFE.should == 0
}.call
end
it "can be set to 1" do
proc {
$SAFE = 1
$SAFE.should == 1
}.call
end
[2, 3, 4].each do |n|
it "cannot be set to #{n}" do
-> {
proc {
$SAFE = n
}.call
}.should raise_error(ArgumentError, /\$SAFE=2 to 4 are obsolete/)
end
end
ruby_version_is ""..."2.6" do
it "cannot be set to values below 0" do
-> {
proc {
$SAFE = -100
}.call
}.should raise_error(SecurityError, /tried to downgrade safe level from 0 to -100/)
end
end
ruby_version_is "2.6" do
it "raises ArgumentError when set to values below 0" do
-> {
proc {
$SAFE = -100
}.call
}.should raise_error(ArgumentError, "$SAFE should be >= 0")
end
end
it "cannot be set to values above 4" do
-> {
proc {
$SAFE = 100
}.call
}.should raise_error(ArgumentError, /\$SAFE=2 to 4 are obsolete/)
end
ruby_version_is ""..."2.6" do
it "cannot be manually lowered" do
proc {
$SAFE = 1
-> {
$SAFE = 0
}.should raise_error(SecurityError, /tried to downgrade safe level from 1 to 0/)
}.call
end
it "is automatically lowered when leaving a proc" do
$SAFE.should == 0
proc {
$SAFE = 1
}.call
$SAFE.should == 0
end
it "is automatically lowered when leaving a lambda" do
$SAFE.should == 0
-> {
$SAFE = 1
}.call
$SAFE.should == 0
end
end
ruby_version_is "2.6" do
it "can be manually lowered" do
$SAFE = 1
$SAFE = 0
$SAFE.should == 0
end
it "is not Proc local" do
$SAFE.should == 0
proc {
$SAFE = 1
}.call
$SAFE.should == 1
end
it "is not lambda local" do
$SAFE.should == 0
-> {
$SAFE = 1
}.call
$SAFE.should == 1
end
it "is global like regular global variables" do
Thread.new { $SAFE }.value.should == 0
$SAFE = 1
Thread.new { $SAFE }.value.should == 1
end
end
it "can be read when default from Thread#safe_level" do
Thread.current.safe_level.should == 0
end
it "can be read when modified from Thread#safe_level" do
proc {
$SAFE = 1
Thread.current.safe_level.should == 1
}.call
end
end
end