1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2022-11-09 12:17:21 -05:00
ruby--ruby/test/test_delegate.rb
Jonathan Hefner 6061003100 [ruby/delegate] Fix DelegateClass block "method redefined" warning
This commit prevents "method redefined" warnings when overriding methods
within a `DelegateClass` block, such as in the following example:

  ```ruby
  Base = Class.new do
    def foo
      "foo"
    end
  end

  Overridden = DelegateClass(Base) do
    def foo
      super + "!"
    end
  end
  ```

Fixes https://bugs.ruby-lang.org/issues/19047.

https://github.com/ruby/delegate/commit/214fae86de
2022-10-15 00:08:44 +09:00

414 lines
11 KiB
Ruby

# frozen_string_literal: true
require 'test/unit'
require 'delegate'
class TestDelegateClass < Test::Unit::TestCase
module PP
def mu_pp(obj)
str = super
str = "#<#{obj.class}: #{str}>" if Delegator === obj
str
end
end
module M
attr_reader :m
end
def test_extend
obj = DelegateClass(Array).new([])
obj.instance_eval { @m = :m }
obj.extend M
assert_equal(:m, obj.m, "[ruby-dev:33116]")
end
def test_delegate_class_block
klass = DelegateClass(Array) do
alias foo first
end
assert_equal(1, klass.new([1]).foo)
end
def test_delegate_class_block_with_override
warning = EnvUtil.verbose_warning do
klass = DelegateClass(Array) do
def first
super.inspect
end
end
assert_equal("1", klass.new([1]).first)
end
assert_empty(warning)
end
def test_systemcallerror_eq
e = SystemCallError.new(0)
assert((SimpleDelegator.new(e) == e) == (e == SimpleDelegator.new(e)), "[ruby-dev:34808]")
end
class Myclass < DelegateClass(Array);end
def test_delegateclass_class
myclass=Myclass.new([])
assert_equal(Myclass,myclass.class)
assert_equal(Myclass,myclass.dup.class,'[ruby-dev:40313]')
assert_equal(Myclass,myclass.clone.class,'[ruby-dev:40313]')
end
def test_simpledelegator_class
simple=SimpleDelegator.new([])
assert_equal(SimpleDelegator,simple.class)
assert_equal(SimpleDelegator,simple.dup.class)
assert_equal(SimpleDelegator,simple.clone.class)
end
def test_simpledelegator_clone
simple=SimpleDelegator.new([])
simple.freeze
clone = simple.clone
assert_predicate clone, :frozen?
assert_predicate clone.__getobj__, :frozen?
assert_equal true, Kernel.instance_method(:frozen?).bind(clone).call
clone = simple.clone(freeze: false)
assert_not_predicate clone, :frozen?
assert_not_predicate clone.__getobj__, :frozen?
assert_equal false, Kernel.instance_method(:frozen?).bind(clone).call
end
class Object
def m
:o
end
private
def delegate_test_m
:o
end
end
class Foo
def m
:m
end
def delegate_test_m
:m
end
end
class Bar < DelegateClass(Foo)
end
def test_override
foo = Foo.new
foo2 = SimpleDelegator.new(foo)
bar = Bar.new(foo)
assert_equal(:o, Object.new.m)
assert_equal(:m, foo.m)
assert_equal(:m, foo2.m)
assert_equal(:m, bar.m)
bug = '[ruby-dev:39154]'
assert_equal(:m, foo2.send(:delegate_test_m), bug)
assert_equal(:m, bar.send(:delegate_test_m), bug)
end
class Parent
def parent_public; end
protected
def parent_protected; end
private
def parent_private; end
end
class Child < DelegateClass(Parent)
end
class Parent
def parent_public_added; end
protected
def parent_protected_added; end
private
def parent_private_added; end
end
def test_public_instance_methods
ignores = Object.public_instance_methods | Delegator.public_instance_methods
assert_equal([:parent_public, :parent_public_added], (Child.public_instance_methods - ignores).sort)
assert_equal([:parent_public, :parent_public_added], (Child.new(Parent.new).public_methods - ignores).sort)
end
def test_protected_instance_methods
ignores = Object.protected_instance_methods | Delegator.protected_instance_methods
assert_equal([:parent_protected, :parent_protected_added], (Child.protected_instance_methods - ignores).sort)
assert_equal([:parent_protected, :parent_protected_added], (Child.new(Parent.new).protected_methods - ignores).sort)
end
def test_instance_methods
ignores = Object.instance_methods | Delegator.instance_methods
assert_equal([:parent_protected, :parent_protected_added, :parent_public, :parent_public_added], (Child.instance_methods - ignores).sort)
assert_equal([:parent_protected, :parent_protected_added, :parent_public, :parent_public_added], (Child.new(Parent.new).methods - ignores).sort)
end
def test_DelegateClass_instance_method
assert_instance_of UnboundMethod, Child.instance_method(:parent_public)
assert_instance_of UnboundMethod, Child.instance_method(:parent_public_added)
assert_instance_of UnboundMethod, Child.instance_method(:parent_protected)
assert_instance_of UnboundMethod, Child.instance_method(:parent_protected_added)
assert_raise(NameError) { Child.instance_method(:parent_private) }
assert_raise(NameError) { Child.instance_method(:parent_private_added) }
assert_instance_of UnboundMethod, Child.instance_method(:to_s)
end
def test_DelegateClass_public_instance_method
assert_instance_of UnboundMethod, Child.public_instance_method(:parent_public)
assert_instance_of UnboundMethod, Child.public_instance_method(:parent_public_added)
assert_raise(NameError) { Child.public_instance_method(:parent_protected) }
assert_raise(NameError) { Child.public_instance_method(:parent_protected_added) }
assert_raise(NameError) { Child.instance_method(:parent_private) }
assert_raise(NameError) { Child.instance_method(:parent_private_added) }
assert_instance_of UnboundMethod, Child.public_instance_method(:to_s)
end
class IV < DelegateClass(Integer)
attr_accessor :var
def initialize
@var = 1
super(0)
end
end
def test_marshal
bug1744 = '[ruby-core:24211]'
c = IV.new
assert_equal(1, c.var)
d = Marshal.load(Marshal.dump(c))
assert_equal(1, d.var, bug1744)
end
def test_copy_frozen
bug2679 = '[ruby-dev:40242]'
a = [42, :hello].freeze
d = SimpleDelegator.new(a)
assert_nothing_raised(bug2679) {d.dup[0] += 1}
assert_raise(FrozenError) {d.clone[0] += 1}
d.freeze
assert(d.clone.frozen?)
assert(!d.dup.frozen?)
end
def test_frozen
d = SimpleDelegator.new([1, :foo])
d.freeze
assert_raise(FrozenError, '[ruby-dev:40314]#1') {d.__setobj__("foo")}
assert_equal([1, :foo], d)
end
def test_instance_method
s = SimpleDelegator.new("foo")
m = s.method("upcase")
s.__setobj__([1,2,3])
assert_raise(NoMethodError, '[ruby-dev:40314]#3') {m.call}
end
def test_methods
s = SimpleDelegator.new("foo")
assert_equal([], s.methods(false))
def s.bar; end
assert_equal([:bar], s.methods(false))
end
def test_eql?
extend PP
s0 = SimpleDelegator.new("foo")
s1 = SimpleDelegator.new("bar")
s2 = SimpleDelegator.new("foo")
assert_operator(s0, :eql?, s0)
assert_operator(s0, :eql?, "foo")
assert_operator(s0, :eql?, s2)
assert_not_operator(s0, :eql?, s1)
assert_not_operator(s0, :eql?, "bar")
end
def test_keyword_and_hash
foo = Object.new
def foo.bar(*args)
args
end
def foo.foo(*args, **kw)
[args, kw]
end
d = SimpleDelegator.new(foo)
assert_equal([[], {}], d.foo)
assert_equal([], d.bar)
assert_equal([[], {:a=>1}], d.foo(:a=>1))
assert_equal([{:a=>1}], d.bar(:a=>1))
assert_equal([[{:a=>1}], {}], d.foo({:a=>1}))
assert_equal([{:a=>1}], d.bar({:a=>1}))
end
class Foo
private
def delegate_test_private
:m
end
end
def test_private_method
foo = Foo.new
d = SimpleDelegator.new(foo)
assert_raise(NoMethodError) {foo.delegate_test_private}
assert_equal(:m, foo.send(:delegate_test_private))
assert_raise(NoMethodError, '[ruby-dev:40314]#4') {d.delegate_test_private}
assert_raise(NoMethodError, '[ruby-dev:40314]#5') {d.send(:delegate_test_private)}
end
def test_global_function
klass = Class.new do
def open
end
end
obj = klass.new
d = SimpleDelegator.new(obj)
assert_nothing_raised(ArgumentError) {obj.open}
assert_nothing_raised(ArgumentError) {d.open}
assert_nothing_raised(ArgumentError) {d.send(:open)}
end
def test_send_method_in_delegator
d = Class.new(SimpleDelegator) do
def foo
"foo"
end
end.new(Object.new)
assert_equal("foo", d.send(:foo))
end
def test_unset_simple_delegator
d = SimpleDelegator.allocate
assert_raise_with_message(ArgumentError, /not delegated/) {
d.__getobj__
}
end
def test_unset_delegate_class
d = IV.allocate
assert_raise_with_message(ArgumentError, /not delegated/) {
d.__getobj__
}
end
class Bug9155 < DelegateClass(Integer)
def initialize(value)
super(Integer(value))
end
end
def test_global_method_if_no_target
bug9155 = '[ruby-core:58572] [Bug #9155]'
x = assert_nothing_raised(ArgumentError, bug9155) {break Bug9155.new(1)}
assert_equal(1, x.to_i, bug9155)
end
class Bug9403
Name = '[ruby-core:59718] [Bug #9403]'
SD = SimpleDelegator.new(new)
class << SD
def method_name
__method__
end
def callee_name
__callee__
end
alias aliased_name callee_name
def dir_name
__dir__
end
end
dc = DelegateClass(self)
dc.class_eval do
def method_name
__method__
end
def callee_name
__callee__
end
alias aliased_name callee_name
def dir_name
__dir__
end
end
DC = dc.new(new)
end
def test_method_in_simple_delegator
assert_equal(:method_name, Bug9403::SD.method_name, Bug9403::Name)
end
def test_callee_in_simple_delegator
assert_equal(:callee_name, Bug9403::SD.callee_name, Bug9403::Name)
assert_equal(:aliased_name, Bug9403::SD.aliased_name, Bug9403::Name)
end
def test_dir_in_simple_delegator
assert_equal(__dir__, Bug9403::SD.dir_name, Bug9403::Name)
end
def test_method_in_delegator_class
assert_equal(:method_name, Bug9403::DC.method_name, Bug9403::Name)
end
def test_callee_in_delegator_class
assert_equal(:callee_name, Bug9403::DC.callee_name, Bug9403::Name)
assert_equal(:aliased_name, Bug9403::DC.aliased_name, Bug9403::Name)
end
def test_dir_in_delegator_class
assert_equal(__dir__, Bug9403::DC.dir_name, Bug9403::Name)
end
def test_module_methods_vs_kernel_methods
delegate = SimpleDelegator.new(Object.new)
assert_raise(NoMethodError) do
delegate.constants
end
end
def test_basicobject
o = BasicObject.new
def o.bar; 1; end
delegate = SimpleDelegator.new(o)
assert_equal(1, delegate.bar)
assert_raise(NoMethodError, /undefined method `foo' for/) { delegate.foo }
end
def test_basicobject_respond_to
o = BasicObject.new
def o.bar
nil
end
def o.respond_to?(method, include_private=false)
return false if method == :bar
::Kernel.instance_method(:respond_to?).bind_call(self, method, include_private)
end
delegate = SimpleDelegator.new(o)
refute delegate.respond_to?(:bar)
end
def test_keyword_argument
k = EnvUtil.labeled_class("Target") do
def test(a, k:) [a, k]; end
end
a = DelegateClass(k).new(k.new)
assert_equal([1, 0], a.test(1, k: 0))
end
end