mirror of
https://github.com/ruby/ruby.git
synced 2022-11-09 12:17:21 -05:00
b957c3dbcb
This changes "test/rubygems/test_case.rb" to "test/rubygems/helper.rb",
and "test/rubygems/test_utilities.rb" to "test/rubygems/utilities.rb".
The two files are a helper for tests, not test files. However, a file
starting with "test_" prefix is handled as a test file directly loaded
by test-unit because Rakefile specifies:
```
t.test_files = FileList['test/**/test_*.rb']
```
Directly loading test/rubygems/test_utilities.rb caused "uninitialized
constant Gem::TestCase". This issue was fixed by
59c6820971, but the fix caused a
"circular require" warning because test_utilities.rb and test_case.rb
are now requiring each other.
Anyway, adding "test_" prefix to a test helper file is confusing, so
this changeset reverts the fix and solve the issue by renaming them.
https://github.com/rubygems/rubygems/commit/6460e018df
81 lines
2.1 KiB
Ruby
81 lines
2.1 KiB
Ruby
# frozen_string_literal: true
|
|
require_relative 'helper'
|
|
require 'rubygems/ext'
|
|
|
|
class TestGemExtCmakeBuilder < Gem::TestCase
|
|
def setup
|
|
super
|
|
|
|
# Details: https://github.com/rubygems/rubygems/issues/1270#issuecomment-177368340
|
|
pend "CmakeBuilder doesn't work on Windows." if Gem.win_platform?
|
|
|
|
begin
|
|
_, status = Open3.capture2e('cmake')
|
|
pend 'cmake not present' unless status.success?
|
|
rescue Errno::ENOENT
|
|
pend 'cmake not present'
|
|
end
|
|
|
|
@ext = File.join @tempdir, 'ext'
|
|
@dest_path = File.join @tempdir, 'prefix'
|
|
|
|
FileUtils.mkdir_p @ext
|
|
FileUtils.mkdir_p @dest_path
|
|
end
|
|
|
|
def test_self_build
|
|
File.open File.join(@ext, 'CMakeLists.txt'), 'w' do |cmakelists|
|
|
cmakelists.write <<-EO_CMAKE
|
|
cmake_minimum_required(VERSION 2.6)
|
|
project(self_build NONE)
|
|
install (FILES test.txt DESTINATION bin)
|
|
EO_CMAKE
|
|
end
|
|
|
|
FileUtils.touch File.join(@ext, 'test.txt')
|
|
|
|
output = []
|
|
|
|
Gem::Ext::CmakeBuilder.build nil, @dest_path, output, [], nil, @ext
|
|
|
|
output = output.join "\n"
|
|
|
|
assert_match %r{^cmake \. -DCMAKE_INSTALL_PREFIX\\=#{Regexp.escape @dest_path}}, output
|
|
assert_match %r{#{Regexp.escape @ext}}, output
|
|
assert_contains_make_command '', output
|
|
assert_contains_make_command 'install', output
|
|
assert_match %r{test\.txt}, output
|
|
end
|
|
|
|
def test_self_build_fail
|
|
output = []
|
|
|
|
error = assert_raise Gem::InstallError do
|
|
Gem::Ext::CmakeBuilder.build nil, @dest_path, output, [], nil, @ext
|
|
end
|
|
|
|
output = output.join "\n"
|
|
|
|
shell_error_msg = %r{(CMake Error: .*)}
|
|
|
|
assert_match 'cmake failed', error.message
|
|
|
|
assert_match %r{^cmake . -DCMAKE_INSTALL_PREFIX\\=#{Regexp.escape @dest_path}}, output
|
|
assert_match %r{#{shell_error_msg}}, output
|
|
end
|
|
|
|
def test_self_build_has_makefile
|
|
File.open File.join(@ext, 'Makefile'), 'w' do |makefile|
|
|
makefile.puts "all:\n\t@echo ok\ninstall:\n\t@echo ok"
|
|
end
|
|
|
|
output = []
|
|
|
|
Gem::Ext::CmakeBuilder.build nil, @dest_path, output, [], nil, @ext
|
|
|
|
output = output.join "\n"
|
|
|
|
assert_contains_make_command '', output
|
|
assert_contains_make_command 'install', output
|
|
end
|
|
end
|