mirror of
https://github.com/ruby/ruby.git
synced 2022-11-09 12:17:21 -05:00
8c8364c84e
Currently we get the following warnings on `ruby setup.rb`: ``` /home/deivid/.rbenv/versions/2.7.1/lib/ruby/site_ruby/2.7.0/rubygems/exceptions.rb:281: warning: already initialized constant Gem::UnsatisfiableDepedencyError /home/deivid/Code/rubygems/lib/rubygems/exceptions.rb:281: warning: previous definition of UnsatisfiableDepedencyError was here /home/deivid/.rbenv/versions/2.7.1/lib/ruby/site_ruby/2.7.0/rubygems/user_interaction.rb:557: warning: already initialized constant Gem::StreamUI::ThreadedDownloadReporter::MUTEX /home/deivid/Code/rubygems/lib/rubygems/user_interaction.rb:557: warning: previous definition of MUTEX was here /home/deivid/.rbenv/versions/2.7.1/lib/ruby/site_ruby/2.7.0/rubygems/ext/builder.rb:20: warning: already initialized constant Gem::Ext::Builder::CHDIR_MUTEX /home/deivid/Code/rubygems/lib/rubygems/ext/builder.rb:20: warning: previous definition of CHDIR_MUTEX was here /home/deivid/.rbenv/versions/2.7.1/lib/ruby/site_ruby/2.7.0/rubygems/ext/ext_conf_builder.rb:14: warning: already initialized constant Gem::Ext::ExtConfBuilder::FileEntry /home/deivid/Code/rubygems/lib/rubygems/ext/ext_conf_builder.rb:14: warning: previous definition of FileEntry was here /home/deivid/.rbenv/versions/2.7.1/lib/ruby/site_ruby/2.7.0/rubygems/version.rb:158: warning: already initialized constant Gem::Version::VERSION_PATTERN /home/deivid/Code/rubygems/lib/rubygems/version.rb:158: warning: previous definition of VERSION_PATTERN was here /home/deivid/.rbenv/versions/2.7.1/lib/ruby/site_ruby/2.7.0/rubygems/version.rb:159: warning: already initialized constant Gem::Version::ANCHORED_VERSION_PATTERN /home/deivid/Code/rubygems/lib/rubygems/version.rb:159: warning: previous definition of ANCHORED_VERSION_PATTERN was here /home/deivid/.rbenv/versions/2.7.1/lib/ruby/site_ruby/2.7.0/rubygems/requirement.rb:14: warning: already initialized constant Gem::Requirement::OPS /home/deivid/Code/rubygems/lib/rubygems/requirement.rb:14: warning: previous definition of OPS was here /home/deivid/.rbenv/versions/2.7.1/lib/ruby/site_ruby/2.7.0/rubygems/requirement.rb:24: warning: already initialized constant Gem::Requirement::SOURCE_SET_REQUIREMENT /home/deivid/Code/rubygems/lib/rubygems/requirement.rb:24: warning: previous definition of SOURCE_SET_REQUIREMENT was here /home/deivid/.rbenv/versions/2.7.1/lib/ruby/site_ruby/2.7.0/rubygems/requirement.rb:27: warning: already initialized constant Gem::Requirement::PATTERN_RAW /home/deivid/Code/rubygems/lib/rubygems/requirement.rb:27: warning: previous definition of PATTERN_RAW was here /home/deivid/.rbenv/versions/2.7.1/lib/ruby/site_ruby/2.7.0/rubygems/requirement.rb:32: warning: already initialized constant Gem::Requirement::PATTERN /home/deivid/Code/rubygems/lib/rubygems/requirement.rb:32: warning: previous definition of PATTERN was here /home/deivid/.rbenv/versions/2.7.1/lib/ruby/site_ruby/2.7.0/rubygems/requirement.rb:37: warning: already initialized constant Gem::Requirement::DefaultRequirement /home/deivid/Code/rubygems/lib/rubygems/requirement.rb:37: warning: previous definition of DefaultRequirement was here /home/deivid/.rbenv/versions/2.7.1/lib/ruby/site_ruby/2.7.0/rubygems/requirement.rb:42: warning: already initialized constant Gem::Requirement::DefaultPrereleaseRequirement /home/deivid/Code/rubygems/lib/rubygems/requirement.rb:42: warning: previous definition of DefaultPrereleaseRequirement was here /home/deivid/.rbenv/versions/2.7.1/lib/ruby/site_ruby/2.7.0/rubygems/requirement.rb:311: warning: already initialized constant Gem::Version::Requirement /home/deivid/Code/rubygems/lib/rubygems/requirement.rb:311: warning: previous definition of Requirement was here /home/deivid/.rbenv/versions/2.7.1/lib/ruby/site_ruby/2.7.0/rubygems/command.rb:626: warning: already initialized constant Gem::Command::HELP /home/deivid/Code/rubygems/lib/rubygems/command.rb:626: warning: previous definition of HELP was here Successfully built RubyGem Name: bundler Version: 2.2.0.dev File: bundler-2.2.0.dev.gem Bundler 2.2.0.dev installed RubyGems 3.2.0.pre1 installed Regenerating binstubs Regenerating plugins ------------------------------------------------------------------------------ RubyGems installed the following executables: /home/deivid/.rbenv/versions/2.7.1/bin/gem /home/deivid/.rbenv/versions/2.7.1/bin/bundle ``` This is because the `$LOAD_PATH` entry added by `setup.rb` is relatively and when the offending require happens, we're installing `bundler` and have switched folders to `bundler/`. So the require fallsback to the system rubygems. To avoid that, add an absolute path to the `$LOAD_PATH`. On jruby, somehow the $LOAD_PATH is manipulated so that we end up requiring stuff inside the built package even if we have specified the `-I` flag, so we get redefinition warnings anyways. I'm not sure about the root cause, but relative requiring fixes it, and it's faster anyways.
231 lines
5.9 KiB
Ruby
231 lines
5.9 KiB
Ruby
# frozen_string_literal: true
|
|
#--
|
|
# Copyright 2006 by Chad Fowler, Rich Kilmer, Jim Weirich and others.
|
|
# All rights reserved.
|
|
# See LICENSE.txt for permissions.
|
|
#++
|
|
|
|
require_relative '../user_interaction'
|
|
|
|
class Gem::Ext::Builder
|
|
|
|
include Gem::UserInteraction
|
|
|
|
##
|
|
# The builder shells-out to run various commands after changing the
|
|
# directory. This means multiple installations cannot be allowed to build
|
|
# extensions in parallel as they may change each other's directories leading
|
|
# to broken extensions or failed installations.
|
|
|
|
CHDIR_MUTEX = Mutex.new # :nodoc:
|
|
|
|
attr_accessor :build_args # :nodoc:
|
|
|
|
def self.class_name
|
|
name =~ /Ext::(.*)Builder/
|
|
$1.downcase
|
|
end
|
|
|
|
def self.make(dest_path, results)
|
|
unless File.exist? 'Makefile'
|
|
raise Gem::InstallError, 'Makefile not found'
|
|
end
|
|
|
|
# try to find make program from Ruby configure arguments first
|
|
RbConfig::CONFIG['configure_args'] =~ /with-make-prog\=(\w+)/
|
|
make_program = ENV['MAKE'] || ENV['make'] || $1
|
|
unless make_program
|
|
make_program = (/mswin/ =~ RUBY_PLATFORM) ? 'nmake' : 'make'
|
|
end
|
|
|
|
destdir = '"DESTDIR=%s"' % ENV['DESTDIR']
|
|
|
|
['clean', '', 'install'].each do |target|
|
|
# Pass DESTDIR via command line to override what's in MAKEFLAGS
|
|
cmd = [
|
|
make_program,
|
|
destdir,
|
|
target
|
|
].join(' ').rstrip
|
|
begin
|
|
run(cmd, results, "make #{target}".rstrip)
|
|
rescue Gem::InstallError
|
|
raise unless target == 'clean' # ignore clean failure
|
|
end
|
|
end
|
|
end
|
|
|
|
def self.run(command, results, command_name = nil)
|
|
verbose = Gem.configuration.really_verbose
|
|
|
|
begin
|
|
rubygems_gemdeps, ENV['RUBYGEMS_GEMDEPS'] = ENV['RUBYGEMS_GEMDEPS'], nil
|
|
if verbose
|
|
puts("current directory: #{Dir.pwd}")
|
|
p(command)
|
|
end
|
|
results << "current directory: #{Dir.pwd}"
|
|
results << (command.respond_to?(:shelljoin) ? command.shelljoin : command)
|
|
|
|
require "open3"
|
|
# Set $SOURCE_DATE_EPOCH for the subprocess.
|
|
env = {'SOURCE_DATE_EPOCH' => Gem.source_date_epoch_string}
|
|
output, status = Open3.capture2e(env, *command)
|
|
if verbose
|
|
puts output
|
|
else
|
|
results << output
|
|
end
|
|
rescue => error
|
|
raise Gem::InstallError, "#{command_name || class_name} failed#{error.message}"
|
|
ensure
|
|
ENV['RUBYGEMS_GEMDEPS'] = rubygems_gemdeps
|
|
end
|
|
|
|
unless status.success?
|
|
results << "Building has failed. See above output for more information on the failure." if verbose
|
|
end
|
|
|
|
yield(status, results) if block_given?
|
|
|
|
unless status.success?
|
|
exit_reason =
|
|
if status.exited?
|
|
", exit code #{status.exitstatus}"
|
|
elsif status.signaled?
|
|
", uncaught signal #{status.termsig}"
|
|
end
|
|
|
|
raise Gem::InstallError, "#{command_name || class_name} failed#{exit_reason}"
|
|
end
|
|
end
|
|
|
|
##
|
|
# Creates a new extension builder for +spec+. If the +spec+ does not yet
|
|
# have build arguments, saved, set +build_args+ which is an ARGV-style
|
|
# array.
|
|
|
|
def initialize(spec, build_args = spec.build_args)
|
|
@spec = spec
|
|
@build_args = build_args
|
|
@gem_dir = spec.full_gem_path
|
|
|
|
@ran_rake = false
|
|
end
|
|
|
|
##
|
|
# Chooses the extension builder class for +extension+
|
|
|
|
def builder_for(extension) # :nodoc:
|
|
case extension
|
|
when /extconf/ then
|
|
Gem::Ext::ExtConfBuilder
|
|
when /configure/ then
|
|
Gem::Ext::ConfigureBuilder
|
|
when /rakefile/i, /mkrf_conf/i then
|
|
@ran_rake = true
|
|
Gem::Ext::RakeBuilder
|
|
when /CMakeLists.txt/ then
|
|
Gem::Ext::CmakeBuilder
|
|
else
|
|
build_error("No builder for extension '#{extension}'")
|
|
end
|
|
end
|
|
|
|
##
|
|
# Logs the build +output+, then raises Gem::Ext::BuildError.
|
|
|
|
def build_error(output, backtrace = nil) # :nodoc:
|
|
gem_make_out = write_gem_make_out output
|
|
|
|
message = <<-EOF
|
|
ERROR: Failed to build gem native extension.
|
|
|
|
#{output}
|
|
|
|
Gem files will remain installed in #{@gem_dir} for inspection.
|
|
Results logged to #{gem_make_out}
|
|
EOF
|
|
|
|
raise Gem::Ext::BuildError, message, backtrace
|
|
end
|
|
|
|
def build_extension(extension, dest_path) # :nodoc:
|
|
results = []
|
|
|
|
builder = builder_for(extension)
|
|
|
|
extension_dir =
|
|
File.expand_path File.join(@gem_dir, File.dirname(extension))
|
|
lib_dir = File.join @spec.full_gem_path, @spec.raw_require_paths.first
|
|
|
|
begin
|
|
FileUtils.mkdir_p dest_path
|
|
|
|
CHDIR_MUTEX.synchronize do
|
|
pwd = Dir.getwd
|
|
Dir.chdir extension_dir
|
|
begin
|
|
results = builder.build(extension, dest_path,
|
|
results, @build_args, lib_dir)
|
|
|
|
verbose { results.join("\n") }
|
|
ensure
|
|
begin
|
|
Dir.chdir pwd
|
|
rescue SystemCallError
|
|
Dir.chdir dest_path
|
|
end
|
|
end
|
|
end
|
|
|
|
write_gem_make_out results.join "\n"
|
|
rescue => e
|
|
results << e.message
|
|
build_error(results.join("\n"), $@)
|
|
end
|
|
end
|
|
|
|
##
|
|
# Builds extensions. Valid types of extensions are extconf.rb files,
|
|
# configure scripts and rakefiles or mkrf_conf files.
|
|
|
|
def build_extensions
|
|
return if @spec.extensions.empty?
|
|
|
|
if @build_args.empty?
|
|
say "Building native extensions. This could take a while..."
|
|
else
|
|
say "Building native extensions with: '#{@build_args.join ' '}'"
|
|
say "This could take a while..."
|
|
end
|
|
|
|
dest_path = @spec.extension_dir
|
|
|
|
FileUtils.rm_f @spec.gem_build_complete_path
|
|
|
|
@spec.extensions.each do |extension|
|
|
break if @ran_rake
|
|
|
|
build_extension extension, dest_path
|
|
end
|
|
|
|
FileUtils.touch @spec.gem_build_complete_path
|
|
end
|
|
|
|
##
|
|
# Writes +output+ to gem_make.out in the extension install directory.
|
|
|
|
def write_gem_make_out(output) # :nodoc:
|
|
destination = File.join @spec.extension_dir, 'gem_make.out'
|
|
|
|
FileUtils.mkdir_p @spec.extension_dir
|
|
|
|
File.open destination, 'wb' do |io|
|
|
io.puts output
|
|
end
|
|
|
|
destination
|
|
end
|
|
|
|
end
|