mirror of
https://github.com/ruby/ruby.git
synced 2022-11-09 12:17:21 -05:00
f934096638
The error had not be caught be specs because `bundle install` was returning a zero exit code when plugin installation errors happened. So I fixed that issue too. https://github.com/rubygems/rubygems/commit/90cde87856
78 lines
2.1 KiB
Ruby
78 lines
2.1 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
RSpec.describe "command plugins" do
|
|
before do
|
|
build_repo2 do
|
|
build_plugin "command-mah" do |s|
|
|
s.write "plugins.rb", <<-RUBY
|
|
module Mah
|
|
class Plugin < Bundler::Plugin::API
|
|
command "mahcommand" # declares the command
|
|
|
|
def exec(command, args)
|
|
puts "MahHello"
|
|
end
|
|
end
|
|
end
|
|
RUBY
|
|
end
|
|
end
|
|
|
|
bundle "plugin install command-mah --source #{file_uri_for(gem_repo2)}"
|
|
end
|
|
|
|
it "executes without arguments" do
|
|
expect(out).to include("Installed plugin command-mah")
|
|
|
|
bundle "mahcommand"
|
|
expect(out).to eq("MahHello")
|
|
end
|
|
|
|
it "accepts the arguments" do
|
|
build_repo2 do
|
|
build_plugin "the-echoer" do |s|
|
|
s.write "plugins.rb", <<-RUBY
|
|
module Resonance
|
|
class Echoer
|
|
# Another method to declare the command
|
|
Bundler::Plugin::API.command "echo", self
|
|
|
|
def exec(command, args)
|
|
puts "You gave me \#{args.join(", ")}"
|
|
end
|
|
end
|
|
end
|
|
RUBY
|
|
end
|
|
end
|
|
|
|
bundle "plugin install the-echoer --source #{file_uri_for(gem_repo2)}"
|
|
expect(out).to include("Installed plugin the-echoer")
|
|
|
|
bundle "echo tacos tofu lasange"
|
|
expect(out).to eq("You gave me tacos, tofu, lasange")
|
|
end
|
|
|
|
it "raises error on redeclaration of command" do
|
|
build_repo2 do
|
|
build_plugin "copycat" do |s|
|
|
s.write "plugins.rb", <<-RUBY
|
|
module CopyCat
|
|
class Cheater < Bundler::Plugin::API
|
|
command "mahcommand", self
|
|
|
|
def exec(command, args)
|
|
end
|
|
end
|
|
end
|
|
RUBY
|
|
end
|
|
end
|
|
|
|
bundle "plugin install copycat --source #{file_uri_for(gem_repo2)}", :raise_on_error => false
|
|
|
|
expect(out).not_to include("Installed plugin copycat")
|
|
|
|
expect(err).to include("Failed to install plugin `copycat`, due to Bundler::Plugin::Index::CommandConflict (Command(s) `mahcommand` declared by copycat are already registered.)")
|
|
end
|
|
end
|