mirror of
https://github.com/ruby/ruby.git
synced 2022-11-09 12:17:21 -05:00
0c6529bac2
This reverts commit 3dc509e645abb497e4dc92a7c42be471ff87db0b. https://github.com/bundler/bundler/commit/b5766564fb
425 lines
11 KiB
Ruby
425 lines
11 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
RSpec.describe "bundle install across platforms" do
|
|
it "maintains the same lockfile if all gems are compatible across platforms" do
|
|
lockfile <<-G
|
|
GEM
|
|
remote: #{file_uri_for(gem_repo1)}/
|
|
specs:
|
|
rack (0.9.1)
|
|
|
|
PLATFORMS
|
|
#{not_local}
|
|
|
|
DEPENDENCIES
|
|
rack
|
|
G
|
|
|
|
install_gemfile <<-G
|
|
source "#{file_uri_for(gem_repo1)}"
|
|
|
|
gem "rack"
|
|
G
|
|
|
|
expect(the_bundle).to include_gems "rack 0.9.1"
|
|
end
|
|
|
|
it "pulls in the correct platform specific gem" do
|
|
lockfile <<-G
|
|
GEM
|
|
remote: #{file_uri_for(gem_repo1)}
|
|
specs:
|
|
platform_specific (1.0)
|
|
platform_specific (1.0-java)
|
|
platform_specific (1.0-x86-mswin32)
|
|
|
|
PLATFORMS
|
|
ruby
|
|
|
|
DEPENDENCIES
|
|
platform_specific
|
|
G
|
|
|
|
simulate_platform "java"
|
|
install_gemfile <<-G
|
|
source "#{file_uri_for(gem_repo1)}"
|
|
|
|
gem "platform_specific"
|
|
G
|
|
|
|
expect(the_bundle).to include_gems "platform_specific 1.0 JAVA"
|
|
end
|
|
|
|
it "works with gems that have different dependencies" do
|
|
simulate_platform "java"
|
|
install_gemfile <<-G
|
|
source "#{file_uri_for(gem_repo1)}"
|
|
|
|
gem "nokogiri"
|
|
G
|
|
|
|
expect(the_bundle).to include_gems "nokogiri 1.4.2 JAVA", "weakling 0.0.3"
|
|
|
|
simulate_new_machine
|
|
|
|
simulate_platform "ruby"
|
|
install_gemfile <<-G
|
|
source "#{file_uri_for(gem_repo1)}"
|
|
|
|
gem "nokogiri"
|
|
G
|
|
|
|
expect(the_bundle).to include_gems "nokogiri 1.4.2"
|
|
expect(the_bundle).not_to include_gems "weakling"
|
|
end
|
|
|
|
it "does not keep unneeded platforms for gems that are used" do
|
|
build_repo4 do
|
|
build_gem "empyrean", "0.1.0"
|
|
build_gem "coderay", "1.1.2"
|
|
build_gem "method_source", "0.9.0"
|
|
build_gem("spoon", "0.0.6") {|s| s.add_runtime_dependency "ffi" }
|
|
build_gem "pry", "0.11.3" do |s|
|
|
s.platform = "java"
|
|
s.add_runtime_dependency "coderay", "~> 1.1.0"
|
|
s.add_runtime_dependency "method_source", "~> 0.9.0"
|
|
s.add_runtime_dependency "spoon", "~> 0.0"
|
|
end
|
|
build_gem "pry", "0.11.3" do |s|
|
|
s.add_runtime_dependency "coderay", "~> 1.1.0"
|
|
s.add_runtime_dependency "method_source", "~> 0.9.0"
|
|
end
|
|
build_gem("ffi", "1.9.23") {|s| s.platform = "java" }
|
|
build_gem("ffi", "1.9.23")
|
|
end
|
|
|
|
simulate_platform java
|
|
|
|
install_gemfile! <<-G
|
|
source "#{file_uri_for(gem_repo4)}"
|
|
|
|
gem "empyrean", "0.1.0"
|
|
gem "pry"
|
|
G
|
|
|
|
lockfile_should_be <<-L
|
|
GEM
|
|
remote: #{file_uri_for(gem_repo4)}/
|
|
specs:
|
|
coderay (1.1.2)
|
|
empyrean (0.1.0)
|
|
ffi (1.9.23-java)
|
|
method_source (0.9.0)
|
|
pry (0.11.3-java)
|
|
coderay (~> 1.1.0)
|
|
method_source (~> 0.9.0)
|
|
spoon (~> 0.0)
|
|
spoon (0.0.6)
|
|
ffi
|
|
|
|
PLATFORMS
|
|
java
|
|
|
|
DEPENDENCIES
|
|
empyrean (= 0.1.0)
|
|
pry
|
|
|
|
BUNDLED WITH
|
|
#{Bundler::VERSION}
|
|
L
|
|
|
|
bundle! "lock --add-platform ruby"
|
|
|
|
good_lockfile = strip_whitespace(<<-L)
|
|
GEM
|
|
remote: #{file_uri_for(gem_repo4)}/
|
|
specs:
|
|
coderay (1.1.2)
|
|
empyrean (0.1.0)
|
|
ffi (1.9.23-java)
|
|
method_source (0.9.0)
|
|
pry (0.11.3)
|
|
coderay (~> 1.1.0)
|
|
method_source (~> 0.9.0)
|
|
pry (0.11.3-java)
|
|
coderay (~> 1.1.0)
|
|
method_source (~> 0.9.0)
|
|
spoon (~> 0.0)
|
|
spoon (0.0.6)
|
|
ffi
|
|
|
|
PLATFORMS
|
|
java
|
|
ruby
|
|
|
|
DEPENDENCIES
|
|
empyrean (= 0.1.0)
|
|
pry
|
|
|
|
BUNDLED WITH
|
|
#{Bundler::VERSION}
|
|
L
|
|
|
|
lockfile_should_be good_lockfile
|
|
|
|
bad_lockfile = strip_whitespace <<-L
|
|
GEM
|
|
remote: #{file_uri_for(gem_repo4)}/
|
|
specs:
|
|
coderay (1.1.2)
|
|
empyrean (0.1.0)
|
|
ffi (1.9.23)
|
|
ffi (1.9.23-java)
|
|
method_source (0.9.0)
|
|
pry (0.11.3)
|
|
coderay (~> 1.1.0)
|
|
method_source (~> 0.9.0)
|
|
pry (0.11.3-java)
|
|
coderay (~> 1.1.0)
|
|
method_source (~> 0.9.0)
|
|
spoon (~> 0.0)
|
|
spoon (0.0.6)
|
|
ffi
|
|
|
|
PLATFORMS
|
|
java
|
|
ruby
|
|
|
|
DEPENDENCIES
|
|
empyrean (= 0.1.0)
|
|
pry
|
|
|
|
BUNDLED WITH
|
|
#{Bundler::VERSION}
|
|
L
|
|
|
|
aggregate_failures do
|
|
lockfile bad_lockfile
|
|
bundle! :install
|
|
lockfile_should_be good_lockfile
|
|
|
|
lockfile bad_lockfile
|
|
bundle! :update, :all => true
|
|
lockfile_should_be good_lockfile
|
|
|
|
lockfile bad_lockfile
|
|
bundle! "update ffi"
|
|
lockfile_should_be good_lockfile
|
|
|
|
lockfile bad_lockfile
|
|
bundle! "update empyrean"
|
|
lockfile_should_be good_lockfile
|
|
|
|
lockfile bad_lockfile
|
|
bundle! :lock
|
|
lockfile_should_be good_lockfile
|
|
end
|
|
end
|
|
|
|
it "works the other way with gems that have different dependencies" do
|
|
simulate_platform "ruby"
|
|
install_gemfile <<-G
|
|
source "#{file_uri_for(gem_repo1)}"
|
|
|
|
gem "nokogiri"
|
|
G
|
|
|
|
simulate_platform "java"
|
|
bundle "install"
|
|
|
|
expect(the_bundle).to include_gems "nokogiri 1.4.2 JAVA", "weakling 0.0.3"
|
|
end
|
|
|
|
it "works with gems that have extra platform-specific runtime dependencies", :bundler => "< 3" do
|
|
simulate_platform x64_mac
|
|
|
|
update_repo2 do
|
|
build_gem "facter", "2.4.6"
|
|
build_gem "facter", "2.4.6" do |s|
|
|
s.platform = "universal-darwin"
|
|
s.add_runtime_dependency "CFPropertyList"
|
|
end
|
|
build_gem "CFPropertyList"
|
|
end
|
|
|
|
install_gemfile! <<-G
|
|
source "#{file_uri_for(gem_repo2)}"
|
|
|
|
gem "facter"
|
|
G
|
|
|
|
expect(err).to include "Unable to use the platform-specific (universal-darwin) version of facter (2.4.6) " \
|
|
"because it has different dependencies from the ruby version. " \
|
|
"To use the platform-specific version of the gem, run `bundle config set specific_platform true` and install again."
|
|
|
|
expect(the_bundle).to include_gem "facter 2.4.6"
|
|
expect(the_bundle).not_to include_gem "CFPropertyList"
|
|
end
|
|
|
|
it "fetches gems again after changing the version of Ruby" do
|
|
gemfile <<-G
|
|
source "#{file_uri_for(gem_repo1)}"
|
|
|
|
gem "rack", "1.0.0"
|
|
G
|
|
|
|
bundle! :install, forgotten_command_line_options(:path => "vendor/bundle")
|
|
|
|
FileUtils.mv(vendored_gems, bundled_app("vendor/bundle", Gem.ruby_engine, "1.8"))
|
|
|
|
bundle! :install
|
|
expect(vendored_gems("gems/rack-1.0.0")).to exist
|
|
end
|
|
end
|
|
|
|
RSpec.describe "bundle install with platform conditionals" do
|
|
it "installs gems tagged w/ the current platforms" do
|
|
install_gemfile <<-G
|
|
source "#{file_uri_for(gem_repo1)}"
|
|
|
|
platforms :#{local_tag} do
|
|
gem "nokogiri"
|
|
end
|
|
G
|
|
|
|
expect(the_bundle).to include_gems "nokogiri 1.4.2"
|
|
end
|
|
|
|
it "does not install gems tagged w/ another platforms" do
|
|
install_gemfile <<-G
|
|
source "#{file_uri_for(gem_repo1)}"
|
|
gem "rack"
|
|
platforms :#{not_local_tag} do
|
|
gem "nokogiri"
|
|
end
|
|
G
|
|
|
|
expect(the_bundle).to include_gems "rack 1.0"
|
|
expect(the_bundle).not_to include_gems "nokogiri 1.4.2"
|
|
end
|
|
|
|
it "installs gems tagged w/ the current platforms inline" do
|
|
install_gemfile <<-G
|
|
source "#{file_uri_for(gem_repo1)}"
|
|
gem "nokogiri", :platforms => :#{local_tag}
|
|
G
|
|
expect(the_bundle).to include_gems "nokogiri 1.4.2"
|
|
end
|
|
|
|
it "does not install gems tagged w/ another platforms inline" do
|
|
install_gemfile <<-G
|
|
source "#{file_uri_for(gem_repo1)}"
|
|
gem "rack"
|
|
gem "nokogiri", :platforms => :#{not_local_tag}
|
|
G
|
|
expect(the_bundle).to include_gems "rack 1.0"
|
|
expect(the_bundle).not_to include_gems "nokogiri 1.4.2"
|
|
end
|
|
|
|
it "installs gems tagged w/ the current platform inline" do
|
|
install_gemfile <<-G
|
|
source "#{file_uri_for(gem_repo1)}"
|
|
gem "nokogiri", :platform => :#{local_tag}
|
|
G
|
|
expect(the_bundle).to include_gems "nokogiri 1.4.2"
|
|
end
|
|
|
|
it "doesn't install gems tagged w/ another platform inline" do
|
|
install_gemfile <<-G
|
|
source "#{file_uri_for(gem_repo1)}"
|
|
gem "nokogiri", :platform => :#{not_local_tag}
|
|
G
|
|
expect(the_bundle).not_to include_gems "nokogiri 1.4.2"
|
|
end
|
|
|
|
it "does not blow up on sources with all platform-excluded specs" do
|
|
build_git "foo"
|
|
|
|
install_gemfile <<-G
|
|
platform :#{not_local_tag} do
|
|
gem "foo", :git => "#{lib_path("foo-1.0")}"
|
|
end
|
|
G
|
|
|
|
bundle :list
|
|
expect(exitstatus).to eq(0) if exitstatus
|
|
end
|
|
|
|
it "does not attempt to install gems from :rbx when using --local" do
|
|
simulate_platform "ruby"
|
|
simulate_ruby_engine "ruby"
|
|
|
|
gemfile <<-G
|
|
source "#{file_uri_for(gem_repo1)}"
|
|
gem "some_gem", :platform => :rbx
|
|
G
|
|
|
|
bundle "install --local"
|
|
expect(out).not_to match(/Could not find gem 'some_gem/)
|
|
end
|
|
|
|
it "does not attempt to install gems from other rubies when using --local" do
|
|
simulate_platform "ruby"
|
|
simulate_ruby_engine "ruby"
|
|
other_ruby_version_tag = RUBY_VERSION =~ /^1\.8/ ? :ruby_19 : :ruby_18
|
|
|
|
gemfile <<-G
|
|
source "#{file_uri_for(gem_repo1)}"
|
|
gem "some_gem", platform: :#{other_ruby_version_tag}
|
|
G
|
|
|
|
bundle "install --local"
|
|
expect(out).not_to match(/Could not find gem 'some_gem/)
|
|
end
|
|
|
|
it "prints a helpful warning when a dependency is unused on any platform" do
|
|
simulate_platform "ruby"
|
|
simulate_ruby_engine "ruby"
|
|
|
|
gemfile <<-G
|
|
source "#{file_uri_for(gem_repo1)}"
|
|
|
|
gem "rack", :platform => [:mingw, :mswin, :x64_mingw, :jruby]
|
|
G
|
|
|
|
bundle! "install"
|
|
|
|
expect(err).to include <<-O.strip
|
|
The dependency #{Gem::Dependency.new("rack", ">= 0")} will be unused by any of the platforms Bundler is installing for. Bundler is installing for ruby but the dependency is only for x86-mingw32, x86-mswin32, x64-mingw32, java. To add those platforms to the bundle, run `bundle lock --add-platform x86-mingw32 x86-mswin32 x64-mingw32 java`.
|
|
O
|
|
end
|
|
|
|
context "when disable_platform_warnings is true" do
|
|
before { bundle! "config set disable_platform_warnings true" }
|
|
|
|
it "does not print the warning when a dependency is unused on any platform" do
|
|
simulate_platform "ruby"
|
|
simulate_ruby_engine "ruby"
|
|
|
|
gemfile <<-G
|
|
source "#{file_uri_for(gem_repo1)}"
|
|
|
|
gem "rack", :platform => [:mingw, :mswin, :x64_mingw, :jruby]
|
|
G
|
|
|
|
bundle! "install"
|
|
|
|
expect(out).not_to match(/The dependency (.*) will be unused/)
|
|
end
|
|
end
|
|
end
|
|
|
|
RSpec.describe "when a gem has no architecture" do
|
|
it "still installs correctly" do
|
|
simulate_platform mswin
|
|
|
|
gemfile <<-G
|
|
# Try to install gem with nil arch
|
|
source "http://localgemserver.test/"
|
|
gem "rcov"
|
|
G
|
|
|
|
bundle :install, :artifice => "windows"
|
|
expect(the_bundle).to include_gems "rcov 1.0.0"
|
|
end
|
|
end
|