mirror of
https://github.com/ruby/ruby.git
synced 2022-11-09 12:17:21 -05:00
65651b34b1
This avoids O(n) on lookups with structs over 10 members.
This also avoids O(n) behavior on all assignments on Struct members.
Members 0..9 still use existing C methods to read in O(1) time
Benchmark results:
vm2_struct_big_aref_hi* 1.305
vm2_struct_big_aref_lo* 1.157
vm2_struct_big_aset* 3.306
vm2_struct_small_aref* 1.015
vm2_struct_small_aset* 3.273
Note: I chose use loading instructions from an array instead of writing
directly to linked-lists in compile.c for ease-of-maintainability. We
may move the method definitions to prelude.rb-like files in the future.
I have also tested this patch with the following patch to disable
the C ref_func methods and ensured the test suite and rubyspec works
--- a/struct.c
+++ b/struct.c
@@ -209,7 +209,7 @@ setup_struct(VALUE nstr, VALUE members)
ID id = SYM2ID(ptr_members[i]);
VALUE off = LONG2NUM(i);
- if (i < N_REF_FUNC) {
+ if (0 && i < N_REF_FUNC) {
rb_define_method_id(nstr, id, ref_func[i], 0);
}
else {
* iseq.c (rb_method_for_self_aref, rb_method_for_self_aset):
new methods to generate bytecode for struct.c
[Feature #10575]
* struct.c (rb_struct_ref, rb_struct_set): remove
(define_aref_method, define_aset_method): new functions
(setup_struct): use new functions
* test/ruby/test_struct.rb: add test for struct >10 members
* benchmark/bm_vm2_struct_big_aref_hi.rb: new benchmark
* benchmark/bm_vm2_struct_big_aref_lo.rb: ditto
* benchmark/bm_vm2_struct_big_aset.rb: ditto
* benchmark/bm_vm2_struct_small_aref.rb: ditto
* benchmark/bm_vm2_struct_small_aset.rb: ditto
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@48748 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
|
||
|---|---|---|
| .. | ||
| enc | ||
| allpairs.rb | ||
| beginmainend.rb | ||
| endblockwarn_rb | ||
| lbtest.rb | ||
| marshaltestlib.rb | ||
| sentence.rb | ||
| test_alias.rb | ||
| test_argf.rb | ||
| test_arity.rb | ||
| test_array.rb | ||
| test_assignment.rb | ||
| test_autoload.rb | ||
| test_backtrace.rb | ||
| test_basicinstructions.rb | ||
| test_beginendblock.rb | ||
| test_bignum.rb | ||
| test_call.rb | ||
| test_case.rb | ||
| test_class.rb | ||
| test_clone.rb | ||
| test_comparable.rb | ||
| test_complex.rb | ||
| test_complex2.rb | ||
| test_complexrational.rb | ||
| test_condition.rb | ||
| test_const.rb | ||
| test_continuation.rb | ||
| test_defined.rb | ||
| test_dir.rb | ||
| test_dir_m17n.rb | ||
| test_econv.rb | ||
| test_encoding.rb | ||
| test_enum.rb | ||
| test_enumerator.rb | ||
| test_env.rb | ||
| test_eval.rb | ||
| test_exception.rb | ||
| test_fiber.rb | ||
| test_file.rb | ||
| test_file_exhaustive.rb | ||
| test_fixnum.rb | ||
| test_flip.rb | ||
| test_float.rb | ||
| test_fnmatch.rb | ||
| test_gc.rb | ||
| test_hash.rb | ||
| test_ifunless.rb | ||
| test_integer.rb | ||
| test_integer_comb.rb | ||
| test_io.rb | ||
| test_io_m17n.rb | ||
| test_iseq.rb | ||
| test_iterator.rb | ||
| test_keyword.rb | ||
| test_lambda.rb | ||
| test_lazy_enumerator.rb | ||
| test_literal.rb | ||
| test_m17n.rb | ||
| test_m17n_comb.rb | ||
| test_marshal.rb | ||
| test_math.rb | ||
| test_metaclass.rb | ||
| test_method.rb | ||
| test_mixed_unicode_escapes.rb | ||
| test_module.rb | ||
| test_not.rb | ||
| test_notimp.rb | ||
| test_numeric.rb | ||
| test_object.rb | ||
| test_objectspace.rb | ||
| test_optimization.rb | ||
| test_pack.rb | ||
| test_parse.rb | ||
| test_path.rb | ||
| test_pipe.rb | ||
| test_primitive.rb | ||
| test_proc.rb | ||
| test_process.rb | ||
| test_rand.rb | ||
| test_range.rb | ||
| test_rational.rb | ||
| test_rational2.rb | ||
| test_readpartial.rb | ||
| test_refinement.rb | ||
| test_regexp.rb | ||
| test_require.rb | ||
| test_rubyoptions.rb | ||
| test_rubyvm.rb | ||
| test_settracefunc.rb | ||
| test_signal.rb | ||
| test_sleep.rb | ||
| test_sprintf.rb | ||
| test_sprintf_comb.rb | ||
| test_string.rb | ||
| test_stringchar.rb | ||
| test_struct.rb | ||
| test_super.rb | ||
| test_symbol.rb | ||
| test_syntax.rb | ||
| test_system.rb | ||
| test_thread.rb | ||
| test_threadgroup.rb | ||
| test_time.rb | ||
| test_time_tz.rb | ||
| test_trace.rb | ||
| test_transcode.rb | ||
| test_undef.rb | ||
| test_unicode_escape.rb | ||
| test_variable.rb | ||
| test_weakmap.rb | ||
| test_whileuntil.rb | ||
| test_yield.rb | ||
| ut_eof.rb | ||