mirror of
https://github.com/ruby/ruby.git
synced 2022-11-09 12:17:21 -05:00
c70dc3cafb
GitHub: fix GH-225
With Ruby 3.0.2 and csv 3.2.1, the file
```ruby
require "csv"
File.open("example.tsv", "w") { |f| f.puts("foo\t\tbar") }
CSV.read("example.tsv", col_sep: "\t", strip: true)
```
produces the error
```
lib/csv/parser.rb:935:in `parse_quotable_robust': TODO: Meaningful
message in line 1. (CSV::MalformedCSVError)
```
However, the CSV in this example is not malformed; instead, ambiguous
options were provided to the parser. It is not obvious (to me) whether
the string should be parsed as
- `["foo\t\tbar"]`,
- `["foo", "bar"]`,
- `["foo", "", "bar"]`, or
- `["foo", nil, "bar"]`.
This commit adds code that raises an exception when this situation is
encountered. Specifically, it checks if the column separator either ends
with or starts with the characters that would be stripped away.
This commit also adds unit tests and updates the documentation.
https://github.com/ruby/csv/commit/cc317dd42d
|
||
|---|---|---|
| .. | ||
| -ext- | ||
| base64 | ||
| benchmark | ||
| bigdecimal | ||
| cgi | ||
| coverage | ||
| csv | ||
| date | ||
| did_you_mean | ||
| digest | ||
| drb | ||
| dtrace | ||
| erb | ||
| error_highlight | ||
| etc | ||
| excludes | ||
| fiber | ||
| fiddle | ||
| fileutils | ||
| fixtures/fake_sorted_set_gem | ||
| io | ||
| irb | ||
| json | ||
| lib | ||
| logger | ||
| mkmf | ||
| monitor | ||
| net | ||
| nkf | ||
| objspace | ||
| open-uri | ||
| openssl | ||
| optparse | ||
| ostruct | ||
| pathname | ||
| psych | ||
| racc | ||
| rdoc | ||
| readline | ||
| reline | ||
| resolv | ||
| rinda | ||
| ripper | ||
| ruby | ||
| rubygems | ||
| socket | ||
| stringio | ||
| strscan | ||
| syslog | ||
| uri | ||
| win32ole | ||
| yaml | ||
| zlib | ||
| runner.rb | ||
| test_abbrev.rb | ||
| test_delegate.rb | ||
| test_extlibs.rb | ||
| test_find.rb | ||
| test_forwardable.rb | ||
| test_getoptlong.rb | ||
| test_ipaddr.rb | ||
| test_mutex_m.rb | ||
| test_observer.rb | ||
| test_open3.rb | ||
| test_pp.rb | ||
| test_prettyprint.rb | ||
| test_pstore.rb | ||
| test_pty.rb | ||
| test_rbconfig.rb | ||
| test_securerandom.rb | ||
| test_set.rb | ||
| test_shellwords.rb | ||
| test_singleton.rb | ||
| test_sorted_set.rb | ||
| test_syslog.rb | ||
| test_tempfile.rb | ||
| test_time.rb | ||
| test_timeout.rb | ||
| test_tmpdir.rb | ||
| test_trick.rb | ||
| test_tsort.rb | ||
| test_unicode_normalize.rb | ||
| test_weakref.rb | ||