mirror of
https://github.com/ruby/ruby.git
synced 2022-11-09 12:17:21 -05:00
03903f23c2
Since we're at it. This generates a bunch of warnings and seems like a brittle way to test things, so let's get rid of it. https://github.com/rubygems/rubygems/commit/f5d45520e0
123 lines
3.1 KiB
Ruby
123 lines
3.1 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
RSpec.describe "ruby requirement" do
|
|
def locked_ruby_version
|
|
Bundler::RubyVersion.from_string(Bundler::LockfileParser.new(File.read(bundled_app_lock)).ruby_version)
|
|
end
|
|
|
|
# As discovered by https://github.com/rubygems/bundler/issues/4147, there is
|
|
# no test coverage to ensure that adding a gem is possible with a ruby
|
|
# requirement. This test verifies the fix, committed in bfbad5c5.
|
|
it "allows adding gems" do
|
|
install_gemfile <<-G
|
|
source "#{file_uri_for(gem_repo1)}"
|
|
ruby "#{RUBY_VERSION}"
|
|
gem "rack"
|
|
G
|
|
|
|
install_gemfile <<-G
|
|
source "#{file_uri_for(gem_repo1)}"
|
|
ruby "#{RUBY_VERSION}"
|
|
gem "rack"
|
|
gem "rack-obama"
|
|
G
|
|
|
|
expect(the_bundle).to include_gems "rack-obama 1.0"
|
|
end
|
|
|
|
it "allows removing the ruby version requirement" do
|
|
install_gemfile <<-G
|
|
source "#{file_uri_for(gem_repo1)}"
|
|
ruby "~> #{RUBY_VERSION}"
|
|
gem "rack"
|
|
G
|
|
|
|
expect(lockfile).to include("RUBY VERSION")
|
|
|
|
install_gemfile <<-G
|
|
source "#{file_uri_for(gem_repo1)}"
|
|
gem "rack"
|
|
G
|
|
|
|
expect(the_bundle).to include_gems "rack 1.0.0"
|
|
expect(lockfile).not_to include("RUBY VERSION")
|
|
end
|
|
|
|
it "allows changing the ruby version requirement to something compatible" do
|
|
install_gemfile <<-G
|
|
source "#{file_uri_for(gem_repo1)}"
|
|
ruby ">= #{RUBY_VERSION[0..2]}.0"
|
|
gem "rack"
|
|
G
|
|
|
|
allow(Bundler::SharedHelpers).to receive(:find_gemfile).and_return(bundled_app_gemfile)
|
|
expect(locked_ruby_version).to eq(Bundler::RubyVersion.system)
|
|
|
|
install_gemfile <<-G
|
|
source "#{file_uri_for(gem_repo1)}"
|
|
ruby ">= #{RUBY_VERSION}"
|
|
gem "rack"
|
|
G
|
|
|
|
expect(the_bundle).to include_gems "rack 1.0.0"
|
|
expect(locked_ruby_version).to eq(Bundler::RubyVersion.system)
|
|
end
|
|
|
|
it "allows changing the ruby version requirement to something incompatible" do
|
|
install_gemfile <<-G
|
|
source "#{file_uri_for(gem_repo1)}"
|
|
ruby ">= 1.0.0"
|
|
gem "rack"
|
|
G
|
|
|
|
lockfile <<~L
|
|
GEM
|
|
remote: #{file_uri_for(gem_repo1)}/
|
|
specs:
|
|
rack (1.0.0)
|
|
|
|
PLATFORMS
|
|
#{lockfile_platforms}
|
|
|
|
DEPENDENCIES
|
|
rack
|
|
|
|
RUBY VERSION
|
|
ruby 2.1.4p422
|
|
|
|
BUNDLED WITH
|
|
#{Bundler::VERSION}
|
|
L
|
|
|
|
allow(Bundler::SharedHelpers).to receive(:find_gemfile).and_return(bundled_app_gemfile)
|
|
|
|
install_gemfile <<-G
|
|
source "#{file_uri_for(gem_repo1)}"
|
|
ruby ">= #{RUBY_VERSION[0..2]}.0"
|
|
gem "rack"
|
|
G
|
|
|
|
expect(the_bundle).to include_gems "rack 1.0.0"
|
|
expect(locked_ruby_version).to eq(Bundler::RubyVersion.system)
|
|
end
|
|
|
|
it "allows requirements with trailing whitespace" do
|
|
install_gemfile <<-G
|
|
source "#{file_uri_for(gem_repo1)}"
|
|
ruby "#{RUBY_VERSION}\\n \t\\n"
|
|
gem "rack"
|
|
G
|
|
|
|
expect(the_bundle).to include_gems "rack 1.0.0"
|
|
end
|
|
|
|
it "fails gracefully with malformed requirements" do
|
|
install_gemfile <<-G, :raise_on_error => false
|
|
source "#{file_uri_for(gem_repo1)}"
|
|
ruby ">= 0", "-.\\0"
|
|
gem "rack"
|
|
G
|
|
|
|
expect(err).to include("There was an error parsing") # i.e. DSL error, not error template
|
|
end
|
|
end
|