mirror of
https://github.com/ruby/ruby.git
synced 2022-11-09 12:17:21 -05:00
75ecbda438
Previously, each of these methods returned self, but it is more useful to return arguments, to allow for simpler method decorators, such as: ```ruby cached private def foo; some_long_calculation; end ``` Where cached sets up caching for the method. For each of these methods, the following behavior is used: 1) No arguments returns nil 2) Single argument is returned 3) Multiple arguments are returned as an array The single argument case is really the case we are trying to optimize for, for the same reason that def was changed to return a symbol for the method. Idea and initial patch from Herwin Quarantainenet. Implements [Feature #12495]
57 lines
1.8 KiB
Ruby
57 lines
1.8 KiB
Ruby
require_relative '../../spec_helper'
|
|
require_relative 'fixtures/classes'
|
|
require_relative 'shared/set_visibility'
|
|
|
|
describe "Module#public" do
|
|
it_behaves_like :set_visibility, :public
|
|
|
|
it "on a superclass method calls the redefined method" do
|
|
ModuleSpecs::ChildPrivateMethodMadePublic.new.private_method_redefined.should == :after_redefinition
|
|
end
|
|
|
|
it "makes a private Object instance method public in a new module" do
|
|
m = Module.new do
|
|
public :module_specs_private_method_on_object
|
|
end
|
|
|
|
m.should have_public_instance_method(:module_specs_private_method_on_object)
|
|
|
|
# Ensure we did not change Object's method
|
|
Object.should_not have_public_instance_method(:module_specs_private_method_on_object)
|
|
end
|
|
|
|
it "makes a private Object instance method public in Kernel" do
|
|
Kernel.should have_public_instance_method(
|
|
:module_specs_private_method_on_object_for_kernel_public)
|
|
Object.should_not have_public_instance_method(
|
|
:module_specs_private_method_on_object_for_kernel_public)
|
|
end
|
|
|
|
ruby_version_is ""..."3.1" do
|
|
it "returns self" do
|
|
(class << Object.new; self; end).class_eval do
|
|
def foo; end
|
|
public(:foo).should equal(self)
|
|
public.should equal(self)
|
|
end
|
|
end
|
|
end
|
|
|
|
ruby_version_is "3.1" do
|
|
it "returns argument or arguments if given" do
|
|
(class << Object.new; self; end).class_eval do
|
|
def foo; end
|
|
public(:foo).should equal(:foo)
|
|
public([:foo, :foo]).should == [:foo, :foo]
|
|
public(:foo, :foo).should == [:foo, :foo]
|
|
public.should equal(nil)
|
|
end
|
|
end
|
|
end
|
|
|
|
it "raises a NameError when given an undefined name" do
|
|
-> do
|
|
Module.new.send(:public, :undefined)
|
|
end.should raise_error(NameError)
|
|
end
|
|
end
|