mirror of
https://github.com/ruby/ruby.git
synced 2022-11-09 12:17:21 -05:00
![Yusuke Endoh](/assets/img/avatar_default.png)
This changes "test/rubygems/test_case.rb" to "test/rubygems/helper.rb",
and "test/rubygems/test_utilities.rb" to "test/rubygems/utilities.rb".
The two files are a helper for tests, not test files. However, a file
starting with "test_" prefix is handled as a test file directly loaded
by test-unit because Rakefile specifies:
```
t.test_files = FileList['test/**/test_*.rb']
```
Directly loading test/rubygems/test_utilities.rb caused "uninitialized
constant Gem::TestCase". This issue was fixed by
59c6820971
, but the fix caused a
"circular require" warning because test_utilities.rb and test_case.rb
are now requiring each other.
Anyway, adding "test_" prefix to a test helper file is confusing, so
this changeset reverts the fix and solve the issue by renaming them.
https://github.com/rubygems/rubygems/commit/6460e018df
26 lines
592 B
Ruby
26 lines
592 B
Ruby
# frozen_string_literal: true
|
|
require_relative 'helper'
|
|
|
|
class TestGemSourceFetchProblem < Gem::TestCase
|
|
def test_exception
|
|
source = Gem::Source.new @gem_repo
|
|
error = RuntimeError.new 'test'
|
|
|
|
sf = Gem::SourceFetchProblem.new source, error
|
|
|
|
e = assert_raise RuntimeError do
|
|
raise sf
|
|
end
|
|
|
|
assert_equal 'test', e.message
|
|
end
|
|
|
|
def test_password_redacted
|
|
source = Gem::Source.new 'https://username:secret@gemsource.com'
|
|
error = RuntimeError.new 'test'
|
|
|
|
sf = Gem::SourceFetchProblem.new source, error
|
|
|
|
refute_match sf.wordy, 'secret'
|
|
end
|
|
end
|