1
0
Fork 0
mirror of https://github.com/ruby/ruby.git synced 2022-11-09 12:17:21 -05:00
ruby--ruby/ext/socket
normal aaf2d070a8 accept_nonblock supports "exception: false"
This is analogous to functionality found in IO#read_nonblock and
IO#wait_nonblock.  Raising exceptions for common failures on
non-blocking servers is expensive and makes $DEBUG too noisy.

Benchmark results:
                                    user     system      total        real
default                         2.790000   0.870000   3.660000 (  3.671597)
exception: false                1.120000   0.800000   1.920000 (  1.922032)
exception: false (cached arg)   0.820000   0.770000   1.590000 (  1.589267)
--------------------- benchmark script ------------------------
require 'socket'
require 'benchmark'
require 'tmpdir'
nr = 1000000
Dir.mktmpdir('nb_bench') do |path|
  sock_path = "#{path}/test.sock"
  s = UNIXServer.new(sock_path)
  Benchmark.bmbm do |x|
    x.report("default") do
      nr.times do
        begin
          s.accept_nonblock
        rescue IO::WaitReadable
        end
      end
    end
    x.report("exception: false") do
      nr.times do
        begin
          s.accept_nonblock(exception: false)
        rescue IO::WaitReadable
          abort "should not raise"
        end
      end
    end
    x.report("exception: false (cached arg)") do
      arg = { exception: false }
      nr.times do
        begin
          s.accept_nonblock(arg)
        rescue IO::WaitReadable
          abort "should not raise"
        end
      end
    end
  end
end

* ext/socket/init.c (rsock_s_accept_nonblock):
  support exception: false
  [ruby-core:66385] [Feature #10532]
* ext/socket/init.c (rsock_init_socket_init): define new symbols
* ext/socket/rubysocket.h: adjust prototype
* ext/socket/socket.c (sock_accept_nonblock): support exception: false
* ext/openssl/ossl_ssl.c (ossl_ssl_accept_nonblock): ditto
* ext/socket/socket.c (Init_socket): adjust accept_nonblock definition
* ext/openssl/ossl_ssl.c (Init_ossl_ssl): ditto
* ext/socket/tcpserver.c (rsock_init_tcpserver): ditto
* ext/socket/unixserver.c (rsock_init_unixserver): ditto
* ext/socket/tcpserver.c (tcp_accept_nonblock): adjust
  rsock_s_accept_nonblock call
* ext/socket/unixserver.c (unix_accept_nonblock): ditto
* ext/openssl/ossl_ssl.c (ossl_start_ssl): support no_exception
* ext/openssl/ossl_ssl.c (ossl_ssl_connect): adjust ossl_start_ssl call
* ext/openssl/ossl_ssl.c (ossl_ssl_connect_nonblock): ditto
* ext/openssl/ossl_ssl.c (ossl_ssl_accept): ditto
* test/socket/test_nonblock.rb (test_accept_nonblock): test for
  "exception :false"
* test/socket/test_tcp.rb (test_accept_nonblock): new test
* test/socket/test_unix.rb (test_accept_nonblock): ditto
* test/openssl/test_pair.rb (test_accept_nonblock_no_exception): ditto

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@49948 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2015-03-12 03:03:04 +00:00
..
lib * ext/socket/lib/socket.rb: Don't test $! in "ensure" clause because 2013-12-13 16:11:12 +00:00
.document * ext/socket/.document: Add ifaddr.c. 2013-05-14 14:48:00 +00:00
addrinfo.h * ext/**/*.[ch]: removed trailing spaces. 2010-04-22 08:04:13 +00:00
ancdata.c ext/socket/*.c: trivial struct packing for 64-bit 2014-09-22 00:46:25 +00:00
basicsocket.c * ext/socket/basicsocket.c, ext/socket/sockssocket.c: 2014-12-07 10:40:27 +00:00
constants.c constants.c: fix macro name 2013-04-08 15:28:43 +00:00
depend Update dependencies. 2014-12-19 13:34:54 +00:00
extconf.rb socket/extconf.rb: reduce duplicated code 2015-02-08 01:35:18 +00:00
getaddrinfo.c getaddrinfo.c: GHOST vulnerability check 2015-02-08 04:04:32 +00:00
getnameinfo.c {getaddrinfo,getnameinfo}.c: fix for old platforms 2013-05-03 04:35:37 +00:00
ifaddr.c * ext/socket/ifaddr.c (ifaddr_inspect_flags): support IFF_SIMPLEX. 2014-05-27 12:29:19 +00:00
init.c accept_nonblock supports "exception: false" 2015-03-12 03:03:04 +00:00
ipsocket.c * ext/socket: Wrap struct addrinfo by struct rb_addrinfo. 2014-02-19 09:38:24 +00:00
mkconstants.rb * ext/socket/mkconstants.rb: More constants 2014-05-23 20:54:40 +00:00
option.c socket/option.c: fix inet_ntop link error on mswin 2014-12-05 08:09:12 +00:00
raddrinfo.c getaddrinfo.c: GHOST vulnerability check 2015-02-08 04:04:32 +00:00
rubysocket.h accept_nonblock supports "exception: false" 2015-03-12 03:03:04 +00:00
socket.c accept_nonblock supports "exception: false" 2015-03-12 03:03:04 +00:00
sockport.h * ext/socket: Bypass getaddrinfo() if node and serv are numeric. 2014-02-19 10:37:43 +00:00
sockssocket.c * ext/socket/basicsocket.c, ext/socket/sockssocket.c: 2014-12-07 10:40:27 +00:00
tcpserver.c accept_nonblock supports "exception: false" 2015-03-12 03:03:04 +00:00
tcpsocket.c socket: ai_addrlen is socklen_t 2013-02-15 07:54:38 +00:00
udpsocket.c * ext/socket: Wrap struct addrinfo by struct rb_addrinfo. 2014-02-19 09:38:24 +00:00
unixserver.c accept_nonblock supports "exception: false" 2015-03-12 03:03:04 +00:00
unixsocket.c * ext/socket/unixsocket.c: [DOC] Fix example to render in HTML 2014-10-11 00:33:08 +00:00