mirror of
https://github.com/ruby/ruby.git
synced 2022-11-09 12:17:21 -05:00
b957c3dbcb
This changes "test/rubygems/test_case.rb" to "test/rubygems/helper.rb",
and "test/rubygems/test_utilities.rb" to "test/rubygems/utilities.rb".
The two files are a helper for tests, not test files. However, a file
starting with "test_" prefix is handled as a test file directly loaded
by test-unit because Rakefile specifies:
```
t.test_files = FileList['test/**/test_*.rb']
```
Directly loading test/rubygems/test_utilities.rb caused "uninitialized
constant Gem::TestCase". This issue was fixed by
59c6820971, but the fix caused a
"circular require" warning because test_utilities.rb and test_case.rb
are now requiring each other.
Anyway, adding "test_" prefix to a test helper file is confusing, so
this changeset reverts the fix and solve the issue by renaming them.
https://github.com/rubygems/rubygems/commit/6460e018df
84 lines
1.9 KiB
Ruby
84 lines
1.9 KiB
Ruby
# frozen_string_literal: true
|
|
require_relative 'helper'
|
|
require 'rubygems/commands/which_command'
|
|
|
|
class TestGemCommandsWhichCommand < Gem::TestCase
|
|
def setup
|
|
super
|
|
Gem::Specification.reset
|
|
@cmd = Gem::Commands::WhichCommand.new
|
|
end
|
|
|
|
def test_execute
|
|
util_foo_bar
|
|
|
|
@cmd.handle_options %w[foo_bar]
|
|
|
|
use_ui @ui do
|
|
@cmd.execute
|
|
end
|
|
|
|
assert_equal "#{@foo_bar.full_gem_path}/lib/foo_bar.rb\n", @ui.output
|
|
assert_equal '', @ui.error
|
|
end
|
|
|
|
def test_execute_directory
|
|
@cmd.handle_options %w[directory]
|
|
|
|
use_ui @ui do
|
|
assert_raise Gem::MockGemUi::TermError do
|
|
@cmd.execute
|
|
end
|
|
end
|
|
|
|
assert_equal '', @ui.output
|
|
assert_match %r{Can.t find Ruby library file or shared library directory\n},
|
|
@ui.error
|
|
end
|
|
|
|
def test_execute_one_missing
|
|
# TODO: this test fails in isolation
|
|
|
|
util_foo_bar
|
|
|
|
@cmd.handle_options %w[foo_bar missinglib]
|
|
|
|
use_ui @ui do
|
|
assert_raise Gem::MockGemUi::TermError do
|
|
@cmd.execute
|
|
end
|
|
end
|
|
|
|
assert_equal "#{@foo_bar.full_gem_path}/lib/foo_bar.rb\n", @ui.output
|
|
assert_match %r{Can.t find Ruby library file or shared library missinglib\n},
|
|
@ui.error
|
|
end
|
|
|
|
def test_execute_missing
|
|
@cmd.handle_options %w[missinglib]
|
|
|
|
use_ui @ui do
|
|
assert_raise Gem::MockGemUi::TermError do
|
|
@cmd.execute
|
|
end
|
|
end
|
|
|
|
assert_equal '', @ui.output
|
|
assert_match %r{Can.t find Ruby library file or shared library missinglib\n},
|
|
@ui.error
|
|
end
|
|
|
|
def util_foo_bar
|
|
files = %w[lib/foo_bar.rb lib/directory/baz.rb Rakefile]
|
|
@foo_bar = util_spec 'foo_bar' do |gem|
|
|
gem.files = files
|
|
end
|
|
install_specs @foo_bar
|
|
|
|
files.each do |file|
|
|
filename = File.join(@foo_bar.full_gem_path, file)
|
|
FileUtils.mkdir_p File.dirname filename
|
|
FileUtils.touch filename
|
|
end
|
|
end
|
|
end
|