kotovalexarian-likes-github/simi--omniauth-facebook
1
0
Fork 0
mirror of https://github.com/simi/omniauth-facebook.git synced 2022-11-09 12:32:45 -05:00
Code Releases Activity

Upgrade Facebook Graph API to 2.11 (2.10 EOL is coming)

Browse source 
Offical message from Facebook I got today:

```
Graph API v2.10 which will reach the end of its 2-year lifetime on 05 November, 2019.We estimate 1 endpoint in total will be impacted by this change and may stop working after the automatic upgrade push. To ensure a smooth transition, please migrate all calls to Graph API v2.11 or higher.
```

According to [the official documentation](https://developers.facebook.com/docs/graph-api/changelog/version2.10/):

**Version 2.10**
Released July 18, 2017 | Available until November 7, 2019
This commit is contained in:
Igor Springer 2019-10-23 09:07:19 +02:00 committed by Josef Šimánek
parent 2de8e138d4
commit 5fdcad76fb
4 changed files with 15 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
README.md
View file

@ -58,7 +58,7 @@ end
### API Version
OmniAuth Facebook uses versioned API endpoints by default (current v2.10). You can configure a different version via `client_options` hash passed to `provider`, specifically you should change the version in the `site` and `authorize_url` parameters. For example, to change to v3.0 (assuming that exists):
OmniAuth Facebook uses versioned API endpoints by default (current v2.11). You can configure a different version via `client_options` hash passed to `provider`, specifically you should change the version in the `site` and `authorize_url` parameters. For example, to change to v3.0 (assuming that exists):
```ruby
use OmniAuth::Builder do

2
example/app.rb
View file

@ -28,7 +28,7 @@ get '/client-side' do
window.fbAsyncInit = function() {
FB.init({
appId: '#{ENV['FACEBOOK_APP_ID']}',
version: 'v2.10',
version: 'v2.11',
cookie: true // IMPORTANT must enable cookies to allow the server to access the session
});
console.log("fb init");

4
lib/omniauth/strategies/facebook.rb
View file

@ -12,8 +12,8 @@ module OmniAuth
DEFAULT_SCOPE = 'email'
option :client_options, {
site: 'https://graph.facebook.com/v2.10',
authorize_url: "https://www.facebook.com/v2.10/dialog/oauth",
site: 'https://graph.facebook.com/v2.11',
authorize_url: "https://www.facebook.com/v2.11/dialog/oauth",
token_url: 'oauth/access_token'
}

22
test/strategy_test.rb
View file

@ -9,11 +9,11 @@ end
class ClientTest < StrategyTestCase
test 'has correct Facebook site' do
assert_equal 'https://graph.facebook.com/v2.10', strategy.client.site
assert_equal 'https://graph.facebook.com/v2.11', strategy.client.site
end
test 'has correct authorize url' do
assert_equal 'https://www.facebook.com/v2.10/dialog/oauth', strategy.client.options[:authorize_url]
assert_equal 'https://www.facebook.com/v2.11/dialog/oauth', strategy.client.options[:authorize_url]
end
test 'has correct token url with versioning' do
@ -99,7 +99,7 @@ class InfoTest < StrategyTestCase
@options = { secure_image_url: true }
raw_info = { 'name' => 'Fred Smith', 'id' => '321' }
strategy.stubs(:raw_info).returns(raw_info)
assert_equal 'https://graph.facebook.com/v2.10/321/picture', strategy.info['image']
assert_equal 'https://graph.facebook.com/v2.11/321/picture', strategy.info['image']
end
test 'returns the image_url based of the client site' do
@ -113,14 +113,14 @@ class InfoTest < StrategyTestCase
@options = { image_size: 'normal' }
raw_info = { 'name' => 'Fred Smith', 'id' => '321' }
strategy.stubs(:raw_info).returns(raw_info)
assert_equal 'http://graph.facebook.com/v2.10/321/picture?type=normal', strategy.info['image']
assert_equal 'http://graph.facebook.com/v2.11/321/picture?type=normal', strategy.info['image']
end
test 'returns the image with size specified as a symbol in the `image_size` option' do
@options = { image_size: :normal }
raw_info = { 'name' => 'Fred Smith', 'id' => '321' }
strategy.stubs(:raw_info).returns(raw_info)
assert_equal 'http://graph.facebook.com/v2.10/321/picture?type=normal', strategy.info['image']
assert_equal 'http://graph.facebook.com/v2.11/321/picture?type=normal', strategy.info['image']
end
test 'returns the image with width and height specified in the `image_size` option' do
@ -129,7 +129,7 @@ class InfoTest < StrategyTestCase
strategy.stubs(:raw_info).returns(raw_info)
assert_match 'width=123', strategy.info['image']
assert_match 'height=987', strategy.info['image']
assert_match 'http://graph.facebook.com/v2.10/321/picture?', strategy.info['image']
assert_match 'http://graph.facebook.com/v2.11/321/picture?', strategy.info['image']
end
end
@ -176,7 +176,7 @@ class InfoTestOptionalDataPresent < StrategyTestCase
test 'returns the facebook avatar url' do
@raw_info['id'] = '321'
assert_equal 'http://graph.facebook.com/v2.10/321/picture', strategy.info['image']
assert_equal 'http://graph.facebook.com/v2.11/321/picture', strategy.info['image']
end
test 'returns the Facebook link as the Facebook url' do
@ -258,7 +258,7 @@ class RawInfoTest < StrategyTestCase
@options = {appsecret_proof: @appsecret_proof, fields: 'name,email'}
end
test 'performs a GET to https://graph.facebook.com/v2.10/me' do
test 'performs a GET to https://graph.facebook.com/v2.11/me' do
strategy.stubs(:appsecret_proof).returns(@appsecret_proof)
strategy.stubs(:access_token).returns(@access_token)
params = {params: @options}
@ -266,7 +266,7 @@ class RawInfoTest < StrategyTestCase
strategy.raw_info
end
test 'performs a GET to https://graph.facebook.com/v2.10/me with locale' do
test 'performs a GET to https://graph.facebook.com/v2.11/me with locale' do
@options.merge!({ locale: 'cs_CZ' })
strategy.stubs(:access_token).returns(@access_token)
strategy.stubs(:appsecret_proof).returns(@appsecret_proof)
@ -275,7 +275,7 @@ class RawInfoTest < StrategyTestCase
strategy.raw_info
end
test 'performs a GET to https://graph.facebook.com/v2.10/me with info_fields' do
test 'performs a GET to https://graph.facebook.com/v2.11/me with info_fields' do
@options.merge!({info_fields: 'about'})
strategy.stubs(:access_token).returns(@access_token)
strategy.stubs(:appsecret_proof).returns(@appsecret_proof)
@ -284,7 +284,7 @@ class RawInfoTest < StrategyTestCase
strategy.raw_info
end
test 'performs a GET to https://graph.facebook.com/v2.10/me with default info_fields' do
test 'performs a GET to https://graph.facebook.com/v2.11/me with default info_fields' do
strategy.stubs(:access_token).returns(@access_token)
strategy.stubs(:appsecret_proof).returns(@appsecret_proof)
params = {params: {appsecret_proof: @appsecret_proof, fields: 'name,email'}}