diff --git a/lib/sinatra/base.rb b/lib/sinatra/base.rb index 4f9ca6a0..05da3083 100644 --- a/lib/sinatra/base.rb +++ b/lib/sinatra/base.rb @@ -604,11 +604,6 @@ module Sinatra status.between? 500, 599 end - # whether or not the status is set to 400 - def bad_request? - status == 400 - end - # whether or not the status is set to 404 def not_found? status == 404 @@ -1144,9 +1139,6 @@ module Sinatra elsif not_found? headers['X-Cascade'] = 'pass' if settings.x_cascade? body '

Not Found

' - elsif bad_request? - dump_errors! boom if settings.dump_errors? - halt status end res = error_block!(boom.class, boom) || error_block!(status, boom) diff --git a/lib/sinatra/show_exceptions.rb b/lib/sinatra/show_exceptions.rb index ea7489b2..d54d3d83 100644 --- a/lib/sinatra/show_exceptions.rb +++ b/lib/sinatra/show_exceptions.rb @@ -49,6 +49,10 @@ module Sinatra private + def bad_request?(e) + Sinatra::BadRequest === e + end + def prefers_plain_text?(env) !(Request.new(env).preferred_type("text/plain","text/html") == "text/html") && [/curl/].index { |item| item =~ env["HTTP_USER_AGENT"] } @@ -210,8 +214,10 @@ TEMPLATE = ERB.new <<-HTML # :nodoc:

(expand)

@@ -264,47 +270,49 @@ TEMPLATE = ERB.new <<-HTML # :nodoc: -
-

GET

- <% if req.GET and not req.GET.empty? %> - - - - - - <% req.GET.sort_by { |k, v| k.to_s }.each { |key, val| %> - - - - - <% } %> -
VariableValue
<%=h key %>
<%=h val.inspect %>
- <% else %> -

No GET data.

- <% end %> -
-
+ <% unless bad_request?(exception) %> +
+

GET

+ <% if req.GET and not req.GET.empty? %> + + + + + + <% req.GET.sort_by { |k, v| k.to_s }.each { |key, val| %> + + + + + <% } %> +
VariableValue
<%=h key %>
<%=h val.inspect %>
+ <% else %> +

No GET data.

+ <% end %> +
+
-
-

POST

- <% if req.POST and not req.POST.empty? %> - - - - - - <% req.POST.sort_by { |k, v| k.to_s }.each { |key, val| %> - - - - - <% } %> -
VariableValue
<%=h key %>
<%=h val.inspect %>
- <% else %> -

No POST data.

- <% end %> -
-
+
+

POST

+ <% if req.POST and not req.POST.empty? %> + + + + + + <% req.POST.sort_by { |k, v| k.to_s }.each { |key, val| %> + + + + + <% } %> +
VariableValue
<%=h key %>
<%=h val.inspect %>
+ <% else %> +

No POST data.

+ <% end %> +
+
+ <% end %>
diff --git a/test/helpers_test.rb b/test/helpers_test.rb index 3575e945..3e6d3abf 100644 --- a/test/helpers_test.rb +++ b/test/helpers_test.rb @@ -26,23 +26,6 @@ class HelpersTest < Minitest::Test end end - describe 'bad_request?' do - it 'is true for status == 400' do - status_app(400) { bad_request? } - assert_body 'true' - end - - it 'is false for status gt 400' do - status_app(401) { bad_request? } - assert_body 'false' - end - - it 'is false for status lt 400' do - status_app(399) { bad_request? } - assert_body 'false' - end - end - describe 'not_found?' do it 'is true for status == 404' do status_app(404) { not_found? } diff --git a/test/routing_test.rb b/test/routing_test.rb index 3432566c..cc08d669 100644 --- a/test/routing_test.rb +++ b/test/routing_test.rb @@ -54,7 +54,7 @@ class RoutingTest < Minitest::Test request = Rack::MockRequest.new(@app) response = request.request('GET', '/foo?bar=&bar[]=', {}) - assert response.bad_request? + assert_equal 400, response.status end it "404s when no route satisfies the request" do diff --git a/test/settings_test.rb b/test/settings_test.rb index 88c2297b..601ddcb8 100644 --- a/test/settings_test.rb +++ b/test/settings_test.rb @@ -247,6 +247,22 @@ class SettingsTest < Minitest::Test assert body.include?("show_exceptions setting") end + it 'does not attempt to show unparseable query parameters' do + klass = Sinatra.new(Sinatra::Application) + mock_app(klass) { + enable :show_exceptions + + get '/' do + raise Sinatra::BadRequest + end + } + + get '/' + assert_equal 400, status + refute body.include?('
') + refute body.include?('
') + end + it 'does not override app-specified error handling when set to :after_handler' do ran = false mock_app do