kotovalexarian-likes-github/sinatra
1
0
Fork 0
mirror of https://github.com/sinatra/sinatra synced 2023-03-27 23:18:01 -04:00
Code Releases Activity

Ignore changing Accept-Encoding header, fixes #56

Browse source
This commit is contained in:
Renne Nissinen 2014-01-03 04:33:50 +02:00
parent 06927d60a8
commit 4e40d2c5ce
2 changed files with 6 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
rack-protection/lib/rack/protection/session_hijacking.rb
View file

@ -9,12 +9,12 @@ module Rack
# #
# Tracks request properties like the user agent in the session and empties # Tracks request properties like the user agent in the session and empties
# the session if those properties change. This essentially prevents attacks # the session if those properties change. This essentially prevents attacks
# from Firesheep. Since all headers taken into consideration might be # from Firesheep. Since all headers taken into consideration can be
# spoofed, too, this will not prevent all hijacking attempts. # spoofed, too, this will not prevent determined hijacking attempts.
class SessionHijacking < Base class SessionHijacking < Base
default_reaction :drop_session default_reaction :drop_session
default_options :tracking_key => :tracking, :encrypt_tracking => true, default_options :tracking_key => :tracking, :encrypt_tracking => true,
:track => %w[HTTP_USER_AGENT HTTP_ACCEPT_ENCODING HTTP_ACCEPT_LANGUAGE] :track => %w[HTTP_USER_AGENT HTTP_ACCEPT_LANGUAGE]
def accepts?(env) def accepts?(env)
session = session env session = session env

5
rack-protection/spec/session_hijacking_spec.rb
View file

@ -17,11 +17,12 @@ describe Rack::Protection::SessionHijacking do
session.should be_empty session.should be_empty
end end
it "denies requests with a changing Accept-Encoding header" do it "accepts requests with a changing Accept-Encoding header" do
# this is tested because previously it led to clearing the session
session = {:foo => :bar} session = {:foo => :bar}
get '/', {}, 'rack.session' => session, 'HTTP_ACCEPT_ENCODING' => 'a' get '/', {}, 'rack.session' => session, 'HTTP_ACCEPT_ENCODING' => 'a'
get '/', {}, 'rack.session' => session, 'HTTP_ACCEPT_ENCODING' => 'b' get '/', {}, 'rack.session' => session, 'HTTP_ACCEPT_ENCODING' => 'b'
session.should be_empty session.should_not be_empty
end end
it "denies requests with a changing Accept-Language header" do it "denies requests with a changing Accept-Language header" do