Fix failing tests
Rack added support for Multi-part ranges and apparently changed the format of cookie expires timestamp format to match specs.
This commit is contained in:
parent
a4dd24add2
commit
750aa3b0de
|
@ -28,12 +28,12 @@ describe Rack::Protection::CookieTossing do
|
|||
get '/some/path', {}, 'HTTP_COOKIE' => 'rack.%73ession=EVIL_SESSION_TOKEN; rack.session=EVIL_SESSION_TOKEN; rack.session=SESSION_TOKEN'
|
||||
|
||||
expected_header = <<-END.chomp
|
||||
rack.%2573ession=; domain=example.org; path=/; expires=Thu, 01 Jan 1970 00:00:00 -0000
|
||||
rack.%2573ession=; domain=example.org; path=/some; expires=Thu, 01 Jan 1970 00:00:00 -0000
|
||||
rack.%2573ession=; domain=example.org; path=/some/path; expires=Thu, 01 Jan 1970 00:00:00 -0000
|
||||
rack.session=; domain=example.org; path=/; expires=Thu, 01 Jan 1970 00:00:00 -0000
|
||||
rack.session=; domain=example.org; path=/some; expires=Thu, 01 Jan 1970 00:00:00 -0000
|
||||
rack.session=; domain=example.org; path=/some/path; expires=Thu, 01 Jan 1970 00:00:00 -0000
|
||||
rack.%2573ession=; domain=example.org; path=/; expires=Thu, 01 Jan 1970 00:00:00 GMT
|
||||
rack.%2573ession=; domain=example.org; path=/some; expires=Thu, 01 Jan 1970 00:00:00 GMT
|
||||
rack.%2573ession=; domain=example.org; path=/some/path; expires=Thu, 01 Jan 1970 00:00:00 GMT
|
||||
rack.session=; domain=example.org; path=/; expires=Thu, 01 Jan 1970 00:00:00 GMT
|
||||
rack.session=; domain=example.org; path=/some; expires=Thu, 01 Jan 1970 00:00:00 GMT
|
||||
rack.session=; domain=example.org; path=/some/path; expires=Thu, 01 Jan 1970 00:00:00 GMT
|
||||
END
|
||||
expect(last_response.headers['Set-Cookie']).to eq(expected_header)
|
||||
end
|
||||
|
|
|
@ -152,8 +152,7 @@ class StaticTest < Minitest::Test
|
|||
end
|
||||
|
||||
it 'correctly ignores syntactically invalid range requests' do
|
||||
# ...and also ignores multi-range requests, which aren't supported yet
|
||||
["bytes=45-40", "bytes=IV-LXVI", "octets=10-20", "bytes=-", "bytes=1-2,3-4"].each do |http_range|
|
||||
["bytes=45-40", "bytes=IV-LXVI", "octets=10-20", "bytes=", "bytes=3-1,4-5"].each do |http_range|
|
||||
request = Rack::MockRequest.new(@app)
|
||||
response = request.get("/#{File.basename(__FILE__)}", 'HTTP_RANGE' => http_range)
|
||||
|
||||
|
|
Loading…
Reference in New Issue