mirror of
https://github.com/sinatra/sinatra
synced 2023-03-27 23:18:01 -04:00
8ae87a87f3
* Initialize rubocop * Style/StringLiterals: prefer single quotes * Style/AndOr: use `&&` and `||`, instead of `and` and `or` * Style/HashSyntax: use new hash syntax * Layout/EmptyLineAfterGuardClause: add empty lines after guard clause * Style/SingleLineMethods: temporary disable It breaks layout of the code, it is better to fix it manually * Style/Proc: prefer `proc` vs `Proc.new` * Disable Lint/AmbiguousBlockAssociation It affects proc definitions for sinatra DSL * Disable Style/CaseEquality * Lint/UnusedBlockArgument: put underscore in front of it * Style/Alias: prefer alias vs alias_method in a class body * Layout/EmptyLineBetweenDefs: add empty lines between defs * Style/ParallelAssignment: don't use parallel assigment * Style/RegexpLiteral: prefer %r for regular expressions * Naming/UncommunicativeMethodParamName: fix abbrevs * Style/PerlBackrefs: disable cop * Layout/SpaceAfterComma: add missing spaces * Style/Documentation: disable cop * Style/FrozenStringLiteralComment: add frozen_string_literal * Layout/AlignHash: align hash * Layout/ExtraSpacing: allow for alignment * Layout/SpaceAroundOperators: add missing spaces * Style/Not: prefer `!` instead of `not` * Style/GuardClause: add guard conditions * Style/MutableConstant: freeze contants * Lint/IneffectiveAccessModifier: disable cop * Lint/RescueException: disable cop * Style/SpecialGlobalVars: disable cop * Layout/DotPosition: fix position of dot for multiline method chains * Layout/SpaceInsideArrayLiteralBrackets: don't use spaces inside arrays * Layout/SpaceInsideBlockBraces: add space for blocks * Layout/SpaceInsideHashLiteralBraces: add spaces for hashes * Style/FormatString: use format string syntax * Style/StderrPuts: `warn` is preferable to `$stderr.puts` * Bundler/DuplicatedGem: disable cop * Layout/AlignArray: fix warning * Lint/AssignmentInCondition: remove assignments from conditions * Layout/IndentHeredoc: disable cop * Layout/SpaceInsideParens: remove extra spaces * Lint/UnusedMethodArgument: put underscore in front of unused arg * Naming/RescuedExceptionsVariableName: use `e` for exceptions * Style/CommentedKeyword: put comments before the method * Style/FormatStringToken: disable cop * Style/MultilineIfModifier: move condition before the method * Style/SignalException: prefer `raise` to `fail` * Style/SymbolArray: prefer %i for array of symbols * Gemspec/OrderedDependencies: Use alphabetical order for dependencies * Lint/UselessAccessModifier: disable cop * Naming/HeredocDelimiterNaming: change delimiter's name * Style/ClassCheck: prefer `is_a?` to `kind_of?` * Style/ClassVars: disable cop * Style/Encoding: remove coding comment * Style/RedundantParentheses: remove extra parentheses * Style/StringLiteralsInInterpolation: prefer singl quotes * Layout/AlignArguments: fix alignment * Layout/ClosingHeredocIndentation: align heredoc * Layout/EmptyLineAfterMagicComment: add empty line * Set RubyVersion for rubocop * Lint/UselessAssignment: disable cop * Style/EmptyLiteral: disable cop Causes test failures * Minor code-style fixes with --safe-auto-correct option * Disable the rest of the cops that cause warnings It would be easier to re-enable them in separate PRs * Add rubocop check to the default Rake task * Update to rubocop 1.32.0 * Rubocop updates for rack-protection and sinatra-contrib * Disable Style/SlicingWithRange cop * Make suggested updates Co-authored-by: Jordan Owens <jkowens@gmail.com>
106 lines
3.7 KiB
Ruby
106 lines
3.7 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
RSpec.describe Rack::Protection::AuthenticityToken do
|
|
let(:token) { described_class.random_token }
|
|
let(:masked_token) { described_class.token(session) }
|
|
let(:bad_token) { Base64.strict_encode64('badtoken') }
|
|
let(:session) { { csrf: token } }
|
|
|
|
it_behaves_like 'any rack application'
|
|
|
|
it 'denies post requests without any token' do
|
|
expect(post('/')).not_to be_ok
|
|
end
|
|
|
|
it 'accepts post requests with correct X-CSRF-Token header' do
|
|
post('/', {}, 'rack.session' => session, 'HTTP_X_CSRF_TOKEN' => token)
|
|
expect(last_response).to be_ok
|
|
end
|
|
|
|
it 'accepts post requests with masked X-CSRF-Token header' do
|
|
post('/', {}, 'rack.session' => session, 'HTTP_X_CSRF_TOKEN' => masked_token)
|
|
expect(last_response).to be_ok
|
|
end
|
|
|
|
it 'denies post requests with wrong X-CSRF-Token header' do
|
|
post('/', {}, 'rack.session' => session, 'HTTP_X_CSRF_TOKEN' => bad_token)
|
|
expect(last_response).not_to be_ok
|
|
end
|
|
|
|
it 'accepts post form requests with correct authenticity_token field' do
|
|
post('/', { 'authenticity_token' => token }, 'rack.session' => session)
|
|
expect(last_response).to be_ok
|
|
end
|
|
|
|
it 'accepts post form requests with masked authenticity_token field' do
|
|
post('/', { 'authenticity_token' => masked_token }, 'rack.session' => session)
|
|
expect(last_response).to be_ok
|
|
end
|
|
|
|
it 'denies post form requests with wrong authenticity_token field' do
|
|
post('/', { 'authenticity_token' => bad_token }, 'rack.session' => session)
|
|
expect(last_response).not_to be_ok
|
|
end
|
|
|
|
it 'accepts post form requests with a valid per form token' do
|
|
token = Rack::Protection::AuthenticityToken.token(session, path: '/foo')
|
|
post('/foo', { 'authenticity_token' => token }, 'rack.session' => session)
|
|
expect(last_response).to be_ok
|
|
end
|
|
|
|
it 'denies post form requests with an invalid per form token' do
|
|
token = Rack::Protection::AuthenticityToken.token(session, path: '/foo')
|
|
post('/bar', { 'authenticity_token' => token }, 'rack.session' => session)
|
|
expect(last_response).not_to be_ok
|
|
end
|
|
|
|
it 'prevents ajax requests without a valid token' do
|
|
expect(post('/', {}, 'HTTP_X_REQUESTED_WITH' => 'XMLHttpRequest')).not_to be_ok
|
|
end
|
|
|
|
it 'allows for a custom authenticity token param' do
|
|
mock_app do
|
|
use Rack::Protection::AuthenticityToken, authenticity_param: 'csrf_param'
|
|
run proc { |_e| [200, { 'Content-Type' => 'text/plain' }, ['hi']] }
|
|
end
|
|
|
|
post('/', { 'csrf_param' => token }, 'rack.session' => { csrf: token })
|
|
expect(last_response).to be_ok
|
|
end
|
|
|
|
it "sets a new csrf token for the session in env, even after a 'safe' request" do
|
|
get('/', {}, {})
|
|
expect(env['rack.session'][:csrf]).not_to be_nil
|
|
end
|
|
|
|
it 'allows for a custom token session key' do
|
|
mock_app do
|
|
use Rack::Session::Cookie, key: 'rack.session'
|
|
use Rack::Protection::AuthenticityToken, key: :_csrf
|
|
run DummyApp
|
|
end
|
|
|
|
get '/'
|
|
expect(env['rack.session'][:_csrf]).not_to be_nil
|
|
end
|
|
|
|
describe '.token' do
|
|
it 'returns a unique masked version of the authenticity token' do
|
|
expect(Rack::Protection::AuthenticityToken.token(session)).not_to eq(masked_token)
|
|
end
|
|
|
|
it 'sets a session authenticity token if one does not exist' do
|
|
session = {}
|
|
allow(Rack::Protection::AuthenticityToken).to receive(:random_token).and_return(token)
|
|
allow_any_instance_of(Rack::Protection::AuthenticityToken).to receive(:mask_token).and_return(masked_token)
|
|
Rack::Protection::AuthenticityToken.token(session)
|
|
expect(session[:csrf]).to eq(token)
|
|
end
|
|
end
|
|
|
|
describe '.random_token' do
|
|
it 'generates a base64 encoded 32 character string' do
|
|
expect(Base64.urlsafe_decode64(token).length).to eq(32)
|
|
end
|
|
end
|
|
end
|