mirror of
https://github.com/sinatra/sinatra
synced 2023-03-27 23:18:01 -04:00
8ae87a87f3
* Initialize rubocop * Style/StringLiterals: prefer single quotes * Style/AndOr: use `&&` and `||`, instead of `and` and `or` * Style/HashSyntax: use new hash syntax * Layout/EmptyLineAfterGuardClause: add empty lines after guard clause * Style/SingleLineMethods: temporary disable It breaks layout of the code, it is better to fix it manually * Style/Proc: prefer `proc` vs `Proc.new` * Disable Lint/AmbiguousBlockAssociation It affects proc definitions for sinatra DSL * Disable Style/CaseEquality * Lint/UnusedBlockArgument: put underscore in front of it * Style/Alias: prefer alias vs alias_method in a class body * Layout/EmptyLineBetweenDefs: add empty lines between defs * Style/ParallelAssignment: don't use parallel assigment * Style/RegexpLiteral: prefer %r for regular expressions * Naming/UncommunicativeMethodParamName: fix abbrevs * Style/PerlBackrefs: disable cop * Layout/SpaceAfterComma: add missing spaces * Style/Documentation: disable cop * Style/FrozenStringLiteralComment: add frozen_string_literal * Layout/AlignHash: align hash * Layout/ExtraSpacing: allow for alignment * Layout/SpaceAroundOperators: add missing spaces * Style/Not: prefer `!` instead of `not` * Style/GuardClause: add guard conditions * Style/MutableConstant: freeze contants * Lint/IneffectiveAccessModifier: disable cop * Lint/RescueException: disable cop * Style/SpecialGlobalVars: disable cop * Layout/DotPosition: fix position of dot for multiline method chains * Layout/SpaceInsideArrayLiteralBrackets: don't use spaces inside arrays * Layout/SpaceInsideBlockBraces: add space for blocks * Layout/SpaceInsideHashLiteralBraces: add spaces for hashes * Style/FormatString: use format string syntax * Style/StderrPuts: `warn` is preferable to `$stderr.puts` * Bundler/DuplicatedGem: disable cop * Layout/AlignArray: fix warning * Lint/AssignmentInCondition: remove assignments from conditions * Layout/IndentHeredoc: disable cop * Layout/SpaceInsideParens: remove extra spaces * Lint/UnusedMethodArgument: put underscore in front of unused arg * Naming/RescuedExceptionsVariableName: use `e` for exceptions * Style/CommentedKeyword: put comments before the method * Style/FormatStringToken: disable cop * Style/MultilineIfModifier: move condition before the method * Style/SignalException: prefer `raise` to `fail` * Style/SymbolArray: prefer %i for array of symbols * Gemspec/OrderedDependencies: Use alphabetical order for dependencies * Lint/UselessAccessModifier: disable cop * Naming/HeredocDelimiterNaming: change delimiter's name * Style/ClassCheck: prefer `is_a?` to `kind_of?` * Style/ClassVars: disable cop * Style/Encoding: remove coding comment * Style/RedundantParentheses: remove extra parentheses * Style/StringLiteralsInInterpolation: prefer singl quotes * Layout/AlignArguments: fix alignment * Layout/ClosingHeredocIndentation: align heredoc * Layout/EmptyLineAfterMagicComment: add empty line * Set RubyVersion for rubocop * Lint/UselessAssignment: disable cop * Style/EmptyLiteral: disable cop Causes test failures * Minor code-style fixes with --safe-auto-correct option * Disable the rest of the cops that cause warnings It would be easier to re-enable them in separate PRs * Add rubocop check to the default Rake task * Update to rubocop 1.32.0 * Rubocop updates for rack-protection and sinatra-contrib * Disable Style/SlicingWithRange cop * Make suggested updates Co-authored-by: Jordan Owens <jkowens@gmail.com>
99 lines
2.9 KiB
Ruby
99 lines
2.9 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
RSpec.describe Rack::Protection::JsonCsrf do
|
|
it_behaves_like 'any rack application'
|
|
|
|
module DummyAppWithBody
|
|
module Closeable
|
|
def close
|
|
@closed = true
|
|
end
|
|
|
|
def closed?
|
|
@closed
|
|
end
|
|
end
|
|
|
|
def self.body
|
|
@body ||= begin
|
|
body = ['ok']
|
|
body.extend(Closeable)
|
|
body
|
|
end
|
|
end
|
|
|
|
def self.call(env)
|
|
Thread.current[:last_env] = env
|
|
[200, { 'Content-Type' => 'application/json' }, body]
|
|
end
|
|
end
|
|
|
|
describe 'json response' do
|
|
before do
|
|
mock_app { |_e| [200, { 'Content-Type' => 'application/json' }, []] }
|
|
end
|
|
|
|
it 'denies get requests with json responses with a remote referrer' do
|
|
expect(get('/', {}, 'HTTP_REFERER' => 'http://evil.com')).not_to be_ok
|
|
end
|
|
|
|
it 'closes the body returned by the app if it denies the get request' do
|
|
mock_app DummyAppWithBody do |_e|
|
|
[200, { 'Content-Type' => 'application/json' }, []]
|
|
end
|
|
|
|
get('/', {}, 'HTTP_REFERER' => 'http://evil.com')
|
|
|
|
expect(DummyAppWithBody.body).to be_closed
|
|
end
|
|
|
|
it 'accepts requests with json responses with a remote referrer when allow_if is true' do
|
|
mock_app do
|
|
use Rack::Protection::JsonCsrf, allow_if: ->(env) { env['HTTP_REFERER'] == 'http://good.com' }
|
|
run proc { |_e| [200, { 'Content-Type' => 'application/json' }, []] }
|
|
end
|
|
|
|
expect(get('/', {}, 'HTTP_REFERER' => 'http://good.com')).to be_ok
|
|
end
|
|
|
|
it "accepts requests with json responses with a remote referrer when there's an origin header set" do
|
|
expect(get('/', {}, 'HTTP_REFERER' => 'http://good.com', 'HTTP_ORIGIN' => 'http://good.com')).to be_ok
|
|
end
|
|
|
|
it "accepts requests with json responses with a remote referrer when there's an x-origin header set" do
|
|
expect(get('/', {}, 'HTTP_REFERER' => 'http://good.com', 'HTTP_X_ORIGIN' => 'http://good.com')).to be_ok
|
|
end
|
|
|
|
it 'accepts get requests with json responses with a local referrer' do
|
|
expect(get('/', {}, 'HTTP_REFERER' => '/')).to be_ok
|
|
end
|
|
|
|
it 'accepts get requests with json responses with no referrer' do
|
|
expect(get('/', {})).to be_ok
|
|
end
|
|
|
|
it 'accepts XHR requests' do
|
|
expect(get('/', {}, 'HTTP_REFERER' => 'http://evil.com', 'HTTP_X_REQUESTED_WITH' => 'XMLHttpRequest')).to be_ok
|
|
end
|
|
end
|
|
|
|
describe 'not json response' do
|
|
it 'accepts get requests with 304 headers' do
|
|
mock_app { |_e| [304, {}, []] }
|
|
expect(get('/', {}).status).to eq(304)
|
|
end
|
|
end
|
|
|
|
describe 'with drop_session as default reaction' do
|
|
it 'still denies' do
|
|
mock_app do
|
|
use Rack::Protection, reaction: :drop_session
|
|
run proc { |_e| [200, { 'Content-Type' => 'application/json' }, []] }
|
|
end
|
|
|
|
session = { foo: :bar }
|
|
get('/', {}, 'HTTP_REFERER' => 'http://evil.com', 'rack.session' => session)
|
|
expect(last_response).not_to be_ok
|
|
end
|
|
end
|
|
end
|