mirror of
https://github.com/sinatra/sinatra
synced 2023-03-27 23:18:01 -04:00
f10e571f4d
We use minitest for Sinatra's test suite but we weren't using its rake task. I've updated the Rakefile to require and use Minitest default rake task to simplify. Another change is to rename the `helper.rb` file to `test_helper.rb` because I think that name is used more in the community and require it directly without calling `File.expand_path`
276 lines
8.5 KiB
Ruby
276 lines
8.5 KiB
Ruby
require_relative 'test_helper'
|
|
|
|
class StaticTest < Minitest::Test
|
|
setup do
|
|
mock_app do
|
|
set :static, true
|
|
set :public_folder, __dir__
|
|
end
|
|
end
|
|
|
|
it 'serves GET requests for files in the public directory' do
|
|
get "/#{File.basename(__FILE__)}"
|
|
assert ok?
|
|
assert_equal File.read(__FILE__), body
|
|
assert_equal File.size(__FILE__).to_s, response['Content-Length']
|
|
assert response.headers.include?('Last-Modified')
|
|
end
|
|
|
|
it 'produces a body that can be iterated over multiple times' do
|
|
env = Rack::MockRequest.env_for("/#{File.basename(__FILE__)}")
|
|
_, _, body = @app.call(env)
|
|
buf1, buf2 = [], []
|
|
body.each { |part| buf1 << part }
|
|
body.each { |part| buf2 << part }
|
|
assert_equal buf1.join, buf2.join
|
|
assert_equal File.read(__FILE__), buf1.join
|
|
end
|
|
|
|
it 'sets the sinatra.static_file env variable if served' do
|
|
env = Rack::MockRequest.env_for("/#{File.basename(__FILE__)}")
|
|
@app.call(env)
|
|
assert_equal File.expand_path(__FILE__), env['sinatra.static_file']
|
|
end
|
|
|
|
it 'serves HEAD requests for files in the public directory' do
|
|
head "/#{File.basename(__FILE__)}"
|
|
assert ok?
|
|
assert_equal '', body
|
|
assert response.headers.include?('Last-Modified')
|
|
assert_equal File.size(__FILE__).to_s, response['Content-Length']
|
|
end
|
|
|
|
%w[POST PUT DELETE].each do |verb|
|
|
it "does not serve #{verb} requests" do
|
|
send verb.downcase, "/#{File.basename(__FILE__)}"
|
|
assert_equal 404, status
|
|
end
|
|
end
|
|
|
|
it 'serves files in preference to custom routes' do
|
|
@app.get("/#{File.basename(__FILE__)}") { 'Hello World' }
|
|
get "/#{File.basename(__FILE__)}"
|
|
assert ok?
|
|
assert body != 'Hello World'
|
|
end
|
|
|
|
it 'does not serve directories' do
|
|
get "/"
|
|
assert not_found?
|
|
end
|
|
|
|
it 'passes to the next handler when the path contains null bytes' do
|
|
get "/foo%00"
|
|
assert not_found?
|
|
end
|
|
|
|
it 'passes to the next handler when the static option is disabled' do
|
|
@app.set :static, false
|
|
get "/#{File.basename(__FILE__)}"
|
|
assert not_found?
|
|
end
|
|
|
|
it 'passes to the next handler when the public option is nil' do
|
|
@app.set :public_folder, nil
|
|
get "/#{File.basename(__FILE__)}"
|
|
assert not_found?
|
|
end
|
|
|
|
it '404s when a file is not found' do
|
|
get "/foobarbaz.txt"
|
|
assert not_found?
|
|
end
|
|
|
|
it 'there is no path is 404 error pages' do
|
|
env = Rack::MockRequest.env_for("/dummy").tap { |env| env["PATH_INFO"] = "/<script>" }
|
|
_, _, body = @app.call(env)
|
|
assert_equal(["<h1>Not Found</h1>"], body, "Unexpected response content.")
|
|
end
|
|
|
|
it 'serves files when .. path traverses within public directory' do
|
|
get "/data/../#{File.basename(__FILE__)}"
|
|
assert ok?
|
|
assert_equal File.read(__FILE__), body
|
|
end
|
|
|
|
it '404s when .. path traverses outside of public directory' do
|
|
mock_app do
|
|
set :static, true
|
|
set :public_folder, __dir__ + '/data'
|
|
disable :protection
|
|
end
|
|
get "/../#{File.basename(__FILE__)}"
|
|
assert not_found?
|
|
end
|
|
|
|
def assert_valid_range(http_range, range, path, file)
|
|
request = Rack::MockRequest.new(@app)
|
|
response = request.get("/#{File.basename(path)}", 'HTTP_RANGE' => http_range)
|
|
|
|
should_be = file[range]
|
|
expected_range = "bytes #{range.begin}-#{range.end}/#{file.length}"
|
|
|
|
assert_equal(
|
|
206,response.status,
|
|
"Should be HTTP/1.1 206 Partial content"
|
|
)
|
|
assert_equal(
|
|
should_be.length,
|
|
response.body.length,
|
|
"Unexpected response length for #{http_range}"
|
|
)
|
|
assert_equal(
|
|
should_be,
|
|
response.body,
|
|
"Unexpected response data for #{http_range}"
|
|
)
|
|
assert_equal(
|
|
should_be.length.to_s,
|
|
response['Content-Length'],
|
|
"Incorrect Content-Length for #{http_range}"
|
|
)
|
|
assert_equal(
|
|
expected_range,
|
|
response['Content-Range'],
|
|
"Incorrect Content-Range for #{http_range}"
|
|
)
|
|
end
|
|
|
|
it 'handles valid byte ranges correctly' do
|
|
# Use the biggest file in this dir so we can test ranges > 8k bytes. (StaticFile sends in 8k chunks.)
|
|
path = __dir__ + '/helpers_test.rb' # currently 16k bytes
|
|
file = File.read(path)
|
|
length = file.length
|
|
assert length > 9000, "The test file #{path} is too short (#{length} bytes) to run these tests"
|
|
|
|
[0..0, 42..88, 1234..1234, 100..9000, 0..(length-1), (length-1)..(length-1)].each do |range|
|
|
assert_valid_range("bytes=#{range.begin}-#{range.end}", range, path, file)
|
|
end
|
|
|
|
[0, 100, length-100, length-1].each do |start|
|
|
assert_valid_range("bytes=#{start}-", (start..length-1), path, file)
|
|
end
|
|
|
|
[1, 100, length-100, length-1, length].each do |range_length|
|
|
assert_valid_range("bytes=-#{range_length}", (length-range_length..length-1), path, file)
|
|
end
|
|
|
|
# Some valid ranges that exceed the length of the file:
|
|
assert_valid_range("bytes=100-999999", (100..length-1), path, file)
|
|
assert_valid_range("bytes=100-#{length}", (100..length-1), path, file)
|
|
assert_valid_range("bytes=-#{length}", (0..length-1), path, file)
|
|
assert_valid_range("bytes=-#{length+1}", (0..length-1), path, file)
|
|
assert_valid_range("bytes=-999999", (0..length-1), path, file)
|
|
end
|
|
|
|
it 'correctly ignores syntactically invalid range requests' do
|
|
["bytes=45-40", "octets=10-20", "bytes=", "bytes=3-1,4-5"].each do |http_range|
|
|
request = Rack::MockRequest.new(@app)
|
|
response = request.get("/#{File.basename(__FILE__)}", 'HTTP_RANGE' => http_range)
|
|
|
|
assert_equal(
|
|
200,
|
|
response.status,
|
|
"Invalid range '#{http_range}' should be ignored"
|
|
)
|
|
assert_nil(
|
|
response['Content-Range'],
|
|
"Invalid range '#{http_range}' should be ignored"
|
|
)
|
|
end
|
|
end
|
|
|
|
it 'returns error 416 for unsatisfiable range requests' do
|
|
# An unsatisfiable request is one that specifies a start that's at or past the end of the file.
|
|
length = File.read(__FILE__).length
|
|
["bytes=888888-", "bytes=888888-999999", "bytes=#{length}-#{length}"].each do |http_range|
|
|
request = Rack::MockRequest.new(@app)
|
|
response = request.get("/#{File.basename(__FILE__)}", 'HTTP_RANGE' => http_range)
|
|
|
|
assert_equal(
|
|
416,
|
|
response.status,
|
|
"Unsatisfiable range '#{http_range}' should return 416"
|
|
)
|
|
assert_equal(
|
|
"bytes */#{length}",
|
|
response['Content-Range'],
|
|
"416 response should include actual length"
|
|
)
|
|
end
|
|
end
|
|
|
|
it 'does not include static cache control headers by default' do
|
|
env = Rack::MockRequest.env_for("/#{File.basename(__FILE__)}")
|
|
_, headers, _ = @app.call(env)
|
|
assert !headers.has_key?('Cache-Control')
|
|
end
|
|
|
|
it 'sets cache control headers on static files if set' do
|
|
@app.set :static_cache_control, :public
|
|
env = Rack::MockRequest.env_for("/#{File.basename(__FILE__)}")
|
|
_, headers, _ = @app.call(env)
|
|
assert headers.has_key?('Cache-Control')
|
|
assert_equal headers['Cache-Control'], 'public'
|
|
|
|
@app.set(
|
|
:static_cache_control,
|
|
[:public, :must_revalidate, {:max_age => 300}]
|
|
)
|
|
env = Rack::MockRequest.env_for("/#{File.basename(__FILE__)}")
|
|
_, headers, _ = @app.call(env)
|
|
assert headers.has_key?('Cache-Control')
|
|
assert_equal(
|
|
headers['Cache-Control'],
|
|
'public, must-revalidate, max-age=300'
|
|
)
|
|
end
|
|
|
|
it 'renders static assets with custom status via options' do
|
|
mock_app do
|
|
set :static, true
|
|
set :public_folder, __dir__
|
|
|
|
post '/*' do
|
|
static!(:status => params[:status])
|
|
end
|
|
end
|
|
|
|
post "/#{File.basename(__FILE__)}?status=422"
|
|
assert_equal response.status, 422
|
|
assert_equal File.read(__FILE__), body
|
|
assert_equal File.size(__FILE__).to_s, response['Content-Length']
|
|
assert response.headers.include?('Last-Modified')
|
|
end
|
|
|
|
it 'serves files with a + sign in the path' do
|
|
mock_app do
|
|
set :static, true
|
|
set :public_folder, File.join(__dir__, 'public')
|
|
end
|
|
|
|
get "/hello+world.txt"
|
|
|
|
real_path = File.join(__dir__, 'public', 'hello+world.txt')
|
|
assert ok?
|
|
assert_equal File.read(real_path), body
|
|
assert_equal File.size(real_path).to_s, response['Content-Length']
|
|
assert response.headers.include?('Last-Modified')
|
|
end
|
|
|
|
it 'serves files with a URL encoded + sign (%2B) in the path' do
|
|
mock_app do
|
|
set :static, true
|
|
set :public_folder, File.join(__dir__, 'public')
|
|
end
|
|
|
|
get "/hello%2bworld.txt"
|
|
|
|
real_path = File.join(__dir__, 'public', 'hello+world.txt')
|
|
assert ok?
|
|
assert_equal File.read(real_path), body
|
|
assert_equal File.size(real_path).to_s, response['Content-Length']
|
|
assert response.headers.include?('Last-Modified')
|
|
end
|
|
|
|
end
|