kotovalexarian-likes-github/teamcapybara--capybara
1
0
Fork 0
mirror of https://github.com/teamcapybara/capybara.git synced 2022-11-09 12:08:07 -05:00
Code Releases Activity

Merge pull request #2501 from georgeclaghorn/selenium-webdriver-4-new-window-deprecation

Browse source 
Shush deprecation warning when opening new window on Selenium WebDriver 4
This commit is contained in:
Thomas Walpole 2021-10-23 12:38:59 -07:00 • committed by GitHub
commit 554c2acaa9
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
lib/capybara/selenium/driver.rb
View file

@ -254,7 +254,11 @@ class Capybara::Selenium::Driver < Capybara::Driver::Base
end end
def open_new_window(kind = :tab) def open_new_window(kind = :tab)
browser.manage.new_window(kind) if browser.switch_to.respond_to?(:new_window)
browser.switch_to.new_window(kind)
else
browser.manage.new_window(kind)
end
rescue NoMethodError, Selenium::WebDriver::Error::WebDriverError rescue NoMethodError, Selenium::WebDriver::Error::WebDriverError
# If not supported by the driver or browser default to using JS # If not supported by the driver or browser default to using JS
browser.execute_script('window.open();') browser.execute_script('window.open();')