From 5ca348f7d1a50efdcb959a81483d692b976ce27e Mon Sep 17 00:00:00 2001 From: Thomas Walpole Date: Wed, 10 Jan 2018 16:47:39 -0800 Subject: [PATCH] remove `field_labeled` alias for `find_field` --- lib/capybara/node/finders.rb | 1 - lib/capybara/session.rb | 2 +- lib/capybara/spec/session/find_field_spec.rb | 7 ------- 3 files changed, 1 insertion(+), 9 deletions(-) diff --git a/lib/capybara/node/finders.rb b/lib/capybara/node/finders.rb index b75e04f1..5cfdf6d9 100644 --- a/lib/capybara/node/finders.rb +++ b/lib/capybara/node/finders.rb @@ -126,7 +126,6 @@ module Capybara def find_field(locator = nil, **options, &optional_filter_block) find(:field, locator, options, &optional_filter_block) end - alias_method :field_labeled, :find_field ## # diff --git a/lib/capybara/session.rb b/lib/capybara/session.rb index da9bca7d..8ca03b5e 100644 --- a/lib/capybara/session.rb +++ b/lib/capybara/session.rb @@ -40,7 +40,7 @@ module Capybara NODE_METHODS = %i[ all first attach_file text check choose - click_link_or_button click_button click_link field_labeled + click_link_or_button click_button click_link fill_in find find_all find_button find_by_id find_field find_link has_content? has_text? has_css? has_no_content? has_no_text? has_no_css? has_no_xpath? resolve has_xpath? select uncheck diff --git a/lib/capybara/spec/session/find_field_spec.rb b/lib/capybara/spec/session/find_field_spec.rb index 995022fe..d60e7ea1 100644 --- a/lib/capybara/spec/session/find_field_spec.rb +++ b/lib/capybara/spec/session/find_field_spec.rb @@ -41,13 +41,6 @@ Capybara::SpecHelper.spec '#find_field' do @session.find_field('Dog', disabled: nil) end - it "should be aliased as 'field_labeled' for webrat compatibility" do - expect(@session.field_labeled('Dog').value).to eq('dog') - expect do - @session.field_labeled('Does not exist') - end.to raise_error(Capybara::ElementNotFound) - end - context "with :exact option" do it "should accept partial matches when false" do expect(@session.find_field("Explanation", exact: false)[:name]).to eq("form[name_explanation]")