kotovalexarian-likes-github/teamcapybara--capybara
1
0
Fork 0
mirror of https://github.com/teamcapybara/capybara.git synced 2022-11-09 12:08:07 -05:00
Code Releases Activity

Fix #set_text behavior with clear: :none option

Browse source 
After 696f9d3 is committed, Capybara has been overwrite form input even if `clear: :none` option is provided.
This bug occur with rapid fill when input over 30 words.
This commit is contained in:
sukechannnn 2020-05-29 21:15:16 +09:00
parent d1abf017d5
commit 5d1ec0439d
2 changed files with 11 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
lib/capybara/selenium/node.rb
View file

@ -281,7 +281,7 @@ private
driver.execute_script 'arguments[0].select()', self unless clear == :none
if rapid == true || ((value.length > auto_rapid_set_length) && rapid != false)
send_keys(value[0..3])
driver.execute_script RAPID_SET_TEXT, self, value[0...-3]
driver.execute_script RAPID_SET_TEXT, self, value[4...-3]
send_keys(value[-3..-1])
else
send_keys(value)
@ -539,7 +539,7 @@ private
if (el.maxLength && el.maxLength != -1){
value = value.slice(0, el.maxLength);
}
el.value = value;
el.value = el.value + value;
})(arguments[0], arguments[1])
JS

9
spec/shared_selenium_session.rb
View file

@ -160,6 +160,15 @@ RSpec.shared_examples 'Capybara::Session' do |session, mode|
fill_options: { clear: :none })
expect(session.find(:fillable_field, 'form_first_name').value).to eq('JohnHarry')
end
it 'works with rapid fill' do
pending 'Safari overwrites by default - need to figure out a workaround' if safari?(session)
long_string = (0...60).map { |i| ((i % 26) + 65).chr }.join
session.visit('/form')
session.fill_in('form_first_name', with: long_string, fill_options: { clear: :none })
expect(session.find(:fillable_field, 'form_first_name').value).to eq('John' + long_string)
end
end
describe '#fill_in with Date' do