kotovalexarian-likes-github/teamcapybara--capybara
1
0
Fork 0
mirror of https://github.com/teamcapybara/capybara.git synced 2022-11-09 12:08:07 -05:00
Code Releases Activity

Improve animation disabled tests

Browse source
This commit is contained in:
Thomas Walpole 2018-08-21 09:24:35 -07:00
parent 61563029ff
commit 60cc96204d
1 changed files with 34 additions and 28 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

62
spec/shared_selenium_session.rb
View file

@ -323,31 +323,33 @@ RSpec.shared_examples 'Capybara::Session' do |session, mode|
end end
end end
context 'AnimationDisabler' do describe 'Capybara#disable_animation', :focus_ do
before(:context) do # rubocop:disable RSpec/BeforeAfterAll context 'when set to `true`' do
# NOTE: Although Capybara.SpecHelper.reset! sets Capybara.disable_animation to false, before(:context) do # rubocop:disable RSpec/BeforeAfterAll
# it doesn't affect any of these tests because the settings are applied per-session # NOTE: Although Capybara.SpecHelper.reset! sets Capybara.disable_animation to false,
Capybara.disable_animation = true # it doesn't affect any of these tests because the settings are applied per-session
@animation_session = Capybara::Session.new(session.mode, TestApp.new) Capybara.disable_animation = true
@animation_session = Capybara::Session.new(session.mode, TestApp.new)
end
after(:context) do # rubocop:disable RSpec/BeforeAfterAll
@animation_session = nil
end
it 'should disable CSS transitions' do
@animation_session.visit('with_animation')
@animation_session.click_link('transition me away')
expect(@animation_session).to have_no_link('transition me away', wait: 0.5)
end
it 'should disable CSS animations' do
@animation_session.visit('with_animation')
@animation_session.click_link('animate me away')
expect(@animation_session).to have_no_link('animate me away', wait: 0.5)
end
end end
after(:context) do # rubocop:disable RSpec/BeforeAfterAll context 'if we pass in css that matches elements' do
@animation_session = nil
end
it 'should disable CSS transitions' do
@animation_session.visit('with_animation')
@animation_session.click_link('transition me away')
expect(@animation_session).to have_no_link('transition me away', wait: 0.5)
end
it 'should disable CSS animations' do
@animation_session.visit('with_animation')
@animation_session.click_link('animate me away')
expect(@animation_session).to have_no_link('animate me away', wait: 0.5)
end
context 'if we pass in css that matches css on screen' do
before(:context) do # rubocop:disable RSpec/BeforeAfterAll before(:context) do # rubocop:disable RSpec/BeforeAfterAll
# NOTE: Although Capybara.SpecHelper.reset! sets Capybara.disable_animation to false, # NOTE: Although Capybara.SpecHelper.reset! sets Capybara.disable_animation to false,
# it doesn't affect any of these tests because the settings are applied per-session # it doesn't affect any of these tests because the settings are applied per-session
@ -372,7 +374,7 @@ RSpec.shared_examples 'Capybara::Session' do |session, mode|
end end
end end
context 'if we pass in css that does not matches css on screen' do context 'if we pass in css that does not match elements' do
before(:context) do # rubocop:disable RSpec/BeforeAfterAll before(:context) do # rubocop:disable RSpec/BeforeAfterAll
# NOTE: Although Capybara.SpecHelper.reset! sets Capybara.disable_animation to false, # NOTE: Although Capybara.SpecHelper.reset! sets Capybara.disable_animation to false,
# it doesn't affect any of these tests because the settings are applied per-session # it doesn't affect any of these tests because the settings are applied per-session
@ -384,16 +386,20 @@ RSpec.shared_examples 'Capybara::Session' do |session, mode|
@animation_session_without_matching_css = nil @animation_session_without_matching_css = nil
end end
it 'should disable CSS transitions' do it 'should not disable CSS transitions' do
@animation_session_without_matching_css.visit('with_animation') @animation_session_without_matching_css.visit('with_animation')
@animation_session_without_matching_css.click_link('transition me away') @animation_session_without_matching_css.click_link('transition me away')
expect(@animation_session_without_matching_css).to have_link('transition me away', wait: 0.5) sleep 0.5 # Wait long enough for click to have been processed
expect(@animation_session_without_matching_css).to have_link('transition me away', wait: false)
expect(@animation_session_without_matching_css).to have_no_link('transition me away', wait: 5)
end end
it 'should disable CSS animations' do it 'should not disable CSS animations' do
@animation_session_without_matching_css.visit('with_animation') @animation_session_without_matching_css.visit('with_animation')
@animation_session_without_matching_css.click_link('animate me away') @animation_session_without_matching_css.click_link('animate me away')
expect(@animation_session_without_matching_css).to have_link('animate me away', wait: 0.5) sleep 0.5 # Wait long enough for click to have been processed
expect(@animation_session_without_matching_css).to have_link('animate me away', wait: false)
expect(@animation_session_without_matching_css).to have_no_link('animate me away', wait: 5)
end end
end end
end end