kotovalexarian-likes-github/teamcapybara--capybara
1
0
Fork 0
mirror of https://github.com/teamcapybara/capybara.git synced 2022-11-09 12:08:07 -05:00
Code Releases Activity

Add calling location when locators fail validation

Browse source
This commit is contained in:
Thomas Walpole 2022-05-08 13:04:24 -07:00
parent 2f4a426ee7
commit 72b70fa058
3 changed files with 12 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
lib/capybara/helpers.rb
View file

@ -73,7 +73,7 @@ module Capybara
def filter_backtrace(trace)
return 'No backtrace' unless trace
filter = %r{lib/capybara/|lib/rspec/|lib/minitest/}
filter = %r{lib/capybara/|lib/rspec/|lib/minitest/|delegate.rb}
new_trace = trace.take_while { |line| line !~ filter }
new_trace = trace.grep_v(filter) if new_trace.empty?
new_trace = trace.dup if new_trace.empty?

6
lib/capybara/selector/selector.rb
View file

@ -66,7 +66,11 @@ module Capybara
end
ensure
unless locator_valid?(locator)
warn "Locator #{locator.class}:#{locator.inspect} for selector #{name.inspect} must #{locator_description}. This will raise an error in a future version of Capybara."
Capybara::Helpers.warn(
"Locator #{locator.class}:#{locator.inspect} for selector #{name.inspect} must #{locator_description}. " \
'This will raise an error in a future version of Capybara. ' \
"Called from: #{Capybara::Helpers.filter_backtrace(caller)}"
)
end
end

6
lib/capybara/spec/session/has_link_spec.rb
View file

@ -19,6 +19,12 @@ Capybara::SpecHelper.spec '#has_link?' do
expect(@session).not_to have_link('A link', href: /nonexistent/)
end
it 'should notify if an invalid locator is specified' do
allow(Capybara::Helpers).to receive(:warn).and_return(nil)
@session.has_link?(@session)
expect(Capybara::Helpers).to have_received(:warn).with(/Called from: .+/)
end
context 'with focused:', requires: [:active_element] do
it 'should be true if the given link is on the page and has focus' do
@session.send_keys(:tab)