From 733b052f7465f174392d164f675f24fea14387e3 Mon Sep 17 00:00:00 2001 From: Thomas Walpole Date: Wed, 16 Jan 2019 09:53:09 -0800 Subject: [PATCH] Change gumbo usage default to be false --- lib/capybara.rb | 4 ++-- spec/basic_node_spec.rb | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/capybara.rb b/lib/capybara.rb index 5d9e6bcb..b685817c 100644 --- a/lib/capybara.rb +++ b/lib/capybara.rb @@ -88,7 +88,7 @@ module Capybara # [test_id = Symbol/String/nil] Optional attribute to match locator aginst with builtin selectors along with id (Default: nil) # [predicates_wait = Boolean] Whether Capybaras predicate matchers use waiting behavior by default (Default: true) # [default_normalize_ws = Boolean] Whether text predicates and matchers use normalize whitespace behaviour (Default: false) - # [allow_gumbo = Boolean] When `nokogumbo` is available, whether it will be used to parse HTML strings (Default: true) + # [allow_gumbo = Boolean] When `nokogumbo` is available, whether it will be used to parse HTML strings (Default: false) # # === DSL Options # @@ -525,7 +525,7 @@ Capybara.configure do |config| config.test_id = nil config.predicates_wait = true config.default_normalize_ws = false - config.allow_gumbo = true + config.allow_gumbo = false end Capybara.register_driver :rack_test do |app| diff --git a/spec/basic_node_spec.rb b/spec/basic_node_spec.rb index 5611e681..a2efe2a6 100644 --- a/spec/basic_node_spec.rb +++ b/spec/basic_node_spec.rb @@ -111,7 +111,7 @@ RSpec.describe Capybara do end it 'drops illegal fragments when using gumbo' do - skip 'libxml is less strict thatn Gumbo' unless Nokogiri.respond_to?(:HTML5) + skip 'libxml is less strict than Gumbo' unless Nokogiri.respond_to?(:HTML5) expect(Capybara.string('1')).not_to have_css('td') end