kotovalexarian-likes-github/teamcapybara--capybara
1
0
Fork 0
mirror of https://github.com/teamcapybara/capybara.git synced 2022-11-09 12:08:07 -05:00
Code Releases Activity

Update expected failures when using Firefox

Browse source
This commit is contained in:
Thomas Walpole 2022-06-14 18:35:47 -07:00
parent 2a2409767b
commit a9dd889b64
4 changed files with 11 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
lib/capybara/spec/session/fill_in_spec.rb
View file

@ -98,7 +98,7 @@ Capybara::SpecHelper.spec '#fill_in' do
expect(extract_results(@session)['description']).to eq("\r\nSome text\r\n")
end
it 'should handle carriage returns with line feeds in a textarea correct' do
it 'should handle carriage returns with line feeds in a textarea correctly' do
@session.fill_in('form_description', with: "\r\nSome text\r\n")
@session.click_button('awesome')
expect(extract_results(@session)['description']).to eq("\r\nSome text\r\n")

2
lib/capybara/spec/session/node_spec.rb
View file

@ -1184,7 +1184,7 @@ Capybara::SpecHelper.spec 'node' do
@session.visit('/with_shadow')
expect do
shadow_root = @session.find(:css, '#shadow_host').shadow_root
expect(shadow_root).not_to be_nil
expect(shadow_root).to be_a(Capybara::Node::Element)
end.not_to raise_error
end

12
spec/selenium_spec_firefox.rb
View file

@ -72,10 +72,14 @@ Capybara::SpecHelper.run_specs TestSessions::SeleniumFirefox, 'selenium', capyba
when 'Capybara::Session selenium #accept_alert should handle the alert if the page changes',
'Capybara::Session selenium #accept_alert with an asynchronous alert should accept the alert'
skip 'No clue what Firefox is doing here - works fine on MacOS locally'
when 'Capybara::Session selenium node #shadow_root should get the shadow root',
'Capybara::Session selenium node #shadow_root should find elements inside the shadow dom using CSS',
'Capybara::Session selenium node #shadow_root should find nested shadow roots'
pending "Firefox doesn't yet have W3C shadow root support"
when 'Capybara::Session selenium node #shadow_root should find elements inside the shadow dom using CSS',
'Capybara::Session selenium node #shadow_root should find nested shadow roots',
'Capybara::Session selenium node #shadow_root should click on elements',
'Capybara::Session selenium node #shadow_root should use convenience methods once moved to a descendant of the shadow root'
'Capybara::Session with firefox with selenium driver #evaluate_script returns a shadow root'
pending "Firefox doesn't yet have full W3C shadow root support"
when 'Capybara::Session selenium #fill_in should handle carriage returns with line feeds in a textarea correctly'
pending "Not sure what firefox is doing here"
end
end

1
spec/shared_selenium_session.rb
View file

@ -281,6 +281,7 @@ RSpec.shared_examples 'Capybara::Session' do |session, mode|
end
it 'returns a shadow root' do
pending "Geckodriver doesn't fully support shadow root yet" if firefox?(session)
session.visit('/with_shadow')
shadow = session.find(:css, '#shadow_host')
element = session.evaluate_script('arguments[0].shadowRoot', shadow)