Cleanup JS and pend test on firefox remote
This commit is contained in:
parent
5a5782f3a7
commit
d60a0ee010
|
@ -394,8 +394,7 @@ module Capybara
|
|||
|
||||
CAPTURE_FILE_ELEMENT_SCRIPT = <<~'JS'
|
||||
document.addEventListener('click', function(e){
|
||||
console.log(e);
|
||||
if ((e.target.nodeName == 'INPUT') && (e.target['type'] == 'file')) {
|
||||
if (e.target.matches("input[type='file']")) {
|
||||
window._capybara_clicked_file_input = e.target;
|
||||
e.preventDefault();
|
||||
}
|
||||
|
|
|
@ -65,7 +65,7 @@ Capybara::SpecHelper.run_specs TestSessions::SeleniumFirefox, 'selenium', capyba
|
|||
when 'Capybara::Session selenium #reset_session! removes ALL cookies'
|
||||
pending "Geckodriver doesn't provide a way to remove cookies outside the current domain"
|
||||
when 'Capybara::Session selenium #attach_file with a block can upload by clicking the file input'
|
||||
pending "Geckodriver doesn't support clicking on file inputs"
|
||||
pending "Geckodriver doesn't allow clicking on file inputs"
|
||||
end
|
||||
end
|
||||
|
||||
|
|
|
@ -73,6 +73,8 @@ Capybara::SpecHelper.run_specs TestSessions::RemoteFirefox, FIREFOX_REMOTE_DRIVE
|
|||
when /#accept_confirm should work with nested modals$/
|
||||
# skip because this is timing based and hence flaky when set to pending
|
||||
skip 'Broken in FF 63 - https://bugzilla.mozilla.org/show_bug.cgi?id=1487358' if firefox_gte?(63, @session)
|
||||
when 'Capybara::Session selenium_firefox_remote #attach_file with a block can upload by clicking the file input'
|
||||
pending "Geckodriver doesn't allow clicking on file inputs"
|
||||
end
|
||||
end
|
||||
|
||||
|
|
Loading…
Reference in New Issue