cleanup some warnings

features/step_definitions/capybara_steps.rb

@@ -1,17 +1,17 @@
 # frozen_string_literal: true
-When /^I visit the (?:root|home) page$/ do
+When(/^I visit the (?:root|home) page$/) do
   visit('/')
 end
 
-Then /^I should see "([^"]*)"$/ do |text|
+Then(/^I should see "([^"]*)"$/) do |text|
   expect(page).to have_content(text)
 end
 
-Then /^Capybara should use the "([^"]*)" driver$/ do |driver|
+Then(/^Capybara should use the "([^"]*)" driver$/) do |driver|
   expect(Capybara.current_driver).to eq(driver.to_sym)
 end
 
-When /^I use a matcher that fails$/ do
+When(/^I use a matcher that fails$/) do
   begin
     expect(page).to have_css('h1#doesnotexist')
   rescue StandardError, RSpec::Expectations::ExpectationNotMetError => e
@@ -19,7 +19,7 @@ When /^I use a matcher that fails$/ do
   end
 end
 
-Then /^the failing exception should be nice$/ do
+Then(/^the failing exception should be nice$/) do
   expect(@error_message).to match %r(expected to find css \"h1#doesnotexist\")
 end
 

lib/capybara/queries/current_path_query.rb

@@ -29,7 +29,7 @@ module Capybara
         if @expected_path.is_a? Regexp
           @actual_path.match(@expected_path)
         else
-          ::Addressable::URI.parse(@expected_path) == Addressable::URI.parse(@actual_path)
+          ::Addressable::URI.parse(@expected_path) == ::Addressable::URI.parse(@actual_path)
         end
       end
 

lib/capybara/queries/selector_query.rb

@@ -42,7 +42,7 @@ module Capybara
 
       def description
         @description = String.new("#{label} #{locator.inspect}")
-        @description << " with#{" exact" if exact_text === true} text #{options[:text].inspect}" if options[:text]
+        @description << " with#{" exact" if exact_text == true} text #{options[:text].inspect}" if options[:text]
         @description << " with exact text #{options[:exact_text]}" if options[:exact_text].is_a?(String)
         @description << " with id #{options[:id]}" if options[:id]
         @description << " with classes #{Array(options[:class]).join(',')}]" if options[:class]
@@ -56,7 +56,7 @@ module Capybara
           regexp = if options[:text].is_a?(Regexp)
             options[:text]
           else
-            if exact_text === true
+            if exact_text == true
               "\\A#{Regexp.escape(options[:text].to_s)}\\z"
             else
               Regexp.escape(options[:text].to_s)
@@ -205,7 +205,7 @@ module Capybara
       end
 
       def exact_text
-        exact_text = options.fetch(:exact_text, Capybara.exact_text)
+        options.fetch(:exact_text, Capybara.exact_text)
       end
     end
   end

lib/capybara/selector.rb

@@ -8,12 +8,12 @@ Capybara::Selector::FilterSet.add(:_field) do
 
   describe do |options|
     desc, states = String.new, []
-    states << 'checked' if options[:checked] || (options[:unchecked] === false)
+    states << 'checked' if options[:checked] || (options[:unchecked] == false)
-    states << 'not checked' if options[:unchecked] || (options[:checked] === false)
+    states << 'not checked' if options[:unchecked] || (options[:checked] == false)
     states << 'disabled' if options[:disabled] == true
     desc << " that is #{states.join(' and ')}" unless states.empty?
     desc << " with the multiple attribute" if options[:multiple] == true
-    desc << " without the multiple attribute" if options[:multiple] === false
+    desc << " without the multiple attribute" if options[:multiple] == false
     desc
   end
 end

lib/capybara/session.rb

@@ -172,7 +172,7 @@ module Capybara
     #
     def current_path
       # Addressable parsing is more lenient than URI
-      uri = Addressable::URI.parse(current_url)
+      uri = ::Addressable::URI.parse(current_url)
 
       # If current_url ends up being nil, won't be able to call .path on a NilClass.
       return nil if uri.nil?

lib/capybara/spec/views/buttons.erb

@@ -1,4 +1,4 @@
-<%# frozen_string_literal: true %>
+
 <h1>Buttons</h1>
 <button>Click me!</button>
 <button id="click_me_123">Click me by id!</button>

lib/capybara/spec/views/fieldsets.erb

@@ -1,4 +1,4 @@
-<%# frozen_string_literal: true %>
+
 <form action="/form" method="post">
   <fieldset id="agent_fieldset">
     <legend>Agent</legend>

lib/capybara/spec/views/form.erb

@@ -1,4 +1,4 @@
-<%# frozen_string_literal: true %>
+
 <h1>Form</h1>
 
 <form action="/form" method="post">

lib/capybara/spec/views/frame_child.erb

@@ -1,4 +1,4 @@
-<%# frozen_string_literal: true %>
+
 <html>
     <head>
         <title>This is the child frame title</title>

lib/capybara/spec/views/frame_one.erb

@@ -1,4 +1,4 @@
-<%# frozen_string_literal: true %>
+
 <html>
     <head>
         <title>This is the title of frame one</title>

lib/capybara/spec/views/frame_parent.erb

@@ -1,4 +1,4 @@
-<%# frozen_string_literal: true %>
+
 <html>
     <head>
         <title>This is the parent frame title</title>

lib/capybara/spec/views/frame_two.erb

@@ -1,4 +1,4 @@
-<%# frozen_string_literal: true %>
+
 <html>
     <head>
         <title>This is the title of frame two</title>

lib/capybara/spec/views/header_links.erb

@@ -1,4 +1,4 @@
-<%# frozen_string_literal: true %>
+
 <p>
   <a href="/get_header">Link</a>
 </p>

lib/capybara/spec/views/host_links.erb

@@ -1,4 +1,4 @@
-<%# frozen_string_literal: true %>
+
 <p>
   <a href="/host">Relative Host</a>
   <a href="<%= params[:absolute_host] %>/host">Absolute Host</a>

lib/capybara/spec/views/path.erb

@@ -1,4 +1,4 @@
-<%# frozen_string_literal: true %>
+
 <html xmlns="http://www.w3.org/1999/xhtml" lang="en">
   <body>
     <div>

lib/capybara/spec/views/popup_one.erb

@@ -1,4 +1,4 @@
-<%# frozen_string_literal: true %>
+
 <html>
     <head>
         <title>Title of the first popup</title>

lib/capybara/spec/views/popup_two.erb

@@ -1,4 +1,4 @@
-<%# frozen_string_literal: true %>
+
 <html>
     <head>
         <title>Title of popup two</title>

lib/capybara/spec/views/postback.erb

@@ -1,4 +1,4 @@
-<%# frozen_string_literal: true %>
+
 <h1>Postback</h1>
 
 <form method="get">

lib/capybara/spec/views/tables.erb

@@ -1,4 +1,4 @@
-<%# frozen_string_literal: true %>
+
 <form action="/form" method="post">
   <table id="agent_table">
     <caption>Agent</caption>

lib/capybara/spec/views/with_base_tag.erb

@@ -1,4 +1,4 @@
-<%# frozen_string_literal: true %>
+
 <html xmlns="http://www.w3.org/1999/xhtml" lang="en">
   <head>
     <meta http-equiv="Content-type" content="text/html; charset=utf-8"/>

lib/capybara/spec/views/with_count.erb

@@ -1,4 +1,4 @@
-<%# frozen_string_literal: true %>
+
 <h1>This page is used for testing number options of has_text?</h1>
 
 <p>count1</p>

lib/capybara/spec/views/with_hover.erb

@@ -1,4 +1,4 @@
-<%# frozen_string_literal: true %>
+
 <html xmlns="http://www.w3.org/1999/xhtml" lang="en">
   <head>
     <meta http-equiv="Content-type" content="text/html; charset=utf-8"/>

lib/capybara/spec/views/with_html.erb

@@ -1,4 +1,4 @@
-<%# frozen_string_literal: true %>
+
 <div id="referrer"><%= referrer %></div>
 <h1>This is a test</h1>
 

lib/capybara/spec/views/with_html_entities.erb

@@ -1,2 +1,2 @@
-<%# frozen_string_literal: true %>
+
 Encoding with &mdash; html entities &raquo;

lib/capybara/spec/views/with_js.erb

@@ -1,4 +1,4 @@
-<%# frozen_string_literal: true %>
+
 <html xmlns="http://www.w3.org/1999/xhtml" lang="en">
   <head>
     <meta http-equiv="Content-type" content="text/html; charset=utf-8"/>

lib/capybara/spec/views/with_scope.erb

@@ -1,4 +1,4 @@
-<%# frozen_string_literal: true %>
+
 <h1>This page is used for testing various scopes</h1>
 
 <p id="for_foo">

lib/capybara/spec/views/with_simple_html.erb

@@ -1,2 +1,2 @@
-<%# frozen_string_literal: true %>
+
 Bar

lib/capybara/spec/views/with_title.erb

@@ -1,4 +1,4 @@
-<%# frozen_string_literal: true %>
+
 <title>Test Title</title>
 <body>
   <svg><title>abcdefg</title></svg>

lib/capybara/spec/views/with_windows.erb

@@ -1,4 +1,4 @@
-<%# frozen_string_literal: true %>
+
 <html>
   <head>
     <title>With Windows</title>

lib/capybara/spec/views/within_frames.erb

@@ -1,4 +1,4 @@
-<%# frozen_string_literal: true %>
+
 <html>
     <head>
         <title>With Frames</title>