From ddc223cc4d6f8944d087617b9759d7c75fb0772c Mon Sep 17 00:00:00 2001 From: Thomas Walpole Date: Sat, 21 May 2022 14:14:59 -0700 Subject: [PATCH] Cleanup some test output --- lib/capybara/spec/session/has_text_spec.rb | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/lib/capybara/spec/session/has_text_spec.rb b/lib/capybara/spec/session/has_text_spec.rb index 6a1f165b..aca295a8 100644 --- a/lib/capybara/spec/session/has_text_spec.rb +++ b/lib/capybara/spec/session/has_text_spec.rb @@ -153,16 +153,12 @@ Capybara::SpecHelper.spec '#has_text?' do expect(@session).to have_text(42) end - it 'should be true when passed nil' do + it 'should be true when passed nil, and warn about it' do # nil is converted to '' when to_s is invoked @session.visit('/with_html') - expect(@session).to have_text(nil) - end - - it 'should warn when passed nil' do - @session.visit('/with_html') - expect_any_instance_of(Kernel).to receive(:warn).with(/Checking for expected text of nil is confusing/) # rubocop:disable RSpec/AnyInstance - expect(@session).to have_text(nil) + expect do + expect(@session).to have_text(nil) + end.to output(/Checking for expected text of nil is confusing/).to_stderr end it 'should wait for text to appear', requires: [:js] do