From e755161e135cbffd62621520a5538874d013ac21 Mon Sep 17 00:00:00 2001 From: Aleksei Gusev Date: Sun, 25 Mar 2018 19:51:18 +0300 Subject: [PATCH] Specify modals requirement for accept_alert tests --- spec/selenium_spec_edge.rb | 2 +- spec/shared_selenium_session.rb | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/spec/selenium_spec_edge.rb b/spec/selenium_spec_edge.rb index bac5f049..3ad086ab 100644 --- a/spec/selenium_spec_edge.rb +++ b/spec/selenium_spec_edge.rb @@ -20,7 +20,7 @@ $stdout.puts `#{Selenium::WebDriver::Edge.driver_path} --version` if ENV['CI'] Capybara::SpecHelper.run_specs TestSessions::SeleniumEdge, "selenium", capybara_skip: skipped_tests -RSpec.describe "Capybara::Session with Edge" do +RSpec.describe "Capybara::Session with Edge", capybara_skip: skipped_tests do include Capybara::SpecHelper include_examples "Capybara::Session", TestSessions::SeleniumEdge, :selenium_edge include_examples Capybara::RSpecMatchers, TestSessions::SeleniumEdge, :selenium_edge diff --git a/spec/shared_selenium_session.rb b/spec/shared_selenium_session.rb index edcd24f7..12770c92 100644 --- a/spec/shared_selenium_session.rb +++ b/spec/shared_selenium_session.rb @@ -55,7 +55,7 @@ RSpec.shared_examples "Capybara::Session" do |session, mode| end end - describe "#accept_alert" do + describe "#accept_alert", requires: [:modals] do it "supports a blockless mode" do @session.visit('/with_js') @session.click_link('Open alert') @@ -64,7 +64,6 @@ RSpec.shared_examples "Capybara::Session" do |session, mode| end it "can be called before visiting" do - skip "Edge driver doesn't get any interactions when alert is set" if edge?(@session) @session.accept_alert "Initial alert" do @session.visit('/initial_alert') end