1
0
Fork 0
mirror of https://github.com/teampoltergeist/poltergeist.git synced 2022-11-09 12:05:00 -05:00
Commit graph

23 commits

Author SHA1 Message Date
Jon Leighton
891ffd82ed Make the version detection code more robust
Closes #170
2012-10-06 16:17:41 +01:00
Jon Leighton
bdf584d37a require phantomjs 1.7 2012-10-05 00:36:53 +01:00
Jon Leighton
45c8b4396d use an options hash 2012-07-11 20:25:17 +01:00
Jon Leighton
e270c89d1d move inspector options into phantomjs_options 2012-07-11 20:14:17 +01:00
Jon Leighton
ad7e7b9efa fix steps and tidy a bit 2012-07-11 20:05:10 +01:00
wynst
2a9902d8c4 add phantomjs command-line options 2012-07-09 21:36:50 +07:00
Jon Leighton
3790f50811 bump phantomjs version requirement 2012-07-01 19:49:01 +01:00
Tom Stuart
0db1eb9767 Allow passing desired browser size as an option 2012-06-04 17:18:25 +02:00
Jon Leighton
ba107a65d8 Bump PhantomJS requirement to 1.5.0 2012-04-09 19:31:52 +01:00
Jon Leighton
98c3bb564f Remove posix-spawn dependency.
posix-spawn relies on a C extension. This does work under JRuby, but it
won't work on Travis CI as they disallow JRuby C extensions, as they are
considered to not be a good practice.

Instead we are using either Process.spawn on Ruby 1.9, or the
childprocess gem on Ruby 1.8. childprocess uses native JVM APIs on
JRuby, and fork+exec on others.
2012-03-11 10:35:02 +00:00
Jon Leighton
73ac614f14 Revert "Fix 1.8.7." (Removing the at_exit hook.)
I'm a bit stupid for not testing it, but Ruby does not automatically
reap the child processes, so without this we get lots of orphaned
processes. Not good!

sfl has been replaced with posix-spawn now anyway, so there is no
forking.

This reverts commit 47a310dbdd.
2012-02-29 22:58:59 +00:00
Jon Leighton
f61ca77cd4 Use posix-spawn gem rather than sfl, as sfl requires fork, which can't work on JRuby. 2012-02-29 22:52:27 +00:00
Jon Leighton
47a310dbdd Fix 1.8.7.
The sfl library uses fork { exec ... } which meant that the at_exit hook
got copied to child processes which would then kill other stuff.

I don't think the at_exit hook is necessary, given that Ruby will kill
child processes at exit, so just remove it.
2012-02-29 18:48:23 +00:00
Jon Leighton
9ac628841c don't explode when the child process is already dead 2012-02-29 18:15:28 +00:00
Jon Leighton
9f84f31b8f Add Driver#quit. Closes #24. 2012-02-29 13:51:17 +00:00
Jon Leighton
806a204697 Raise a better error when phantomjs returns a non-zero exit status. Fixes #23. 2012-02-29 11:44:05 +00:00
Jon Leighton
8d9b224de1 Extract inspector code to a separate class. Implement Driver#debug and Driver#pause methods for using inspector. 2012-02-29 00:02:43 +00:00
Jon Leighton
91d6198523 Experimental remote debugger support. 2012-02-25 12:47:18 +00:00
Jon Leighton
0d427a686b replace string with constant 2012-02-25 11:38:13 +00:00
Jon Leighton
3810618ea0 Check PhantomJS version from Ruby. Fixes #13. 2012-01-27 17:31:21 +00:00
Jon Leighton
d5c84b8c9a Remove error suppressing code - not needed for Qt 4.8 2012-01-03 23:43:43 +00:00
Jon Leighton
868c20b9a4 Implement client stuff using Kernel#spawn 2011-10-28 20:18:45 +01:00
Jon Leighton
76fe32debd omg 2011-10-27 23:34:14 +01:00