kotovalexarian-likes-github/therubyracer
1
0
Fork 0
mirror of https://github.com/rubyjs/therubyracer synced 2023-03-27 23:21:42 -04:00
Code Releases Activity

Add more handle documentation.

Browse source
This commit is contained in:
Charles Lowell 2011-06-24 13:17:39 -05:00
parent cc8ca3148d
commit 342ad808b3
2 changed files with 12 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
ext/v8/v8_handle.cpp
View file

@ -6,7 +6,9 @@ using namespace v8;
/** /**
* Creates a new Persistent storage cell for `handle` * Creates a new Persistent storage cell for `handle`
* so that we can reference it from Ruby. * so that we can reference it from Ruby. Ruby metadat
* is contained on the handle object, and then the actual
* v8 references are contain in an instance of `Payload`
*/ */
v8_handle::v8_handle(Handle<void> object) { v8_handle::v8_handle(Handle<void> object) {
this->weakref_callback = Qnil; this->weakref_callback = Qnil;
@ -17,6 +19,14 @@ v8_handle::v8_handle(Handle<void> object) {
v8_handle::~v8_handle() {} v8_handle::~v8_handle() {}
/**
* Construct a new handle payload.
*
* Each payload contains a Ruby object wrapper so that it
* can be enqueued for V8 GC (the GC queue is a ruby Array)
* the wrapper is pre-allocated at payload creation time
* so that no Ruby objects are allocated during Ruby GC.
*/
v8_handle::Payload::Payload(Handle<void> object) { v8_handle::Payload::Payload(Handle<void> object) {
rb_gc_register_address(&wrapper); rb_gc_register_address(&wrapper);
handle = Persistent<void>::New(object); handle = Persistent<void>::New(object);
@ -56,7 +66,7 @@ namespace {
/** /**
* Whenver a V8::C::Handle becomes garbage collected, we do not free it immediately. * Whenver a V8::C::Handle becomes garbage collected, we do not free it immediately.
* instead, we put them into a "zombie" queue, where its corresponding V8 storage cell * instead, we put them into a "zombie" queue, where its corresponding V8 storage cell
* can be released safely while the V8 engine is running. A zombie Ruby object is * can be released safely while the V8 engine is running. A zombie Ruby object is
* created to wrap it so that it can be stored in the queue. * created to wrap it so that it can be stored in the queue.
*/ */
void v8_handle_enqueue(v8_handle* handle) { void v8_handle_enqueue(v8_handle* handle) {

1
ext/v8/v8_handle.h
View file

@ -7,7 +7,6 @@
/** /**
* Holds a reference to a V8 heap object. This serves as the base * Holds a reference to a V8 heap object. This serves as the base
* class for all of the low-level proxies that reference into V8. * class for all of the low-level proxies that reference into V8.
*
*/ */
struct v8_handle { struct v8_handle {