From 4b7edae271033f51f3760a2cba4959048227c5e7 Mon Sep 17 00:00:00 2001 From: Charles Lowell Date: Sun, 5 Jul 2015 19:53:17 -0500 Subject: [PATCH] don't create handle scope in context creation --- ext/v8/context.cc | 1 - spec/c/context_spec.rb | 5 +++++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/ext/v8/context.cc b/ext/v8/context.cc index 25a425a..c2e4bdc 100644 --- a/ext/v8/context.cc +++ b/ext/v8/context.cc @@ -24,7 +24,6 @@ namespace rr { Isolate isolate(rb_isolate); Locker lock(isolate); - v8::HandleScope handle_scope(isolate); return Context(v8::Context::New( isolate // TODO diff --git a/spec/c/context_spec.rb b/spec/c/context_spec.rb index e0f6ed3..0229140 100644 --- a/spec/c/context_spec.rb +++ b/spec/c/context_spec.rb @@ -3,6 +3,11 @@ require 'c_spec_helper' describe V8::C::Context do let(:isolate) { V8::C::Isolate::New() } let(:context) { V8::C::Context::New(isolate) } + around do |example| + V8::C::HandleScope(isolate) do + example.run + end + end it "can be instantiated" do expect(context).to be