kotovalexarian-likes-github/therubyracer
1
0
Fork 0
mirror of https://github.com/rubyjs/therubyracer synced 2023-03-27 23:21:42 -04:00
Code Releases Activity

properly report source:line:column on SyntaxErrors.

Browse source
This commit is contained in:
Charles Lowell 2010-11-09 09:43:25 -06:00
parent 22727d1e4a
commit 59ac87f37d
3 changed files with 44 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

3
ext/v8/v8_msg.cpp
View file

@ -24,7 +24,8 @@ namespace {
}
VALUE GetStackTrace(VALUE self) {
return rr_v82rb(unwrap(self)->GetStackTrace());
Handle<StackTrace> trace = unwrap(self)->GetStackTrace();
return trace.IsEmpty() ? Qnil : rr_v82rb(trace);
}
VALUE GetLineNumber(VALUE self) {

23
lib/v8/error.rb
View file

@ -41,7 +41,6 @@ module V8
else
@value = ex
message = ex.to_s
@boundaries.first.jsframes << 'at [???].js'
end
return message
end
@ -88,13 +87,31 @@ module V8
end
def parse_js_frames(try)
#I can't figure out why V8 is not capturing the stacktrace here
#in terms of StackTrace and StackFrame objects, so we have to
#parse the string.
raw = @to.rb(try.StackTrace())
if raw && !raw.empty?
if raw && !raw.empty? && !syntax_error?(try)
raw.split("\n")[1..-1].tap do |frames|
frames.each {|frame| frame.strip!.chomp!(",")}
end
else
[]
msg = try.Message()
["at #{@to.rb(msg.GetScriptResourceName())}:#{msg.GetLineNumber()}:#{msg.GetStartColumn() + 1}"]
end
end
#Syntax errors are weird in that they have a non-empty stack trace
#but it does not contain any source location information, so
#in these instances, we have to pull it out of the Message object
#in the TryCatch. Is there a better way to detect a syntax error
def syntax_error?(try)
ex = try.Exception()
if ex && ex.kind_of?(V8::C::Object)
type = ex.Get("constructor")
type && type.kind_of?(V8::C::Function) && type.GetName().AsciiValue == "SyntaxError"
else
false
end
end

15
spec/v8/error_spec.rb
View file

@ -89,10 +89,23 @@ describe V8::JSError do
it "includes a mystery marker when the original frame is unavailable because what got thrown wasn't an error" do
throw!("6") do |e|
e.backtrace.first.should == 'at [???].js'
e.backtrace.first.should == 'at three.js:1:1'
end
end
it "has a source name and line number when there is a javascript SyntaxError" do
lambda do
@cxt.eval(<<-INVALID, 'source.js')
"this line is okay";
"this line has a syntax error because it ends with a colon":
"this line is also okay";
"how do I find out that line 2 has the syntax error?";
INVALID
end.should raise_error(V8::JSError) {|error|
error.backtrace.first.should == 'at source.js:2:60'
}
end
it "can start with ruby at the bottom" do
@cxt['boom'] = lambda do
raise StandardError, "Bif!"