kotovalexarian-likes-github/thoughtbot--factory_bot
1
0
Fork 0
mirror of https://github.com/thoughtbot/factory_bot.git synced 2022-11-09 11:43:51 -05:00
Code Releases Activity
thoughtbot--factory_bot/lib/factory_bot.rb

126 lines
3.9 KiB
Ruby
Raw Normal View History

Rubocop: Fix Style/StringLiterals Offenses (#1216)
2018-10-07 21:45:51 -04:00
require "set"
require "active_support/core_ext/module/delegation"
Do not reset use_parent_strategy on reload Before this PR, `use_parent_strategy` was set on the configuration instance. Since `FactoryBot.reload` wipes out the configuration, it also ends up resetting `use_parent_strategy` back to `nil`. This can cause problems when using factory_bot_rails with Spring, since it calls `FactoryBot.reload` each time Spring forks. If `use_parent_strategy` is set in a file that Spring preloads, like in an initializer, then the value will get wiped out. With this PR, we set `use_parent_strategy` directly on FactoryBot, rather than on the configuration instance, and so reloading no longer has any effect.
2019-01-02 21:16:23 -05:00
require "active_support/core_ext/module/attribute_accessors"
Rubocop: Fix Style/StringLiterals Offenses (#1216)
2018-10-07 21:45:51 -04:00
require "active_support/deprecation"
require "active_support/notifications"
Replace 'girl' with 'bot' everywhere (#1051) Also: add a deprecation warning to factory_girl, asking users to switch to factory_bot https://github.com/thoughtbot/factory_girl/issues/921
2017-10-20 15:20:28 -04:00
Rubocop: Fix Style/StringLiterals Offenses (#1216)
2018-10-07 21:45:51 -04:00
require "factory_bot/definition_hierarchy"
require "factory_bot/configuration"
require "factory_bot/errors"
require "factory_bot/factory_runner"
require "factory_bot/strategy_syntax_method_registrar"
require "factory_bot/strategy_calculator"
require "factory_bot/strategy/build"
require "factory_bot/strategy/create"
require "factory_bot/strategy/attributes_for"
require "factory_bot/strategy/stub"
require "factory_bot/strategy/null"
require "factory_bot/registry"
require "factory_bot/null_factory"
require "factory_bot/null_object"
require "factory_bot/evaluation"
require "factory_bot/factory"
require "factory_bot/attribute_assigner"
require "factory_bot/evaluator"
require "factory_bot/evaluator_class_definer"
require "factory_bot/attribute"
require "factory_bot/callback"
require "factory_bot/callbacks_observer"
require "factory_bot/declaration_list"
require "factory_bot/declaration"
require "factory_bot/sequence"
require "factory_bot/attribute_list"
require "factory_bot/trait"
require "factory_bot/aliases"
require "factory_bot/definition"
require "factory_bot/definition_proxy"
require "factory_bot/syntax"
require "factory_bot/syntax_runner"
require "factory_bot/find_definitions"
require "factory_bot/reload"
require "factory_bot/decorator"
require "factory_bot/decorator/attribute_hash"
require "factory_bot/decorator/disallows_duplicates_registry"
require "factory_bot/decorator/invocation_tracker"
require "factory_bot/decorator/new_constructor"
require "factory_bot/linter"
require "factory_bot/version"
Introduce FactoryBot::Internal module The `FactoryBot` module has a mixture of methods that are meant for use by people using the library, and methods that are meant only for internal use. The methods meant for internal use are cluttering the documentation, and may be confusing to users. This change was prompted by [#1258]. Rather than introduce yet another public method on `FactoryBot` meant only for internal use, we can introduce a `FactoryBot::Internal` module, and avoid generating documentation for that module. The `FactoryBot::Internal.register_inline_sequence` method in [#1258] will need access to the configuration instance, so this PR moves that into `FactoryBot::Internal`. Eventually I plan to deprecate `FactoryBot.configuration` and `FactoryBot.reset_configuration`, and to move more of the `FactoryBot` methods into `FactoryBot::Internal`, but I would rather hold off on all that until the dust settles on the 5.0 release. [#1258]: https://github.com/thoughtbot/factory_bot/pull/1258
2019-02-11 19:16:56 -05:00
require "factory_bot/internal"
Replace 'girl' with 'bot' everywhere (#1051) Also: add a deprecation warning to factory_girl, asking users to switch to factory_bot https://github.com/thoughtbot/factory_girl/issues/921
2017-10-20 15:20:28 -04:00
module FactoryBot
Move and deprecate trait methods from FactoryBot Why: These are essentially internal methods that should not be publicly available from the base namespace. One thing worth noticing is that the use of this methods internally was almost exclusively in the `syntax/default` except for one use on the `factory_bot/definition`. Also the deprecation silencing module was referring to the singleton instance of the ```ActiveRecord::Deprecation``` class and not to the new deprecation instance that was being used in the ```FactoryBot``` module. This PR: - Moves the `trait_by_name` and `register_trait` into the `FactoryBot::Internal` module - Deprecates uses of `trait_by_name`, `register_trait` and `traits` from the `FactoryBot` module. - Rename DEPRECATOR => Deprecation This is one of the steps towards fixing [this issue](https://github.com/thoughtbot/factory_bot/issues/1281)
2019-04-19 16:01:32 -04:00
Deprecation = ActiveSupport::Deprecation.new("6.0", "factory_bot")
Deprecate allow_class_lookup I removed allow_class_lookup entirely in 2e0b476 when removing the deprecated ability to lookup factories by class. But the upgrade to fb 5 will be a bit more smooth if we deprecate the method first.
2019-01-05 21:19:04 -05:00
Replace 'girl' with 'bot' everywhere (#1051) Also: add a deprecation warning to factory_girl, asking users to switch to factory_bot https://github.com/thoughtbot/factory_girl/issues/921
2017-10-20 15:20:28 -04:00
def self.configuration
Introduce FactoryBot::Internal module The `FactoryBot` module has a mixture of methods that are meant for use by people using the library, and methods that are meant only for internal use. The methods meant for internal use are cluttering the documentation, and may be confusing to users. This change was prompted by [#1258]. Rather than introduce yet another public method on `FactoryBot` meant only for internal use, we can introduce a `FactoryBot::Internal` module, and avoid generating documentation for that module. The `FactoryBot::Internal.register_inline_sequence` method in [#1258] will need access to the configuration instance, so this PR moves that into `FactoryBot::Internal`. Eventually I plan to deprecate `FactoryBot.configuration` and `FactoryBot.reset_configuration`, and to move more of the `FactoryBot` methods into `FactoryBot::Internal`, but I would rather hold off on all that until the dust settles on the 5.0 release. [#1258]: https://github.com/thoughtbot/factory_bot/pull/1258
2019-02-11 19:16:56 -05:00
Internal.configuration
Replace 'girl' with 'bot' everywhere (#1051) Also: add a deprecation warning to factory_girl, asking users to switch to factory_bot https://github.com/thoughtbot/factory_girl/issues/921
2017-10-20 15:20:28 -04:00
end
def self.reset_configuration
Introduce FactoryBot::Internal module The `FactoryBot` module has a mixture of methods that are meant for use by people using the library, and methods that are meant only for internal use. The methods meant for internal use are cluttering the documentation, and may be confusing to users. This change was prompted by [#1258]. Rather than introduce yet another public method on `FactoryBot` meant only for internal use, we can introduce a `FactoryBot::Internal` module, and avoid generating documentation for that module. The `FactoryBot::Internal.register_inline_sequence` method in [#1258] will need access to the configuration instance, so this PR moves that into `FactoryBot::Internal`. Eventually I plan to deprecate `FactoryBot.configuration` and `FactoryBot.reset_configuration`, and to move more of the `FactoryBot` methods into `FactoryBot::Internal`, but I would rather hold off on all that until the dust settles on the 5.0 release. [#1258]: https://github.com/thoughtbot/factory_bot/pull/1258
2019-02-11 19:16:56 -05:00
Internal.reset_configuration
Replace 'girl' with 'bot' everywhere (#1051) Also: add a deprecation warning to factory_girl, asking users to switch to factory_bot https://github.com/thoughtbot/factory_girl/issues/921
2017-10-20 15:20:28 -04:00
end
Set use_parent_strategy default to true explicitly The `default:` option of `mattr_accessor` wasn't added until Rails 5.2, which means it has no effect on older versions and the default value of `FactoryBot.use_parent_strategy` in 5.0.0.rc1 is nil on those versions.
2019-01-11 01:39:39 -05:00
mattr_accessor :use_parent_strategy, instance_accessor: false
self.use_parent_strategy = true
Do not reset use_parent_strategy on reload Before this PR, `use_parent_strategy` was set on the configuration instance. Since `FactoryBot.reload` wipes out the configuration, it also ends up resetting `use_parent_strategy` back to `nil`. This can cause problems when using factory_bot_rails with Spring, since it calls `FactoryBot.reload` each time Spring forks. If `use_parent_strategy` is set in a file that Spring preloads, like in an initializer, then the value will get wiped out. With this PR, we set `use_parent_strategy` directly on FactoryBot, rather than on the configuration instance, and so reloading no longer has any effect.
2019-01-02 21:16:23 -05:00
Replace 'girl' with 'bot' everywhere (#1051) Also: add a deprecation warning to factory_girl, asking users to switch to factory_bot https://github.com/thoughtbot/factory_girl/issues/921
2017-10-20 15:20:28 -04:00
# Look for errors in factories and (optionally) their traits.
# Parameters:
# factories - which factories to lint; omit for all factories
# options:
# traits: true - to lint traits as well as factories
# strategy: :create - to specify the strategy for linting
Add option for verbose linting This has come up a few times, and I can see why it might be helpful to have access to full backtraces when debugging a factory error uncovered by `FactoryBot.lint`. But since most of the time I don't want the extra noise from the backtrace, I added this as a verbose option. The default message is still: ``` The following factories are invalid: * user - undefined method `save!' for #<User:0x00007ff0cbc89100> * admin - undefined method `save!' for #<User:0x00007ff0cbc73e40> ``` And with the verbose option (usually with more lines of backtrace): ``` The following factories are invalid: * user - undefined method `save!' for #<User:0x00007ff0cbc89100> /Users/.../thoughtbot/factory_bot/lib/factory_bot/evaluation.rb:18:in `create' /Users/.../factory_bot/lib/factory_bot/strategy/create.rb:12:in `block in result' * admin - undefined method `save!' for #<User:0x00007ff0cbc73e40> /Users/.../thoughtbot/factory_bot/lib/factory_bot/evaluation.rb:18:in `create' /Users/.../factory_bot/lib/factory_bot/strategy/create.rb:12:in `block in result' ``` I moved the linting option defaults out of the FactoryBot.lint method and into keyword argument defaults in Linter#initialize. This seems a bit cleaner, and now we will get an error if we pass an option we don't understand (before 6e511597 we had a test that passed in a bogus option) Closes #710 Closes #1124 I am opening a new PR since the original PR is years old and it seemed unkind to request changes after so long. Instead I will list the authors as co-authors. Co-authored-by: Jack Kinsella <jack.kinsella@gmail.com> Co-authored-by: Jasper Woudenberg <mail@jasperwoudenberg.com>
2018-11-21 15:28:28 -05:00
# verbose: true - to include full backtraces for each linting error
Replace 'girl' with 'bot' everywhere (#1051) Also: add a deprecation warning to factory_girl, asking users to switch to factory_bot https://github.com/thoughtbot/factory_girl/issues/921
2017-10-20 15:20:28 -04:00
def self.lint(*args)
options = args.extract_options!
factories_to_lint = args[0] || FactoryBot.factories
Fix deprecation warning on linter.rb (#1364)
2020-01-10 17:25:27 -05:00
Linter.new(factories_to_lint, **options).lint!
Replace 'girl' with 'bot' everywhere (#1051) Also: add a deprecation warning to factory_girl, asking users to switch to factory_bot https://github.com/thoughtbot/factory_girl/issues/921
2017-10-20 15:20:28 -04:00
end
class << self
Deprecate and move to Internal factories methods Why: These methods are used internally for the functionality of the library and are subject to change. Therefore shouldn't be part of the public interface. This PR: - Moves the ```register_factory``` and ```factory_by_name``` methods to the ```FactoryBot::Internal``` class. - Deprecates the use of ```register_factory``` and ```factory_by_name``` from the ```FactoryBot``` module. - Improve formatting of the specs
2019-04-26 15:48:37 -04:00
delegate :callbacks,
:callback_names,
:constructor,
:factories,
:initialize_with,
Replace 'girl' with 'bot' everywhere (#1051) Also: add a deprecation warning to factory_girl, asking users to switch to factory_bot https://github.com/thoughtbot/factory_girl/issues/921
2017-10-20 15:20:28 -04:00
:sequences,
Deprecate and move to Internal factories methods Why: These methods are used internally for the functionality of the library and are subject to change. Therefore shouldn't be part of the public interface. This PR: - Moves the ```register_factory``` and ```factory_by_name``` methods to the ```FactoryBot::Internal``` class. - Deprecates the use of ```register_factory``` and ```factory_by_name``` from the ```FactoryBot``` module. - Improve formatting of the specs
2019-04-26 15:48:37 -04:00
:skip_create,
Replace 'girl' with 'bot' everywhere (#1051) Also: add a deprecation warning to factory_girl, asking users to switch to factory_bot https://github.com/thoughtbot/factory_girl/issues/921
2017-10-20 15:20:28 -04:00
:strategies,
:to_create,
Deprecate and move to Internal factories methods Why: These methods are used internally for the functionality of the library and are subject to change. Therefore shouldn't be part of the public interface. This PR: - Moves the ```register_factory``` and ```factory_by_name``` methods to the ```FactoryBot::Internal``` class. - Deprecates the use of ```register_factory``` and ```factory_by_name``` from the ```FactoryBot``` module. - Improve formatting of the specs
2019-04-26 15:48:37 -04:00
:traits,
Replace 'girl' with 'bot' everywhere (#1051) Also: add a deprecation warning to factory_girl, asking users to switch to factory_bot https://github.com/thoughtbot/factory_girl/issues/921
2017-10-20 15:20:28 -04:00
to: :configuration
Deprecate allow_class_lookup I removed allow_class_lookup entirely in 2e0b476 when removing the deprecated ability to lookup factories by class. But the upgrade to fb 5 will be a bit more smooth if we deprecate the method first.
2019-01-05 21:19:04 -05:00
Deprecate and move to Internal factories methods Why: These methods are used internally for the functionality of the library and are subject to change. Therefore shouldn't be part of the public interface. This PR: - Moves the ```register_factory``` and ```factory_by_name``` methods to the ```FactoryBot::Internal``` class. - Deprecates the use of ```register_factory``` and ```factory_by_name``` from the ```FactoryBot``` module. - Improve formatting of the specs
2019-04-26 15:48:37 -04:00
delegate :factory_by_name,
Deprecate/Move strategies and callback methods Why: These methods are used internally for the functionality of the library and are subject to change. Therefore shouldn't be part of the public interface. This PR: - Moves the ```register_strategy```, ```register_callback```, ```register_default_factories```, ```register_default_callbacks``` ```strategies```, ```callback_names``` and ```strategy_by_name``` methods to the ```FactoryBot::Internal``` class. - Deprecates the use of ```register_callback``` from the ```FactoryBot``` module.
2019-04-26 15:48:37 -04:00
:register_callback,
:register_default_callbacks,
:register_default_strategies,
Deprecate and move to Internal factories methods Why: These methods are used internally for the functionality of the library and are subject to change. Therefore shouldn't be part of the public interface. This PR: - Moves the ```register_factory``` and ```factory_by_name``` methods to the ```FactoryBot::Internal``` class. - Deprecates the use of ```register_factory``` and ```factory_by_name``` from the ```FactoryBot``` module. - Improve formatting of the specs
2019-04-26 15:48:37 -04:00
:register_factory,
:register_sequence,
Deprecate/Move strategies and callback methods Why: These methods are used internally for the functionality of the library and are subject to change. Therefore shouldn't be part of the public interface. This PR: - Moves the ```register_strategy```, ```register_callback```, ```register_default_factories```, ```register_default_callbacks``` ```strategies```, ```callback_names``` and ```strategy_by_name``` methods to the ```FactoryBot::Internal``` class. - Deprecates the use of ```register_callback``` from the ```FactoryBot``` module.
2019-04-26 15:48:37 -04:00
:register_strategy,
Move and deprecate trait methods from FactoryBot Why: These are essentially internal methods that should not be publicly available from the base namespace. One thing worth noticing is that the use of this methods internally was almost exclusively in the `syntax/default` except for one use on the `factory_bot/definition`. Also the deprecation silencing module was referring to the singleton instance of the ```ActiveRecord::Deprecation``` class and not to the new deprecation instance that was being used in the ```FactoryBot``` module. This PR: - Moves the `trait_by_name` and `register_trait` into the `FactoryBot::Internal` module - Deprecates uses of `trait_by_name`, `register_trait` and `traits` from the `FactoryBot` module. - Rename DEPRECATOR => Deprecation This is one of the steps towards fixing [this issue](https://github.com/thoughtbot/factory_bot/issues/1281)
2019-04-19 16:01:32 -04:00
:register_trait,
Deprecate and move to Internal sequence methods Why: Another run of internal methods that should not be publicly available from the base namespace. This time the sequence involving methods were moved. It's worth noticing that the ```Internal``` class is getting crowded. Maybe we can start name-spacing the internal groups into modules under ```internal/sequence.rb``` ```internal/trait.rb``` and so on. Thoughts? This PR: - Moves the ```register_sequence```, ```sequence_by_name```, ```sequences``` and ```rewind_sequences``` to the ```FactoryBot::Internal``` module. - Deprecates uses of ```sequence_by_name```, and ```sequences``` from the ```FactoryBot``` module. - Refactor rewind sequences test to use spies This is one of the steps towards fixing [this issue](https://github.com/thoughtbot/factory_bot/pull/1285#1281)
2019-04-26 15:48:37 -04:00
:rewind_sequences,
:sequence_by_name,
Deprecate/Move strategies and callback methods Why: These methods are used internally for the functionality of the library and are subject to change. Therefore shouldn't be part of the public interface. This PR: - Moves the ```register_strategy```, ```register_callback```, ```register_default_factories```, ```register_default_callbacks``` ```strategies```, ```callback_names``` and ```strategy_by_name``` methods to the ```FactoryBot::Internal``` class. - Deprecates the use of ```register_callback``` from the ```FactoryBot``` module.
2019-04-26 15:48:37 -04:00
:strategy_by_name,
Deprecate and move to Internal sequence methods Why: Another run of internal methods that should not be publicly available from the base namespace. This time the sequence involving methods were moved. It's worth noticing that the ```Internal``` class is getting crowded. Maybe we can start name-spacing the internal groups into modules under ```internal/sequence.rb``` ```internal/trait.rb``` and so on. Thoughts? This PR: - Moves the ```register_sequence```, ```sequence_by_name```, ```sequences``` and ```rewind_sequences``` to the ```FactoryBot::Internal``` module. - Deprecates uses of ```sequence_by_name```, and ```sequences``` from the ```FactoryBot``` module. - Refactor rewind sequences test to use spies This is one of the steps towards fixing [this issue](https://github.com/thoughtbot/factory_bot/pull/1285#1281)
2019-04-26 15:48:37 -04:00
:trait_by_name,
Move and deprecate trait methods from FactoryBot Why: These are essentially internal methods that should not be publicly available from the base namespace. One thing worth noticing is that the use of this methods internally was almost exclusively in the `syntax/default` except for one use on the `factory_bot/definition`. Also the deprecation silencing module was referring to the singleton instance of the ```ActiveRecord::Deprecation``` class and not to the new deprecation instance that was being used in the ```FactoryBot``` module. This PR: - Moves the `trait_by_name` and `register_trait` into the `FactoryBot::Internal` module - Deprecates uses of `trait_by_name`, `register_trait` and `traits` from the `FactoryBot` module. - Rename DEPRECATOR => Deprecation This is one of the steps towards fixing [this issue](https://github.com/thoughtbot/factory_bot/issues/1281)
2019-04-19 16:01:32 -04:00
to: Internal
Deprecate allow_class_lookup I removed allow_class_lookup entirely in 2e0b476 when removing the deprecated ability to lookup factories by class. But the upgrade to fb 5 will be a bit more smooth if we deprecate the method first.
2019-01-05 21:19:04 -05:00
attr_accessor :allow_class_lookup
Move and deprecate trait methods from FactoryBot Why: These are essentially internal methods that should not be publicly available from the base namespace. One thing worth noticing is that the use of this methods internally was almost exclusively in the `syntax/default` except for one use on the `factory_bot/definition`. Also the deprecation silencing module was referring to the singleton instance of the ```ActiveRecord::Deprecation``` class and not to the new deprecation instance that was being used in the ```FactoryBot``` module. This PR: - Moves the `trait_by_name` and `register_trait` into the `FactoryBot::Internal` module - Deprecates uses of `trait_by_name`, `register_trait` and `traits` from the `FactoryBot` module. - Rename DEPRECATOR => Deprecation This is one of the steps towards fixing [this issue](https://github.com/thoughtbot/factory_bot/issues/1281)
2019-04-19 16:01:32 -04:00
deprecate :allow_class_lookup,
:allow_class_lookup=,
Deprecate/Move strategies and callback methods Why: These methods are used internally for the functionality of the library and are subject to change. Therefore shouldn't be part of the public interface. This PR: - Moves the ```register_strategy```, ```register_callback```, ```register_default_factories```, ```register_default_callbacks``` ```strategies```, ```callback_names``` and ```strategy_by_name``` methods to the ```FactoryBot::Internal``` class. - Deprecates the use of ```register_callback``` from the ```FactoryBot``` module.
2019-04-26 15:48:37 -04:00
:callback_names,
Deprecate and move to Internal factories methods Why: These methods are used internally for the functionality of the library and are subject to change. Therefore shouldn't be part of the public interface. This PR: - Moves the ```register_factory``` and ```factory_by_name``` methods to the ```FactoryBot::Internal``` class. - Deprecates the use of ```register_factory``` and ```factory_by_name``` from the ```FactoryBot``` module. - Improve formatting of the specs
2019-04-26 15:48:37 -04:00
:factory_by_name,
Deprecate/Move strategies and callback methods Why: These methods are used internally for the functionality of the library and are subject to change. Therefore shouldn't be part of the public interface. This PR: - Moves the ```register_strategy```, ```register_callback```, ```register_default_factories```, ```register_default_callbacks``` ```strategies```, ```callback_names``` and ```strategy_by_name``` methods to the ```FactoryBot::Internal``` class. - Deprecates the use of ```register_callback``` from the ```FactoryBot``` module.
2019-04-26 15:48:37 -04:00
:register_callback,
:register_default_callbacks,
:register_default_strategies,
Deprecate and move to Internal factories methods Why: These methods are used internally for the functionality of the library and are subject to change. Therefore shouldn't be part of the public interface. This PR: - Moves the ```register_factory``` and ```factory_by_name``` methods to the ```FactoryBot::Internal``` class. - Deprecates the use of ```register_factory``` and ```factory_by_name``` from the ```FactoryBot``` module. - Improve formatting of the specs
2019-04-26 15:48:37 -04:00
:register_factory,
Move and deprecate trait methods from FactoryBot Why: These are essentially internal methods that should not be publicly available from the base namespace. One thing worth noticing is that the use of this methods internally was almost exclusively in the `syntax/default` except for one use on the `factory_bot/definition`. Also the deprecation silencing module was referring to the singleton instance of the ```ActiveRecord::Deprecation``` class and not to the new deprecation instance that was being used in the ```FactoryBot``` module. This PR: - Moves the `trait_by_name` and `register_trait` into the `FactoryBot::Internal` module - Deprecates uses of `trait_by_name`, `register_trait` and `traits` from the `FactoryBot` module. - Rename DEPRECATOR => Deprecation This is one of the steps towards fixing [this issue](https://github.com/thoughtbot/factory_bot/issues/1281)
2019-04-19 16:01:32 -04:00
:register_trait,
Deprecate and move to Internal sequence methods Why: Another run of internal methods that should not be publicly available from the base namespace. This time the sequence involving methods were moved. It's worth noticing that the ```Internal``` class is getting crowded. Maybe we can start name-spacing the internal groups into modules under ```internal/sequence.rb``` ```internal/trait.rb``` and so on. Thoughts? This PR: - Moves the ```register_sequence```, ```sequence_by_name```, ```sequences``` and ```rewind_sequences``` to the ```FactoryBot::Internal``` module. - Deprecates uses of ```sequence_by_name```, and ```sequences``` from the ```FactoryBot``` module. - Refactor rewind sequences test to use spies This is one of the steps towards fixing [this issue](https://github.com/thoughtbot/factory_bot/pull/1285#1281)
2019-04-26 15:48:37 -04:00
:sequence_by_name,
:sequences,
Deprecate/Move strategies and callback methods Why: These methods are used internally for the functionality of the library and are subject to change. Therefore shouldn't be part of the public interface. This PR: - Moves the ```register_strategy```, ```register_callback```, ```register_default_factories```, ```register_default_callbacks``` ```strategies```, ```callback_names``` and ```strategy_by_name``` methods to the ```FactoryBot::Internal``` class. - Deprecates the use of ```register_callback``` from the ```FactoryBot``` module.
2019-04-26 15:48:37 -04:00
:strategies,
Move and deprecate trait methods from FactoryBot Why: These are essentially internal methods that should not be publicly available from the base namespace. One thing worth noticing is that the use of this methods internally was almost exclusively in the `syntax/default` except for one use on the `factory_bot/definition`. Also the deprecation silencing module was referring to the singleton instance of the ```ActiveRecord::Deprecation``` class and not to the new deprecation instance that was being used in the ```FactoryBot``` module. This PR: - Moves the `trait_by_name` and `register_trait` into the `FactoryBot::Internal` module - Deprecates uses of `trait_by_name`, `register_trait` and `traits` from the `FactoryBot` module. - Rename DEPRECATOR => Deprecation This is one of the steps towards fixing [this issue](https://github.com/thoughtbot/factory_bot/issues/1281)
2019-04-19 16:01:32 -04:00
:trait_by_name,
:traits,
deprecator: Deprecation
Replace 'girl' with 'bot' everywhere (#1051) Also: add a deprecation warning to factory_girl, asking users to switch to factory_bot https://github.com/thoughtbot/factory_girl/issues/921
2017-10-20 15:20:28 -04:00
end
end
Deprecate/Move strategies and callback methods Why: These methods are used internally for the functionality of the library and are subject to change. Therefore shouldn't be part of the public interface. This PR: - Moves the ```register_strategy```, ```register_callback```, ```register_default_factories```, ```register_default_callbacks``` ```strategies```, ```callback_names``` and ```strategy_by_name``` methods to the ```FactoryBot::Internal``` class. - Deprecates the use of ```register_callback``` from the ```FactoryBot``` module.
2019-04-26 15:48:37 -04:00
FactoryBot::Internal.register_default_strategies
FactoryBot::Internal.register_default_callbacks
Copy permalink