kotovalexarian-likes-github/thoughtbot--factory_bot
1
0
Fork 0
mirror of https://github.com/thoughtbot/factory_bot.git synced 2022-11-09 11:43:51 -05:00
Code Releases Activity
thoughtbot--factory_bot/.rubocop.yml

29 lines
618 B
YAML
Raw Normal View History

Add rubocop to run rubocop locally and not to wait for HoundCI to bark at us. The version is locked to 0.54 because this is the version HoundCI is using. Using a newer version will not work as config changed from 0.54 to currently 0.59 and rubocop would complain with the old configuration. thoughtbot uses the .rubocop.yml in thoughtbot/guides as the orginizational config on Hound, so we inherit from it so we can use the same config locally. Fix #1195.
2018-09-15 10:16:10 -04:00
inherit_from:
- https://raw.githubusercontent.com/thoughtbot/guides/master/style/ruby/.rubocop.yml
Remove remaining RuboCop TODOs Closes #1202 We have fixed the bulk of the RuboCop TODOs. The main TODO remaining (line length) involves a large number of files, and I don't think it is worth trying to update them all at once. I did fix a few of the worst offenders so we could bring the max down a bit. We can gradually bring this number down as we fix more of the violations.
2018-10-21 11:39:48 -04:00
Fix assorted RuboCop spacing volations (#1203) * Alphabetize gem listing in various Gemfiles [Rubocop Bundler/OrderedGems] * Fix alignment of if/else/end statement [Rubocop Layout/ElseAlignment] * Method definitions should have a empty line between them [Rubocop Layout/EmptyLineBetweenDefs] * Modules, Classes, and blocks should have an empty line around them [Rubocop] Cops: Layout/EmptyLinesAroundBlockBody Layout/EmptyLinesAroundModuleBody Layout/EmptyLinesAroundClassBody Layout/EmptyLinesAroundAccessModifier * Keep a blank line before and after access modifiers [Rubocop Layout/EmptyLinesAroundAccessModifier] * Remove misc extra whitespace [Rubocop Layout/ExtraSpacing] * Indent the first line of the right-hand-side of a multi-line assignment [Rubocop Layout/IndentAssignment] * Remove extraneous whitespace [Rubocop] Cops: Layout/IndentationWidth Layout/LeadingCommentSpace Layout/SpaceAroundEqualsInParameterDefault Layout/SpaceInsideArrayLiteralBrackets Layout/SpaceInsideBlockBraces Layout/SpaceInsideParens Layout/TrailingBlankLines * Revert rubocop changes to gemfiles; exclude files from rubocop checks The files in gemfiles/ are generated by Appraisal, so we shouldn't edit them. Instead, let's tell RuboCop to exclude this directory.
2018-09-27 21:35:05 -04:00
AllCops:
[Rubocop] Performance Cop Offenses (#1209)
2018-10-04 21:07:56 -04:00
TargetRubyVersion: 2.3
Fix assorted RuboCop spacing volations (#1203) * Alphabetize gem listing in various Gemfiles [Rubocop Bundler/OrderedGems] * Fix alignment of if/else/end statement [Rubocop Layout/ElseAlignment] * Method definitions should have a empty line between them [Rubocop Layout/EmptyLineBetweenDefs] * Modules, Classes, and blocks should have an empty line around them [Rubocop] Cops: Layout/EmptyLinesAroundBlockBody Layout/EmptyLinesAroundModuleBody Layout/EmptyLinesAroundClassBody Layout/EmptyLinesAroundAccessModifier * Keep a blank line before and after access modifiers [Rubocop Layout/EmptyLinesAroundAccessModifier] * Remove misc extra whitespace [Rubocop Layout/ExtraSpacing] * Indent the first line of the right-hand-side of a multi-line assignment [Rubocop Layout/IndentAssignment] * Remove extraneous whitespace [Rubocop] Cops: Layout/IndentationWidth Layout/LeadingCommentSpace Layout/SpaceAroundEqualsInParameterDefault Layout/SpaceInsideArrayLiteralBrackets Layout/SpaceInsideBlockBraces Layout/SpaceInsideParens Layout/TrailingBlankLines * Revert rubocop changes to gemfiles; exclude files from rubocop checks The files in gemfiles/ are generated by Appraisal, so we shouldn't edit them. Instead, let's tell RuboCop to exclude this directory.
2018-09-27 21:35:05 -04:00
Exclude:
- 'gemfiles/*'
Avoid running RuboCop on tmp files
2018-09-27 21:43:33 -04:00
- 'tmp/**/*'
Add rubocop to run rubocop locally and not to wait for HoundCI to bark at us. The version is locked to 0.54 because this is the version HoundCI is using. Using a newer version will not work as config changed from 0.54 to currently 0.59 and rubocop would complain with the old configuration. thoughtbot uses the .rubocop.yml in thoughtbot/guides as the orginizational config on Hound, so we inherit from it so we can use the same config locally. Fix #1195.
2018-09-15 10:16:10 -04:00
Metrics/BlockLength:
Remove remaining RuboCop TODOs Closes #1202 We have fixed the bulk of the RuboCop TODOs. The main TODO remaining (line length) involves a large number of files, and I don't think it is worth trying to update them all at once. I did fix a few of the worst offenders so we could bring the max down a bit. We can gradually bring this number down as we fix more of the violations.
2018-10-21 11:39:48 -04:00
CountComments: true
Max: 25
ExcludedMethods: []
Add rubocop to run rubocop locally and not to wait for HoundCI to bark at us. The version is locked to 0.54 because this is the version HoundCI is using. Using a newer version will not work as config changed from 0.54 to currently 0.59 and rubocop would complain with the old configuration. thoughtbot uses the .rubocop.yml in thoughtbot/guides as the orginizational config on Hound, so we inherit from it so we can use the same config locally. Fix #1195.
2018-09-15 10:16:10 -04:00
Exclude:
Remove remaining RuboCop TODOs Closes #1202 We have fixed the bulk of the RuboCop TODOs. The main TODO remaining (line length) involves a large number of files, and I don't think it is worth trying to update them all at once. I did fix a few of the worst offenders so we could bring the max down a bit. We can gradually bring this number down as we fix more of the violations.
2018-10-21 11:39:48 -04:00
- "spec/**/*"
- '*.gemspec'
Style/SymbolArray:
EnforcedStyle: brackets
Add rubocop to run rubocop locally and not to wait for HoundCI to bark at us. The version is locked to 0.54 because this is the version HoundCI is using. Using a newer version will not work as config changed from 0.54 to currently 0.59 and rubocop would complain with the old configuration. thoughtbot uses the .rubocop.yml in thoughtbot/guides as the orginizational config on Hound, so we inherit from it so we can use the same config locally. Fix #1195.
2018-09-15 10:16:10 -04:00
Style/FormatStringToken:
Remove remaining RuboCop TODOs Closes #1202 We have fixed the bulk of the RuboCop TODOs. The main TODO remaining (line length) involves a large number of files, and I don't think it is worth trying to update them all at once. I did fix a few of the worst offenders so we could bring the max down a bit. We can gradually bring this number down as we fix more of the violations.
2018-10-21 11:39:48 -04:00
Enabled: false
Add rubocop to run rubocop locally and not to wait for HoundCI to bark at us. The version is locked to 0.54 because this is the version HoundCI is using. Using a newer version will not work as config changed from 0.54 to currently 0.59 and rubocop would complain with the old configuration. thoughtbot uses the .rubocop.yml in thoughtbot/guides as the orginizational config on Hound, so we inherit from it so we can use the same config locally. Fix #1195.
2018-09-15 10:16:10 -04:00
Remove remaining RuboCop TODOs Closes #1202 We have fixed the bulk of the RuboCop TODOs. The main TODO remaining (line length) involves a large number of files, and I don't think it is worth trying to update them all at once. I did fix a few of the worst offenders so we could bring the max down a bit. We can gradually bring this number down as we fix more of the violations.
2018-10-21 11:39:48 -04:00
# TODO: gradually bring this down to 80 as we fix files
# Let's not open a big PR to fix all of these at once -
# we can fix gradually if we happen to be editing a file that has a violation
Metrics/LineLength:
Arrest lines of an unsavory length We had configured RuboCop to allow lines with up to 142 characters. This PR fixes a few of the worst offenders so we can bring that number down to 110.
2018-12-12 11:05:13 -05:00
Max: 110
Copy permalink