Raise AttributeDefinitionError when defining an attribute with f.attr=value rather than f.attr value; ticket #8

lib/factory_girl/factory.rb

@@ -1,5 +1,8 @@
 class Factory
   
+  class AttributeDefinitionError < RuntimeError
+  end
+  
   cattr_accessor :factories, :sequences #:nodoc:
   self.factories = {}
   self.sequences = {}
@@ -93,6 +96,10 @@ class Factory
   #   value: (Object)
   #     If no block is given, this value will be used for this attribute.
   def add_attribute (name, value = nil, &block)
+    if name.to_s =~ /=$/
+      raise AttributeDefinitionError, "factory_girl uses 'f.#{name.to_s.chop} #{value}' syntax rather than 'f.#{name} #{value}'" 
+    end
+    
     if block_given?
       unless value.nil?
         raise ArgumentError, "Both value and block given"

test/factory_test.rb

@@ -52,6 +52,14 @@ class FactoryTest < Test::Unit::TestCase
 
   end
   
+  should "raise an error when defining a factory when using attribute setters" do
+    assert_raise Factory::AttributeDefinitionError do
+      Factory.define(:user) do |f|
+        f.name = 'test'
+      end
+    end
+  end
+
   context "defining a sequence" do
 
     setup do