From 6e511597c833efaffe331ed84299c18b549e46c7 Mon Sep 17 00:00:00 2001 From: Daniel Colson Date: Mon, 19 Nov 2018 00:00:21 -0500 Subject: [PATCH] Remove unhelpful lint specs These specs have no expectations, and they are passing `validate_traits` as an option, which is not an option the linter understands. Since the first spec is already covered by "allows for selective linting" above, and what I assume the second spec was meaning to cover is covered by the trait specs, I see no reason to keep these around. --- spec/acceptance/lint_spec.rb | 28 ---------------------------- 1 file changed, 28 deletions(-) diff --git a/spec/acceptance/lint_spec.rb b/spec/acceptance/lint_spec.rb index d8de06d..0e16623 100644 --- a/spec/acceptance/lint_spec.rb +++ b/spec/acceptance/lint_spec.rb @@ -61,34 +61,6 @@ describe "FactoryBot.lint" do end.not_to raise_error end - it "allows for explicit factories and additional options" do - define_model "User", name: :string do - validates :name, presence: true - end - - FactoryBot.define do - factory :user do - name { "assigned" } - end - end - - FactoryBot.lint FactoryBot.factories, validate_traits: true - end - - it "allows for additional options without explicit factories" do - define_model "User", name: :string do - validates :name, presence: true - end - - FactoryBot.define do - factory :user do - name { "assigned" } - end - end - - FactoryBot.lint validate_traits: true - end - describe "trait validation" do context "enabled" do it "raises if a trait produces an invalid object" do