From 877646eeacf4bcb59dafe1c8259f4195cda043b1 Mon Sep 17 00:00:00 2001
From: Richie Thomas <richie@thoughtbot.com>
Date: Wed, 23 Oct 2019 14:19:40 -0700
Subject: [PATCH] Refactor null_factory_spec.rb to conform to Let's Not style
 (#1347)

---
 spec/factory_bot/null_factory_spec.rb | 54 +++++++++++++++++++++++----
 1 file changed, 46 insertions(+), 8 deletions(-)

diff --git a/spec/factory_bot/null_factory_spec.rb b/spec/factory_bot/null_factory_spec.rb
index 69d4eae..c492fe5 100644
--- a/spec/factory_bot/null_factory_spec.rb
+++ b/spec/factory_bot/null_factory_spec.rb
@@ -1,11 +1,49 @@
 describe FactoryBot::NullFactory do
-  it { should delegate(:defined_traits).to(:definition) }
-  it { should delegate(:callbacks).to(:definition) }
-  it { should delegate(:attributes).to(:definition) }
-  it { should delegate(:constructor).to(:definition) }
+  it "delegates defined traits to its definition" do
+    null_factory = FactoryBot::NullFactory.new
 
-  its(:compile)         { should be_nil }
-  its(:class_name)      { should be_nil }
-  its(:attributes)      { should be_an_instance_of(FactoryBot::AttributeList) }
-  its(:evaluator_class) { should eq FactoryBot::Evaluator }
+    expect(null_factory).to delegate(:defined_traits).to(:definition)
+  end
+
+  it "delegates callbacks to its definition" do
+    null_factory = FactoryBot::NullFactory.new
+
+    expect(null_factory).to delegate(:callbacks).to(:definition)
+  end
+
+  it "delegates attributes to its definition" do
+    null_factory = FactoryBot::NullFactory.new
+
+    expect(null_factory).to delegate(:attributes).to(:definition)
+  end
+
+  it "delegates constructor to its definition" do
+    null_factory = FactoryBot::NullFactory.new
+
+    expect(null_factory).to delegate(:constructor).to(:definition)
+  end
+
+  it "has a nil value for its compile attribute" do
+    null_factory = FactoryBot::NullFactory.new
+
+    expect(null_factory.compile).to be_nil
+  end
+
+  it "has a nil value for its class_name attribute" do
+    null_factory = FactoryBot::NullFactory.new
+
+    expect(null_factory.class_name).to be_nil
+  end
+
+  it "has an instance of FactoryBot::AttributeList for its attributes attribute" do
+    null_factory = FactoryBot::NullFactory.new
+
+    expect(null_factory.attributes).to be_an_instance_of(FactoryBot::AttributeList)
+  end
+
+  it "has FactoryBot::Evaluator as its evaluator class" do
+    null_factory = FactoryBot::NullFactory.new
+
+    expect(null_factory.evaluator_class).to eq FactoryBot::Evaluator
+  end
 end