Refactors strategy_calculator_spec.rb to conform to Let's Not style (#1351)

spec/factory_bot/strategy_calculator_spec.rb

@@ -1,30 +1,24 @@
 describe FactoryBot::StrategyCalculator do
-  let(:strategy) do
+  it "returns the class passed when it is instantiated with a class" do
-    define_class("MyAwesomeClass")
+    strategy = define_class("MyAwesomeClass")
+    calculator = FactoryBot::StrategyCalculator.new(strategy).strategy
+
+    expect(calculator).to eq strategy
   end
 
-  context "when a class" do
+  it "finds the strategy by name when instantiated with a symbol" do
-    subject { FactoryBot::StrategyCalculator.new(strategy).strategy }
+    strategy = define_class("MyAwesomeClass")
+    allow(FactoryBot::Internal).to receive(:strategy_by_name).and_return(strategy)
+    FactoryBot::StrategyCalculator.new(:build).strategy
 
-    it "returns the class passed" do
+    expect(FactoryBot::Internal).to have_received(:strategy_by_name).with(:build)
-      expect(subject).to eq strategy
-    end
   end
 
-  context "when a symbol" do
+  it "returns the strategy found when instantiated with a symbol" do
-    before do
+    strategy = define_class("MyAwesomeClass")
-      allow(FactoryBot::Internal).to receive(:strategy_by_name).and_return(strategy)
+    allow(FactoryBot::Internal).to receive(:strategy_by_name).and_return(strategy)
-    end
+    calculator = FactoryBot::StrategyCalculator.new(:build).strategy
 
-    subject { FactoryBot::StrategyCalculator.new(:build).strategy }
+    expect(calculator).to eq strategy
-
-    it "finds the strategy by name" do
-      subject
-      expect(FactoryBot::Internal).to have_received(:strategy_by_name).with(:build)
-    end
-
-    it "returns the strategy found" do
-      expect(subject).to eq strategy
-    end
   end
 end