From eb51bed2fc935441f815055afbfab4a66077e558 Mon Sep 17 00:00:00 2001 From: Ben Orenstein Date: Wed, 29 Jun 2011 10:32:23 -0400 Subject: [PATCH] Update the contribution guidelines. Pull requests please. --- CONTRIBUTION_GUIDELINES.md | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/CONTRIBUTION_GUIDELINES.md b/CONTRIBUTION_GUIDELINES.md index 891397f..75e23b6 100644 --- a/CONTRIBUTION_GUIDELINES.md +++ b/CONTRIBUTION_GUIDELINES.md @@ -1,9 +1,9 @@ -We're using [GitHub](http://github.com/thoughtbot/factory_girl/tree/master), and we've been getting any combination of github pull requests, patches, emails, etc. We need to normalize this workflow to make sure we don't miss any fixes. +Contributing to factory_girl: -* Make sure you're accessing the source from the [official repository](http://github.com/thoughtbot/factory_girl/tree/master). -* Please make a branch for each separate contribution. We can cherry pick your commits, but pulling from a branch is easier. -* If you're submitting patches, please cut each fix or feature into a separate patch. -* There should be an [issue](http://github.com/thoughtbot/factory_girl/issues) for any submission. If you've found a bug and want to fix it, open a new ticket at the same time. -* Please don't send pull requests Just update the issue with the url for your fix when it's ready. The github pull requests pretty much get dropped on the floor until someone with commit rights notices them in the mailbox. +1. Fork the [official repository](http://github.com/thoughtbot/factory_girl/tree/master). +2. Make your changes in a topic branch. +3. Send a pull request. + +Notes: * Contributions without tests won't be accepted. -* Please don't submit patches or branches that update the Gem version. +* Please don't update the Gem version.