1
0
Fork 0
mirror of https://github.com/thoughtbot/factory_bot.git synced 2022-11-09 11:43:51 -05:00

Ensure attributes set on instance are calculated uniquely

This fixes a bug where assignment occurs multiple times; in the case of
nested attributes, assignment mutates the instance, meaning that it
occurring multiple times will cause issues.

Closes #314
This commit is contained in:
Joshua Clayton 2012-03-16 13:04:31 -04:00
parent 0d7520e825
commit f5d4db1085
2 changed files with 33 additions and 1 deletions

View file

@ -37,7 +37,7 @@ module FactoryGirl
end
def attributes_to_set_on_instance
attribute_names_to_assign - @attribute_names_assigned
(attribute_names_to_assign - @attribute_names_assigned).uniq
end
def attributes_to_set_on_hash

View file

@ -0,0 +1,32 @@
require "spec_helper"
describe "association assignment from nested attributes" do
before do
define_model("Post", :title => :string) do
has_many :comments
accepts_nested_attributes_for :comments
end
define_model("Comment", :post_id => :integer, :body => :text) do
belongs_to :post
end
FactoryGirl.define do
factory :post do
comments_attributes { [FactoryGirl.attributes_for(:comment), FactoryGirl.attributes_for(:comment)] }
end
factory :comment do
sequence(:body) {|n| "Body #{n}" }
end
end
end
it "assigns the correct amount of comments" do
FactoryGirl.create(:post).comments.count.should == 2
end
it "assigns the correct amount of comments when overridden" do
FactoryGirl.create(:post, :comments_attributes => [FactoryGirl.attributes_for(:comment)]).comments.count.should == 1
end
end