kotovalexarian-likes-github/thoughtbot--factory_bot

Fork 0

mirror of https://github.com/thoughtbot/factory_bot.git synced 2022-11-09 11:43:51 -05:00

Commit graph

Author	SHA1	Message	Date
Oliver Peate	7722017bc7	Adjust use_parent_strategy safely in specs Uses a block-based helper so we can remove a global around hook.	2019-08-12 18:54:53 +01:00
Daniel Colson	3e1a941347	Do not reset use_parent_strategy on reload Before this PR, `use_parent_strategy` was set on the configuration instance. Since `FactoryBot.reload` wipes out the configuration, it also ends up resetting `use_parent_strategy` back to `nil`. This can cause problems when using factory_bot_rails with Spring, since it calls `FactoryBot.reload` each time Spring forks. If `use_parent_strategy` is set in a file that Spring preloads, like in an initializer, then the value will get wiped out. With this PR, we set `use_parent_strategy` directly on FactoryBot, rather than on the configuration instance, and so reloading no longer has any effect.	2019-01-04 15:47:32 -05:00

Author

SHA1

Message

Date

Oliver Peate

7722017bc7

Adjust use_parent_strategy safely in specs

Uses a block-based helper so we can remove a global around hook.

2019-08-12 18:54:53 +01:00

Daniel Colson

3e1a941347

Do not reset use_parent_strategy on reload

Before this PR, `use_parent_strategy` was set on the configuration
instance. Since `FactoryBot.reload` wipes out the configuration, it also
ends up resetting `use_parent_strategy` back to `nil`.

This can cause problems when using factory_bot_rails with Spring, since
it calls `FactoryBot.reload` each time Spring forks. If
`use_parent_strategy` is set in a file that Spring preloads, like in an
initializer, then the value will get wiped out.

With this PR, we set `use_parent_strategy` directly on FactoryBot,
rather than on the configuration instance, and so reloading no longer
has any effect.

2019-01-04 15:47:32 -05:00

2 commits