Commit Graph

12 Commits

Author SHA1 Message Date
Daniel Colson 6d8bea1670
Update Rubocop to support new thoughtbot defaults
One annoyance is that the thoughtbot defaults include the Rails
cops, which don't quite make sense here. I am forced into loading the
rubocop-rails gem but then disabling all of the cops in it.
2020-01-17 14:43:34 -05:00
Nate Holland 41468b09f3
Bump rubocop to latest version (0.68.1)
This pushes rubocop to the latest version. They have since extracted out
the performance cops into the rubocop-performance gem. Those cops were
originally used so I pulled the gem in and required it.
2020-01-17 14:43:34 -05:00
Matijs van Zuijlen 24f6d212f5
Get default strategy registration working on JRuby
fixes #1331

The commit avoids a bug in JRuby, and adds JRuby back to the test matrix
so we can catch regressions in the future.
2019-10-02 18:56:58 -04:00
Oliver Peate eabb1a35ee Switch from TimeCop to ActiveSupport::Testing::TimeHelpers
Removes a (development) dependency 🎉
2019-08-01 11:21:06 +01:00
Sweta Sanghavi c01d73cdf1 Bump to version 5.0.1 [ci skip] 2019-02-15 15:39:11 -08:00
Daniel Colson 27edb29a96
Bump Ruby and Rails requirements in gemspec
factory\_bot 5 will only support Ruby 2.3 and higher, and Rails 4.2 and
higher. This includes all versions that have not yet reached EOL:

https://www.ruby-lang.org/en/downloads/branches/
https://guides.rubyonrails.org/maintenance_policy.html
2019-01-04 22:19:11 -05:00
Daniel Colson 70bc8e2d20
Update development dependencies
I consolidated all the development dependencies in the gemspec,
then ran `bundle update` and `appraisal install`.

I also got rid of unnecessary version constraints (I would rather just
the latest versions of things in development, and we can always add
constraints later if necessary), and removed the jruby-specific gems
since we aren't testing on jruby anymore.
2019-01-04 20:59:12 -05:00
Susan Wright c22c9ab052 Rubocop: Fix Style/StringLiterals Offenses (#1216) 2018-10-07 21:45:51 -04:00
Hunter Braun 89ee4a4524 [Rubocop] Style Cop Offenses (#1208) 2018-10-07 18:02:54 -04:00
Berkhan Berkdemir 385c9b7432 Fix missing docs (#1172) 2018-09-03 13:27:53 +00:00
Daniel Colson fc451872b9
Don't include extra files in the gem (#1167)
With `git ls-files` we were still including unneeded dotfiles and
appraisal files. This switches to a whitelist of files included in the
gem, rather than a blacklist. I also tried to make RuboCop happy while I
was in here.
2018-08-15 10:39:30 -04:00
Avielle c716ce01b4 Replace 'girl' with 'bot' everywhere (#1051)
Also: add a deprecation warning to factory_girl, asking users to switch to
factory_bot

https://github.com/thoughtbot/factory_girl/issues/921
2017-10-20 15:20:28 -04:00