5 commits

Author	SHA1	Message	Date
Eugene Kenny	e7ddcbccc5	Only undefine methods that were previously defined ... In 241e8e5fb4, this call to `undef_method` was introduced to suppress the warning printed by Ruby when a method is redefined. That warning is only printed when the method is already defined on the class in question; it isn't printed when the method was inherited from an ancestor, since overriding methods by shadowing them is a feature. However, `method_defined?` returns true for inherited methods, which means we're sometimes undefining methods that wouldn't cause a warning. If a factory defines an attribute named `object_id` (admittedly not a great idea), we will undefine the `object_id` method inherited from the `Object` class, and the following warning will be printed: factory_bot/evaluator.rb:70: warning: undefining `object_id' may cause serious problems By only undefining the method if it's defined on the current class, we can avoid undefining inherited methods and triggering this warning.	2019-03-22 10:30:08 -04:00
Claire	c71aded778	Inline disabling Style/MethodMissing Cop ... To make it obvious that these are non-standard cases. Also add respond_to_missing? to the decorator. We are using Style/MethodMissing rather than Style/MethodMissingSuper and Style/MissingRespondToMissing because we are still on RuboCop 0.54.	2018-11-12 15:01:23 -08:00
Susan Wright	c22c9ab052	Rubocop: Fix Style/StringLiterals Offenses (#1216)	2018-10-07 21:45:51 -04:00
Hunter Braun	6a25e989b6	[Rubocop] Lint Cop Offenses (#1207)	2018-10-05 14:54:08 -04:00
Avielle	c716ce01b4	Replace 'girl' with 'bot' everywhere (#1051) ... Also: add a deprecation warning to factory_girl, asking users to switch to factory_bot https://github.com/thoughtbot/factory_girl/issues/921	2017-10-20 15:20:28 -04:00

Renamed from lib/factory_girl/evaluator.rb (Browse further)