1
0
Fork 0
mirror of https://github.com/thoughtbot/factory_bot.git synced 2022-11-09 11:43:51 -05:00
thoughtbot--factory_bot/spec/factory_bot
Alejandro Dustet 5947e10578 Deprecate and move to Internal sequence methods
Why:
Another run of internal methods that should not be publicly
available from the base namespace.
This time the sequence involving methods were moved. It's worth noticing
that the ```Internal``` class is getting crowded. Maybe we can start
name-spacing the internal groups into modules under
```internal/sequence.rb``` ```internal/trait.rb``` and so on. Thoughts?

This PR:

- Moves the ```register_sequence```, ```sequence_by_name```,
```sequences``` and ```rewind_sequences``` to the
```FactoryBot::Internal``` module.
- Deprecates uses of ```sequence_by_name```, and ```sequences```
from the ```FactoryBot``` module.
- Refactor rewind sequences test to use spies

This is one of the steps towards fixing [this
issue](https://github.com/thoughtbot/factory_bot/pull/1285#1281)
2019-06-04 19:02:51 -04:00
..
attribute Deprecate and move to Internal sequence methods 2019-06-04 19:02:51 -04:00
declaration Deprecate and move to Internal sequence methods 2019-06-04 19:02:51 -04:00
decorator Avoid recursive call to AttributeHash#attributes 2018-10-26 10:51:05 -04:00
strategy Do not add missing timestamps when using build stubbed strategy 2018-08-05 17:46:38 -04:00
aliases_spec.rb Remove unnecessary spec_helper requires 2018-05-21 18:03:28 +01:00
attribute_list_spec.rb Remove remaining RuboCop TODOs 2018-10-21 12:15:32 -04:00
attribute_spec.rb Remove warning about setter methods 2018-09-28 16:59:48 -04:00
callback_spec.rb Remove unnecessary spec_helper requires 2018-05-21 18:03:28 +01:00
declaration_list_spec.rb Remove references to static attributes 2018-09-28 17:35:10 -04:00
definition_proxy_spec.rb Improve error for static attribute attempts 2019-04-26 12:47:12 -04:00
definition_spec.rb Register inline sequence to allow for rewinding 2018-09-08 02:29:30 +00:00
disallows_duplicates_registry_spec.rb Remove unnecessary spec_helper requires 2018-05-21 18:03:28 +01:00
evaluator_class_definer_spec.rb [Rubocop] Style Cop Offenses (#1208) 2018-10-07 18:02:54 -04:00
factory_spec.rb Remove unhelpful spec 2018-11-18 15:47:55 -05:00
find_definitions_spec.rb Rubocop: Fix Style/StringLiterals Offenses (#1216) 2018-10-07 21:45:51 -04:00
internal_spec.rb Deprecate and move to Internal sequence methods 2019-06-04 19:02:51 -04:00
null_factory_spec.rb Remove unnecessary spec_helper requires 2018-05-21 18:03:28 +01:00
null_object_spec.rb Remove unnecessary spec_helper requires 2018-05-21 18:03:28 +01:00
registry_spec.rb Remove problematic did_you_mean spec 2018-12-16 22:48:06 -05:00
sequence_spec.rb Remove unnecessary spec_helper requires 2018-05-21 18:03:28 +01:00
strategy_calculator_spec.rb Remove unnecessary spec_helper requires 2018-05-21 18:03:28 +01:00