1
0
Fork 0
mirror of https://github.com/thoughtbot/factory_bot.git synced 2022-11-09 11:43:51 -05:00
thoughtbot--factory_bot/spec/factory_bot_spec.rb
Alejandro Dustet 99ac02400f Move and deprecate trait methods from FactoryBot
Why:
These are essentially internal methods that should not be publicly
available from the base namespace.
One thing worth noticing is that the use of this methods internally was
almost exclusively in the `syntax/default` except for one use on the
`factory_bot/definition`.
Also the deprecation silencing module was referring to the singleton
instance of the ```ActiveRecord::Deprecation``` class and not to the new
deprecation instance that was being used in the ```FactoryBot``` module.

This PR:
- Moves the `trait_by_name` and `register_trait` into the
`FactoryBot::Internal` module
- Deprecates uses of `trait_by_name`, `register_trait` and `traits` from
the `FactoryBot` module.
- Rename DEPRECATOR => Deprecation

This is one of the steps towards fixing [this
issue](https://github.com/thoughtbot/factory_bot/issues/1281)
2019-04-26 16:03:22 -04:00

26 lines
797 B
Ruby

describe FactoryBot do
let(:factory) { FactoryBot::Factory.new(:object) }
let(:sequence) { FactoryBot::Sequence.new(:email) }
let(:trait) { FactoryBot::Trait.new(:admin) }
it "finds a registered factory" do
FactoryBot.register_factory(factory)
expect(FactoryBot.factory_by_name(factory.name)).to eq factory
end
it "finds a registered sequence" do
FactoryBot.register_sequence(sequence)
expect(FactoryBot.sequence_by_name(sequence.name)).to eq sequence
end
it "finds a registered trait", :silence_deprecation do
FactoryBot.register_trait(trait)
expect(FactoryBot.trait_by_name(trait.name)).to eq trait
end
describe ".use_parent_strategy" do
it "is true by default" do
expect(FactoryBot.use_parent_strategy).to be true
end
end
end